mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Jeffery <andrew@codeconstruct.com.au>
To: Mike Hsieh <mike.quanta.115@gmail.com>,
	Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
	Patrick Williams <patrick@stwcx.xyz>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	 linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	Cosmo Chou <cosmo.chou@quantatw.com>,
	Potin Lai <potin.lai@quantatw.com>,
	Mik Lin <mik.lin@quantatw.com>,
	Mike Hsieh <Mike_Hsieh@quantatw.com>
Subject: Re: [PATCH 2/2] ARM: dts: aspeed: sanmiguel: add current-range property for PDB HSC
Date: Wed, 22 Jul 2026 21:37:13 +0930	[thread overview]
Message-ID: <831a8c9b383d3e765a49fa35e1e36d75504fee1d.camel@codeconstruct.com.au> (raw)
In-Reply-To: <20260618-sanmiguel-dts-config-hsc-lm5066i-v1-2-cccf959c9b78@gmail.com>

On Thu, 2026-06-18 at 15:41 +0800, Mike Hsieh wrote:
> Configure the ti,current-range property for the four TI LM5066i
> hot-swap controllers on PDB board.
> 
> This defines the hardware current limit operating mode (low/high)
> for each sensor to match the physical board design.
> 
> Specific configurations:
> - HSC1 (0x11): low
> - HSC2 (0x13): high
> - HSC3 (0x15): high
> - HSC4 (0x17): low
> 
> Signed-off-by: Mike Hsieh <mike.quanta.115@gmail.com>
> ---
>  arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-sanmiguel.dts | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-sanmiguel.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-sanmiguel.dts
> index 3faac0925a79..e518e3fc1c97 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-sanmiguel.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-sanmiguel.dts
> @@ -451,6 +451,7 @@ pdb_ti_hsc1: power-monitor@11 {
>  		compatible = "ti,lm5066i";
>  		reg = <0x11>;
>  		shunt-resistor-micro-ohms = <1000>;
> +		ti,current-range = "low";
>  	};
>  
>  	pdb_mps_hsc2: power-monitor@12 {
> @@ -462,6 +463,7 @@ pdb_ti_hsc2: power-monitor@13 {
>  		compatible = "ti,lm5066i";
>  		reg = <0x13>;
>  		shunt-resistor-micro-ohms = <321>;
> +		ti,current-range = "high";
>  	};
>  
>  	pdb_mps_hsc3: power-monitor@14 {
> @@ -473,6 +475,7 @@ pdb_ti_hsc3: power-monitor@15 {
>  		compatible = "ti,lm5066i";
>  		reg = <0x15>;
>  		shunt-resistor-micro-ohms = <321>;
> +		ti,current-range = "high";
>  	};
>  
>  	pdb_mps_hsc4: power-monitor@16 {
> @@ -484,6 +487,7 @@ pdb_ti_hsc4: power-monitor@17 {
>  		compatible = "ti,lm5066i";
>  		reg = <0x17>;
>  		shunt-resistor-micro-ohms = <500>;
> +		ti,current-range = "low";
>  	};
>  
>  	pdb_ioexp_20: gpio@20 {

The property isn't inspected by the associated driver, nor is it
allowed by the binding:

   arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-sanmiguel.dtb: power-monitor@11 (ti,lm5066i): Unevaluated properties are not allowed ('ti,current-range' was unexpected)
           from schema $id: http://devicetree.org/schemas/hwmon/pmbus/ti,lm25066.yaml
   arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-sanmiguel.dtb: power-monitor@13 (ti,lm5066i): Unevaluated properties are not allowed ('ti,current-range' was unexpected)
           from schema $id: http://devicetree.org/schemas/hwmon/pmbus/ti,lm25066.yaml
   arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-sanmiguel.dtb: power-monitor@15 (ti,lm5066i): Unevaluated properties are not allowed ('ti,current-range' was unexpected)
           from schema $id: http://devicetree.org/schemas/hwmon/pmbus/ti,lm25066.yaml
   arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-sanmiguel.dtb: power-monitor@17 (ti,lm5066i): Unevaluated properties are not allowed ('ti,current-range' was unexpected)
           from schema $id: http://devicetree.org/schemas/hwmon/pmbus/ti,lm25066.yaml

Andrew

      reply	other threads:[~2026-07-22 12:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-18  7:41 [PATCH 0/2] ARM: dts: aspeed: sanmiguel: configure LM5066i HSCs for PDB Mike Hsieh
2026-06-18  7:41 ` [PATCH 1/2] ARM: dts: aspeed: sanmiguel: fix PDB HSC shunt resistor Mike Hsieh
2026-07-22 12:07   ` Andrew Jeffery
2026-06-18  7:41 ` [PATCH 2/2] ARM: dts: aspeed: sanmiguel: add current-range property for PDB HSC Mike Hsieh
2026-07-22 12:07   ` Andrew Jeffery [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=831a8c9b383d3e765a49fa35e1e36d75504fee1d.camel@codeconstruct.com.au \
    --to=andrew@codeconstruct.com.au \
    --cc=Mike_Hsieh@quantatw.com \
    --cc=conor+dt@kernel.org \
    --cc=cosmo.chou@quantatw.com \
    --cc=devicetree@vger.kernel.org \
    --cc=joel@jms.id.au \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mik.lin@quantatw.com \
    --cc=mike.quanta.115@gmail.com \
    --cc=patrick@stwcx.xyz \
    --cc=potin.lai@quantatw.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome