From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2EACE441D for ; Mon, 24 Jun 2024 11:34:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719228870; cv=none; b=Ku2ucPP7pcodGJE/c5dujbbi75kxl8mjTPZXFyI2rbat1ZeYfeyHo0wRvRLDROfwZTZYVIhWFKIb0p9sf1v7GPKhgknQCvUcOwDzlzkl2KfAZD85zkx6KDsxuG5cdbCE3M77Fefmzgi44irTkQWHPtyC5UAiJl5MMzb/RBZt5YI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719228870; c=relaxed/simple; bh=C5DI4ykUX6mfuJFUQoRUWoodzXe5F79p4mr3sTH61Ts=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=te806fpTdlimRTatvb7bLYAXI/+Sip12d7LAWo4AV+BSH06ec+fkBYESfa2059mLD2kuGOC9Y+yJAu+U5GSRFDX8wVDUk9dp+Gkyct6wPOt0/arZMYzdge3Lix+yxhQeRsqkPFAy2RD/caz7oU+NjWJxVEGU52w5dc1N5G5NBjU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Ggt9n7nB; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Ggt9n7nB" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1719228868; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jG3E5jkG60r/vDkubJ7vrvwdnrUq2QMfexXsOxqXG1U=; b=Ggt9n7nBVVeszTHl30eurKfuQ9D0YkBhbLWraJ9yIe0EUJsuU0YHm3Lfwk6FG+fydivyIu pXHHr5P8b38XbTpfehXqOluU8Mv4s7QQ3IQWyIZcoz0p6zlEj+Jrepw20WvVLIXLMvDHag GwR9sBvlE4QWotyJkBrRXXPzBXgMyJ8= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-145-iTMB6bXPP9uqcGVVIPsarg-1; Mon, 24 Jun 2024 07:34:27 -0400 X-MC-Unique: iTMB6bXPP9uqcGVVIPsarg-1 Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-a724b61d37eso55740166b.3 for ; Mon, 24 Jun 2024 04:34:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719228865; x=1719833665; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jG3E5jkG60r/vDkubJ7vrvwdnrUq2QMfexXsOxqXG1U=; b=PDRuI7OrFG4UaZxEfyJHjP4PvnJwlEtybQpj6hMOe2a4WSDA5mYqoA51DmbXHcw7D7 6okpb6iQEaYc8nKWm5PA8JZPq9+GqL8nyyWDWkZGNrdDwybFOueGDg94ITEQSD+dQU7r T431ak7UBEx+HO75i1NXtkq/c81pTZeKbF9qBHC5ecLe5t40/UTCc91riDPsdy6VBFLA 8Cmu9V2lYrhOfOAeP4xCUeFL+VqA/yRJgNoEfLN7AG+276QrYC11gWbiEpaJIL9cMhlQ wwMD5YS9C4xic+sdQMv/XgOoYqYnvy8VptCirhtqPlKFV6umil3tGu/j+Shlmoa/LyCD RS3g== X-Forwarded-Encrypted: i=1; AJvYcCWwmukczh2rkWsHw7xhucoV3yvSkaea7UgiamSizrJrm780/dn81n6MY74lN9lm2BW39a2ALSasaNhop1BRFuIQwsm0HmME67/UktZo X-Gm-Message-State: AOJu0YwtihgEoqqdme/SzgUf5cv7MeuI9MQUXFhKgzmbCfbr21YFSkq9 aXa3q2PtADs7HhhI27UQyuxluLyU8qxcNX3LevFABKTfQcx2/7H4E5JCx7iEJUzI4xr4wnvOWfP kI1hoZUJnvawceMTyCmeOU5kwxituU5paEP++XtXvs19WJKsorbC1HM+ibiwU5A== X-Received: by 2002:a17:907:8b8c:b0:a72:4b31:13aa with SMTP id a640c23a62f3a-a724b311555mr254430066b.55.1719228865681; Mon, 24 Jun 2024 04:34:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEcRcb81PEYVXUvfHSEHi4n32Xp2cLtUT8BSe+FrmeethJzuTtdbHVxDMyQ0FVaHYL8O487mA== X-Received: by 2002:a17:907:8b8c:b0:a72:4b31:13aa with SMTP id a640c23a62f3a-a724b311555mr254429166b.55.1719228865399; Mon, 24 Jun 2024 04:34:25 -0700 (PDT) Received: from [10.40.98.157] ([78.108.130.194]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a6fcf560929sm399519266b.155.2024.06.24.04.34.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Jun 2024 04:34:25 -0700 (PDT) Message-ID: <83211fc2-fe45-40f9-bcb6-22227b9ac715@redhat.com> Date: Mon, 24 Jun 2024 13:34:24 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] platform/x86: add missing MODULE_DESCRIPTION() macros To: Jeff Johnson , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Justin Ernst Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: <20240611-md-drivers-platform-x86-v1-1-d850e53619ee@quicinc.com> Content-Language: en-US From: Hans de Goede In-Reply-To: <20240611-md-drivers-platform-x86-v1-1-d850e53619ee@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, On 6/12/24 7:20 AM, Jeff Johnson wrote: > With ARCH=x86, make allmodconfig && make W=1 C=1 reports: > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/platform/x86/amilo-rfkill.o > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/platform/x86/uv_sysfs.o > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/platform/x86/ibm_rtl.o > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/platform/x86/xo1-rfkill.o > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/platform/x86/firmware_attributes_class.o > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/platform/x86/wireless-hotkey.o > > Add the missing invocations of the MODULE_DESCRIPTION() macro. > > Signed-off-by: Jeff Johnson Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. I will include this patch in my next fixes pull-req to Linus for the current kernel development cycle. Regards, Hans > --- > This is the last of the issues present (that I'm aware of) in > drivers/platform/x86 > --- > drivers/platform/x86/amilo-rfkill.c | 1 + > drivers/platform/x86/firmware_attributes_class.c | 1 + > drivers/platform/x86/ibm_rtl.c | 1 + > drivers/platform/x86/uv_sysfs.c | 1 + > drivers/platform/x86/wireless-hotkey.c | 1 + > drivers/platform/x86/xo1-rfkill.c | 1 + > 6 files changed, 6 insertions(+) > > diff --git a/drivers/platform/x86/amilo-rfkill.c b/drivers/platform/x86/amilo-rfkill.c > index efcf909786a5..2423dc91debb 100644 > --- a/drivers/platform/x86/amilo-rfkill.c > +++ b/drivers/platform/x86/amilo-rfkill.c > @@ -171,6 +171,7 @@ static void __exit amilo_rfkill_exit(void) > } > > MODULE_AUTHOR("Ben Hutchings "); > +MODULE_DESCRIPTION("Fujitsu-Siemens Amilo rfkill support"); > MODULE_LICENSE("GPL"); > MODULE_DEVICE_TABLE(dmi, amilo_rfkill_id_table); > > diff --git a/drivers/platform/x86/firmware_attributes_class.c b/drivers/platform/x86/firmware_attributes_class.c > index dd8240009565..182a07d8ae3d 100644 > --- a/drivers/platform/x86/firmware_attributes_class.c > +++ b/drivers/platform/x86/firmware_attributes_class.c > @@ -49,4 +49,5 @@ int fw_attributes_class_put(void) > EXPORT_SYMBOL_GPL(fw_attributes_class_put); > > MODULE_AUTHOR("Mark Pearson "); > +MODULE_DESCRIPTION("Firmware attributes class helper module"); > MODULE_LICENSE("GPL"); > diff --git a/drivers/platform/x86/ibm_rtl.c b/drivers/platform/x86/ibm_rtl.c > index 1d4bbae115f1..231b37909801 100644 > --- a/drivers/platform/x86/ibm_rtl.c > +++ b/drivers/platform/x86/ibm_rtl.c > @@ -29,6 +29,7 @@ static bool debug; > module_param(debug, bool, 0644); > MODULE_PARM_DESC(debug, "Show debug output"); > > +MODULE_DESCRIPTION("IBM Premium Real Time Mode (PRTM) driver"); > MODULE_LICENSE("GPL"); > MODULE_AUTHOR("Keith Mannthey "); > MODULE_AUTHOR("Vernon Mauery "); > diff --git a/drivers/platform/x86/uv_sysfs.c b/drivers/platform/x86/uv_sysfs.c > index 37372d7cc54a..f6a0627f36db 100644 > --- a/drivers/platform/x86/uv_sysfs.c > +++ b/drivers/platform/x86/uv_sysfs.c > @@ -929,4 +929,5 @@ module_init(uv_sysfs_init); > module_exit(uv_sysfs_exit); > > MODULE_AUTHOR("Hewlett Packard Enterprise"); > +MODULE_DESCRIPTION("Sysfs structure for HPE UV systems"); > MODULE_LICENSE("GPL"); > diff --git a/drivers/platform/x86/wireless-hotkey.c b/drivers/platform/x86/wireless-hotkey.c > index e95cdbbfb708..459e20f7e161 100644 > --- a/drivers/platform/x86/wireless-hotkey.c > +++ b/drivers/platform/x86/wireless-hotkey.c > @@ -14,6 +14,7 @@ > #include > #include > > +MODULE_DESCRIPTION("Airplane mode button for AMD, HP & Xiaomi laptops"); > MODULE_LICENSE("GPL"); > MODULE_AUTHOR("Alex Hung"); > MODULE_ALIAS("acpi*:HPQ6001:*"); > diff --git a/drivers/platform/x86/xo1-rfkill.c b/drivers/platform/x86/xo1-rfkill.c > index e64d5646b4c7..5fe68296501c 100644 > --- a/drivers/platform/x86/xo1-rfkill.c > +++ b/drivers/platform/x86/xo1-rfkill.c > @@ -74,5 +74,6 @@ static struct platform_driver xo1_rfkill_driver = { > module_platform_driver(xo1_rfkill_driver); > > MODULE_AUTHOR("Daniel Drake "); > +MODULE_DESCRIPTION("OLPC XO-1 software RF kill switch"); > MODULE_LICENSE("GPL"); > MODULE_ALIAS("platform:xo1-rfkill"); > > --- > base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670 > change-id: 20240611-md-drivers-platform-x86-a3a06234d33c >