From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57B6E2475C0 for ; Wed, 15 Jan 2025 12:02:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736942555; cv=none; b=lqnaNQiTWUjmNaKA6Sp10hY3y7Wqq5AM9+5AIKXsGWC0qG8pCwjWERIxJPkTWKXegzX5vegfwbYO71hp0UB/wr+8osjbjzFFaGHobuj4JKQ4t1xiCXT6gLzUbmE+xljpENMFIR+tkKOfACv+43Cd+yiYqQc7VkFwQ31zlpXDTEc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736942555; c=relaxed/simple; bh=GxiMUN5sqtriveaI/HLFwTpRRwlH2UsAEbUeMqe17Qw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MtJ6AJM3zrJua//Ks1hOqvYBO7Jn7wXUt08yVzfA+uSDAdhKOVCWCdjj7ufbuKsc9uWP/49OcwzRmdArCScu3MSEX4KHHME0/VoTpgBd/Px2QmmOjOUb4wWkQ6nPaxQsgcmWjJ58Lrq7s/Aeyuav2StA0dslmgS9gYNjNpIg84Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Znz9P2lr; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Znz9P2lr" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-3862a921123so3843014f8f.3 for ; Wed, 15 Jan 2025 04:02:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1736942552; x=1737547352; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=J09817AefuwhTALG6OGHGhgUnuZ4yA9WXWtiMWd3gZ4=; b=Znz9P2lrJglPk3coNHRK0cjlTWtCC43MgS+5q2HzRml0qL9kN81Li9nCKchc4RWK6P 9YFjRWa7ppEjv8dyvqe0EQNL12SVVVOS+1JyO/Kkpqut0t1o2ckANKOidtCoTkuCh7R4 Ct0EQzixYjscKyG/ZpqMJbNYwU2wp7ajE+YgO/5Zz7qOVaFaCEF0VsfmPg9AL7OF35im EABtqqArw/vHjh6xSTA7pmzkH3MVQXHiagNeoBqcHXfE11UpbykR0AFh4HR8kQkto7TF XJ1ZVP1bgP6nN/CPkNZavBwu97BKKtHJGOG4jOX73PPJhhnVmvlPi4IdJEXOv1oBbkhl P/CQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736942552; x=1737547352; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=J09817AefuwhTALG6OGHGhgUnuZ4yA9WXWtiMWd3gZ4=; b=nxLHSm6qlOJQXw7cwZHMUpr8+V3xibEd816Bzw6Mbzb7vVweTYd3Vi6adwjzgAj9VJ XkJpSLbKCrafMaEVY3VxBJzLzIFIuOGYXvkxfdxJ1KA3bijKKqIMiY4+FqDMOg8/gFBg jnc1Oz/LqEQLU/3Hat19s+F75+TJhZXTarwN5wDy5oG3GIx1htclDZAd3H0GvvGr6a4G QGEEXzqJGwJvEb6aw4ah4rXtS6LJUyS7dkUAyHV3SJ5dm0+38A95zhXf/eu6hTsB83WJ wBYLzktjf/y1esc0Cx4agYOOkofo1CXZFTvUIiSSakAoDylGQdZycVVT7LTJ2M2YACX9 aOmQ== X-Forwarded-Encrypted: i=1; AJvYcCVzyJnxnMtIps1PvLi97ckaM4oH4IU9gu0yYcDdpPFs5smpjCDrfO+/lczE8BtoIxCccPOZ9iptdXrYoFY=@vger.kernel.org X-Gm-Message-State: AOJu0Yz+dYeTOgPJLOaAH/DaQgef6kUh1j7FZpLv4tIp9eBta24VaBZy sM8ua2q8reVJFrVMD7QVMkfQTznFtHHrHIeEYOaGVSWsvHRY5W/hFPmd1z9mwqw= X-Gm-Gg: ASbGncuMin9wXBn1B4OxF253xX9R4fE1ALil0sRfJbUMFG70ia/YLKet6v0RbjTPNIi 1lH/obmQS9smqA03QCSKD+KSnG7KUBeNLHaRwB8v5OGH9zcpJAuo6WSpMCLEB6R5hTYQbFxjdm1 Plo0SggfTmFyASI86Wv6n1raaFhvPG4m++iczxXW2Hmz4GeMAXtM4NdqThPx+L2mVqXUbWkRSdX /aIdniitAURJZY3/hvJex+kaJfEwO5QQ11odq7x+UcX12r9KVpSyiuFEQHpNWkjB42o7A== X-Google-Smtp-Source: AGHT+IFfKyGn52ipjdfPZD6RVd7v4EFf3NGE8QU70ELIZjBpZX1RbqBIB9xbQUWlnKSlaXcoGcGZmA== X-Received: by 2002:a5d:5847:0:b0:38b:e32a:10a6 with SMTP id ffacd0b85a97d-38be32a12d5mr6050542f8f.41.1736942552589; Wed, 15 Jan 2025 04:02:32 -0800 (PST) Received: from [192.168.0.35] ([176.61.106.227]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a8e38c1d6sm17718135f8f.50.2025.01.15.04.02.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Jan 2025 04:02:32 -0800 (PST) Message-ID: <8322416c-5762-4b64-80aa-7ef1b0b0287c@linaro.org> Date: Wed, 15 Jan 2025 12:02:31 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/3] venus: pm_helpers: Use dev_pm_genpd_set_hwmode to switch GDSC mode on V4 To: Renjiang Han , Bjorn Andersson , Michael Turquette , Stephen Boyd , Stanimir Varbanov , Vikash Garodia , Mauro Carvalho Chehab Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org References: <20250115-switch_gdsc_mode-v3-0-9a24d2fd724c@quicinc.com> <20250115-switch_gdsc_mode-v3-2-9a24d2fd724c@quicinc.com> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <20250115-switch_gdsc_mode-v3-2-9a24d2fd724c@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 15/01/2025 09:30, Renjiang Han wrote: > The POWER_CONTROL register addresses are not constant and can vary across > the variants. Also as per the HW recommendation, the GDSC mode switching > needs to be controlled from respective GDSC register and this is a uniform > approach across all the targets. Hence use dev_pm_genpd_set_hwmode() API > which controls GDSC mode switching using its respective GDSC register. This paragraph is difficult to read and understand. Try something a bit more like "Use dev_pm_genpd_set_hwmode() API to control GDSC mode switching. Do that because of reason x, y z" "We are making this change because of reason a, b, c" Basically just try to state the facts as clearly and concisely as possible. --- bod