From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1410939C63E for ; Sun, 19 Jul 2026 14:40:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784472017; cv=none; b=kWM0OyvX6kB5lhvHNAQe5F4tFxiVXYNS1Rt3LZ/UtuqQzbTtJfN7Sqz5xxEURjP5El3DRo2S5OlpRTMQ/cMgX9SAIjZaVvfBCckNaUM8szWQdg+H/CEzRHeTydhQ+XvE8T2clFROfr9xu9UErFUtqvW+JzrUQCQ7FtqIhj0KxQM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784472017; c=relaxed/simple; bh=o83V6SLRt8Fq7N3WbKtRn35VeS0QJ+5A3Nl59jwaIsQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=R5qU+aTinTilL3PqVYb0ura7EUMstjSVhToSwIEJiAKOC337ElIxysr2LCYRAU2f7i6/DQlPD4TUmwgwngub4Eb5z1y31RcJLgXZXqmRaW41xl+rTucjdf2kBDcvPUPs6qo27KGe/E9f41A96BKh41a4M7b3Q/JPoc5ZKxngef0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BFcsoqjz; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BFcsoqjz" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2cf27856f9cso35594785ad.2 for ; Sun, 19 Jul 2026 07:40:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784472015; x=1785076815; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:sender:from:to:cc :subject:date:message-id:reply-to:content-type; bh=yEiZC5cPRs6be8u/O3W+95SkWQ3GKtANtruKW/XJSGE=; b=BFcsoqjzuDGln/VtfytvDyM2HxsVHZJ9JCpgzzRntTT6KHtTfema9gy3bwqotIXdgF w2D2kXNVqyGec5D+bkOZI1HU5BJwPytDr+m+EUYz1YKFCIfG/LIBnpVcyPdMdBChuS7q oryl5pBoE5EzgU6xk7Ajj9yJU36aNozMNOMbugDDFwTTe6oXdalzAUZoAdqmcFES+uFR HFhMLWbeFFUC5ZsU4+fuBVDt+8rqdyX/E1HXLVjY1Mt+MGbL2EzugRsuuVTNNqb2AQ71 ls+siHqCv81PE5Anvkl880eyoW3qU3zbObQn7Hv5VWAYwAwybjrVP2izAQyyTGyIa9ly OZEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784472015; x=1785076815; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:sender:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=yEiZC5cPRs6be8u/O3W+95SkWQ3GKtANtruKW/XJSGE=; b=BGbZIDfwjztuw8/vpQWSWwy/urMWsxt9c7fdmDQqNQ8+iNcGnc5fXhWGcG4CXBeuNF 3EsIe/B4Hs+JrppMwJ/6i6YiIfB5afswVR/7xvW/BslQKiu+ttFGXU191JShdhSwKBC0 wHBXConULGCIYwq77YVYflj3ymxhYn+1HdV0gkb5NSG8RtVfjg11DxpB980kOJ1nl3Xa FWHhNKmo6mwNZC/g/h2bh/Aq7SeCHPtp3tqsuVveiJObr4SPGizUiYkyFlZDuZjrXEtF ItCG7WGtIT5uDDK6ZHCnUlS9cJ4/IblAWLP4hC7IQWvjT18UvFfy9+AB9GtrIab72sAn 3Fug== X-Forwarded-Encrypted: i=1; AHgh+RpOZVSIW9EzgZC/OjLQnCVX1VUObQ/OKNpLH4qYEktXKX26CBBLKYRUCaDwK8/UJyRjR7662aIVK7vvEBc=@vger.kernel.org X-Gm-Message-State: AOJu0YwyWJNKMOW2jLtyKsvZezE8WgYSkw1YX5zkS1dvY7yIUMuCqHi7 6wu+mQIH2Hli7y2oOac/XpliwPLWcT8E2QmjR5QRlMtPCj800Ty5Z8dt X-Gm-Gg: AfdE7cmX3RofVHJl54mAeVhZmnlhYhQhz65wFli/eIQnvbDcwAOhH2iKrHXE5srbpDW HN1/GNjBrrIAmKP1MlFvkMzhKybmzQzJE4VfI9M5YjcAp2sVPzUHomOpaFRQAqRZf9A93I10DQm 0RjRYcd+KKeZM7MPwStMLkWUdfTgHn0EhBSSdqslQBeM+pwPznxA3Lib38Bs9C3Fv6pMlKFyLkY OefAn9ZvvXY3+YbfnFKR0mvrD6ykIdXei/9gXGCY13mhhfdh/1qn78RHXubB3nMFI8V82SCrkOu LMNpO9iDhBkxSP7zJ6MEXhrmLA5VInBaNwJ4RtEmf8RYW/DIB572xxzkxIW6hycCg1Ovhk7QwJJ wbskawaD9nsKQYtekGQkG4I+lLUTxoZWJ4EDfE9o/JKTvdW9h33sVnnQD8OGHSar0lUDmOCBU2k 551hyU/4ibCAOq4ts= X-Received: by 2002:a17:902:f708:b0:2cf:477f:57cc with SMTP id d9443c01a7336-2cf477f5cc6mr73332755ad.4.1784472015429; Sun, 19 Jul 2026 07:40:15 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cf347119dfsm40940175ad.56.2026.07.19.07.40.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Jul 2026 07:40:14 -0700 (PDT) Sender: Guenter Roeck Date: Sun, 19 Jul 2026 07:40:13 -0700 From: Guenter Roeck To: Shih-Yuan Lee Cc: Henrik Rydberg , Armin Wolf , linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 3/3] hwmon: (applesmc) Convert to hwmon_device_register_with_info Message-ID: <8323060d-afeb-48fd-a0be-892fdef8a844@roeck-us.net> References: <20260710123236.10508-1-fourdollars@debian.org> <20260711093323.14529-1-fourdollars@debian.org> <20260711093323.14529-4-fourdollars@debian.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260711093323.14529-4-fourdollars@debian.org> On Sat, Jul 11, 2026 at 05:33:23PM +0800, Shih-Yuan Lee wrote: > The legacy hwmon_device_register() function is deprecated and triggers > warnings in dmesg. Convert the driver to the modern > hwmon_device_register_with_info() API. > > This conversion does the following: > - Dynamically allocates standard HWMON temp, fan, and pwm channels. > - Configures HWMON ops callbacks (.is_visible, .read, .read_string, .write). > - Standardizes attribute naming to match the HWMON ABI: > - fanX_output -> fanX_target (HWMON_F_TARGET) > - fanX_manual -> pwmX_enable (HWMON_PWM_ENABLE) > - Dynamically registers non-standard fanX_safe attributes under the HWMON > class directory via extra_groups. > - Cleans up legacy sysfs nodes, groups, and unused show/store static functions > to avoid unused symbol compiler warnings. > - Avoids recursive mutex deadlocks when writing to pwmX_enable by locklessly > resolving the entry and invoking the underlying raw SMC read/write calls. > - Avoids UAF race condition on module exit by using unmanaged registration and > explicitly calling hwmon_device_unregister() as the first step of applesmc_exit(), > guaranteeing that HWMON nodes are destroyed before static structures are freed. > > Signed-off-by: Shih-Yuan Lee Applied. Thanks, Guenter