From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34342CDB474 for ; Mon, 16 Oct 2023 17:19:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232700AbjJPRTt (ORCPT ); Mon, 16 Oct 2023 13:19:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229666AbjJPRTr (ORCPT ); Mon, 16 Oct 2023 13:19:47 -0400 Received: from mail-io1-xd2a.google.com (mail-io1-xd2a.google.com [IPv6:2607:f8b0:4864:20::d2a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0899B9F for ; Mon, 16 Oct 2023 10:19:44 -0700 (PDT) Received: by mail-io1-xd2a.google.com with SMTP id ca18e2360f4ac-7a24c86aae3so57918439f.0 for ; Mon, 16 Oct 2023 10:19:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1697476783; x=1698081583; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=QgUa+mKvmsmGKgSXxgXS6XuuY5vQ/8sgjMNQWn66qJU=; b=ZAgpocJEXXYkm5caiZ4CN5fHG0ZSWLSXEMEztK+uOTyjLaleHYlZv7xdtNvdSCwCg2 iMKfbhtopRFsabF0LDQ3GFWRBNaV9YtqfI2g1olPMxEWp7WcmkdE4iGYlDzFYRJ0zqwL APMZM31DZMdAKAt6KFELS5NVdlvfsWWftF75E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697476783; x=1698081583; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QgUa+mKvmsmGKgSXxgXS6XuuY5vQ/8sgjMNQWn66qJU=; b=bJ4m71Git9nEaYNrlncM4NNICwqehtx6gnWVv0qQ1m61055yFlbSWOFCm7f1XwmsIS cJ7/CuLta6TErZ4/AcJWnj7CPk3K1NbpqGYPz40o/8wuG4ssC9E8DuAE5LddlzUMyswp krvjNMIObHjg96g51u6QUsv4WdlYYwSoF+buyHyLUY9KGq6H4jPY+jxo+kN1+j25GGAC w+EX6XV3TZWfx5Hosxo6lDB0iSoMimcD/tB9ijO50TCowHH+oaeRa7ViORz1S0ChTpsy J+sp8ZEoSyaN+1k/Cs5O9bF8/1Jd4IHha06CK1t/BRPpbF636/sEKfClxEcqwY4dXM6+ qAXg== X-Gm-Message-State: AOJu0YyzU1wmngiamFklnUlgb0O1bQU4wwdG0hPfqeGm08lCngmr4zPw PyxwT6TFilpNl6H1uQs4NFCVp/9UqDOD1AIS2ts= X-Google-Smtp-Source: AGHT+IH01KOJB7womZ3bhd3IAY5anUtTZrEzFuuJ1qqL/RrjkhKbEMdf0j89Pwsvv9woipq/08kmpQ== X-Received: by 2002:a92:cac7:0:b0:351:54db:c1bc with SMTP id m7-20020a92cac7000000b0035154dbc1bcmr98759ilq.0.1697476783349; Mon, 16 Oct 2023 10:19:43 -0700 (PDT) Received: from [192.168.1.128] ([38.15.45.1]) by smtp.gmail.com with ESMTPSA id r2-20020a92c502000000b00350b7a9f0c1sm3498858ilg.62.2023.10.16.10.19.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Oct 2023 10:19:42 -0700 (PDT) Message-ID: <8328df87-67d0-43a8-aa6a-4b9587089e3a@linuxfoundation.org> Date: Mon, 16 Oct 2023 11:19:41 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 -next] usb/usbip: fix wrong data added to platform device Content-Language: en-US To: Andy Shevchenko , Hongren Zheng Cc: Shuah Khan , Greg Kroah-Hartman , Valentina Manea , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, sfr@canb.auug.org.au, Shuah Khan References: From: Shuah Khan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/16/23 01:40, Andy Shevchenko wrote: > On Sat, Oct 14, 2023 at 03:46:04PM +0800, Hongren Zheng wrote: >> .data of platform_device_info will be copied into .platform_data of >> struct device via platform_device_add_data. > > platform_device_add_data() > >> However, vhcis[i] contains a spinlock, is dynamically allocated and >> used by other code, so it is not meant to be copied. The workaround >> was to use void *vhci as an agent, but it was removed in the commit >> suggested below. >> >> This patch adds back the workaround and changes the way of using >> platform_data accordingly. > > Good learning to me, thank you for the fix! > Reviewed-by: Andy Shevchenko > Thank you both. Acked-by: Shuah Khan thanks, -- Shuah