From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932997AbcH3Rr3 (ORCPT ); Tue, 30 Aug 2016 13:47:29 -0400 Received: from mail-pa0-f65.google.com ([209.85.220.65]:34032 "EHLO mail-pa0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758872AbcH3RrZ (ORCPT ); Tue, 30 Aug 2016 13:47:25 -0400 Date: Tue, 30 Aug 2016 23:17:21 +0530 From: Bhaktipriya Shridhar To: David Howells , Mark Fasheh , Joel Becker , Michal Hocko , Johannes Weiner , Vladimir Davydov , "Kirill A. Shutemov" , "David S. Miller" , Eric Dumazet , Andrew Morton , Joseph Qi , "Norton.Zhu" , Jun Piao , xuejiufei Cc: ocfs2-devel@oss.oracle.com, linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org, Tejun Heo Subject: [PATCH 9/9] fs/nfsd/nfs4callback: Remove deprecated create_singlethread_workqueue Message-ID: <832a8e0663b86e86c65dd3c49e049b8d43eff4cd.1472578959.git.bhaktipriya96@gmail.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The workqueue "callback_wq" queues a single work item &cb->cb_work per nfsd4_callback instance and thus, it doesn't require execution ordering. Hence, alloc_workqueue has been used to replace the deprecated create_singlethread_workqueue instance. The WQ_MEM_RECLAIM flag has not been set since this is an in-kernel nfs server and isn't involved in memory reclaim operations on the local host. Since there are fixed number of work items, explicit concurrency limit is unnecessary here. Signed-off-by: Bhaktipriya Shridhar --- fs/nfsd/nfs4callback.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/nfsd/nfs4callback.c b/fs/nfsd/nfs4callback.c index 7389cb1..a6611c6 100644 --- a/fs/nfsd/nfs4callback.c +++ b/fs/nfsd/nfs4callback.c @@ -1021,7 +1021,7 @@ static const struct rpc_call_ops nfsd4_cb_ops = { int nfsd4_create_callback_queue(void) { - callback_wq = create_singlethread_workqueue("nfsd4_callbacks"); + callback_wq = alloc_workqueue("nfsd4_callbacks", 0, 0); if (!callback_wq) return -ENOMEM; return 0; -- 2.1.4