From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E9342528F0 for ; Wed, 9 Apr 2025 09:25:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744190721; cv=none; b=sWajRix0B0Rcy9EUJwPSdczB9Ky/A0SYsSzdCX3eozw5CdH3wn/3gXeDwBgq+R7x5xLF2C4KTzdYrHG/MclhSlTkOxzLcY4mnlBmpeS/O2D8Qf97p6oUSZ1wkm/uADC2KxyClOEVmk3UQnTv0Tr10YbIdcxzTY7Iyi7omt99YHM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744190721; c=relaxed/simple; bh=ENCAoRn5BfFq2DRPgPGEYfkfSWvKxwZ0dR5JIt637qA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Ilbq1KwJawlpwA9Vj1P18coRZEGNd52qL6rUJNuddGm5+gLx2OiQW2ttufezZDx4kGVpsSqZ42OC2rfYj9XG08dkRXwU0cupzhJmDcFpWQjn0wQfTy+XVLJKGarH1iKrA7CMYnR9zMKfa8zAD4qFVsYQU1qc69kk5vz98HwrZ2g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=IxeHFLHW; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="IxeHFLHW" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744190718; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=iOxMqARnhIE739NzdQalx+rcbMgzJwzjVaS+45XQCpc=; b=IxeHFLHWqWu/6APGv22rTDsoiCQ2VLdO/J+36gyewFxgRYxHsBN1+P/kgRKbmRcPcDLMdJ bLOEpVmusur+MKJLAFESL5vjoIt3qMvSW0xYDVUAXY9OE5DHM0FLJCGzmiqrjI8gUSANVt /aE+HQHlj6RZk841kSKY/HYv/1qXQIQ= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-637-ogPxGEaFNG-2uHgoILepNg-1; Wed, 09 Apr 2025 05:25:16 -0400 X-MC-Unique: ogPxGEaFNG-2uHgoILepNg-1 X-Mimecast-MFC-AGG-ID: ogPxGEaFNG-2uHgoILepNg_1744190715 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-43d0a037f97so39178725e9.2 for ; Wed, 09 Apr 2025 02:25:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744190715; x=1744795515; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=iOxMqARnhIE739NzdQalx+rcbMgzJwzjVaS+45XQCpc=; b=wESlxerbRJLP/CAmNCcbrKMluzLLNbb9hOQrRcRy8M2g92ZqlA7SwkcUP8jV7Uywer 7fPMT6ANQ/Mqf4XQ6cTErE5joy2x9nNGaodyMgzHIj9DB30f+gjoOMS2ylWkBZ5HD+UR k3m+ZSmgQHWlov3mtQvhz2g8CCbzsEsTCdj7SgjQihVPHfIoo8RU8PBgG/dDaXKyqHpJ gLVV1V2y9n5nBIuNIvOrLtCYl3rOvLaLjh8ZOjsvKJ/labMwUOKmBeEvAMUCIgyTlccD avvsRMMIt8X5wuV9qmufaero/LMbr/QCMg6Vne/g332SgaRAi4vpHAFjl8okOmvbwjyU iQHA== X-Forwarded-Encrypted: i=1; AJvYcCV4eDhYB1XrEVTw2ob+4cEEnWRohfHvADL8MVY5g20Wxq6qP+x2trSO8pz6V6gbD8c1oigEV+LDgo9wS1k=@vger.kernel.org X-Gm-Message-State: AOJu0Yw3SAXVIqTNh1Z26NKMFY4M3Oyq4WaMzBw8Ler+PT/Gk0j/Gu8b o3Azg4+1mWH9Of5ZBPgI+hMpMLXFLq1IbKFZcxooiNrY1fZMfNPpX9STNA0eoVGDKquMepvCiPL Y+EziaMURngQiXdic25cNOXPq5WRy4C2u3OVTnRukMeBafHuVpE7J7XIL6lwAOw== X-Gm-Gg: ASbGncsrOZI3G9jIBmjPWrQlXDyaTOSHxId28emJo8NmyqfnpVhIig1ziMy7Oema9y7 fKRLelqNZMkqjOnX5vLBQ39oYIS8tjx+8FVRnrs7sLbu3HA5F+VK3gQ9kqAuJzKuj6TJiA1r1cX NZqG0FioYLkjvm5IV6ohhY5qRDzeO8SPq1hHC9mpMfFbe2xdCyy3rYeh11RzUTMFCKqIqHNSXMh vfTNW1uQCq8JM5lDjQWLjTGiniWfS18v6cDAZR8yi3bgN2wWEU7aXX64h2ObaKInrDp8IqvmyG5 roCvIJ1M+xf33uFW01HSifo2ndPGDV75JQa0+2cqDBVHF3o4feYBwDJodkg83XmJB0H60RHvHgP TD5QOarlyJRfwARqx7bsgld/gEcFNpMbysw== X-Received: by 2002:a05:600c:5009:b0:43d:7588:667b with SMTP id 5b1f17b1804b1-43f1fdef66amr21772535e9.10.1744190715408; Wed, 09 Apr 2025 02:25:15 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE+W5DAxJzTMiI3e984CnLCs8Esm5MPjNOzbxUZrKyvuC4DNY17Iah9nmK3loc5kgXJE4OnRQ== X-Received: by 2002:a05:600c:5009:b0:43d:7588:667b with SMTP id 5b1f17b1804b1-43f1fdef66amr21772195e9.10.1744190715044; Wed, 09 Apr 2025 02:25:15 -0700 (PDT) Received: from ?IPV6:2003:cb:c70d:8400:ed9b:a3a:88e5:c6a? (p200300cbc70d8400ed9b0a3a88e50c6a.dip0.t-ipconnect.de. [2003:cb:c70d:8400:ed9b:a3a:88e5:c6a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43f2338d6ebsm10385655e9.2.2025.04.09.02.25.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Apr 2025 02:25:14 -0700 (PDT) Message-ID: <8335de39-024f-4be5-a69f-42949dbf7b33@redhat.com> Date: Wed, 9 Apr 2025 11:25:13 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] x86/mm: stop prefetching the mmap semaphore on page faults To: Mateusz Guzik , dave.hansen@linux.intel.com Cc: linux-mm@kvack.org, x86@kernel.org, linux-kernel@vger.kernel.org References: <20250401143520.1113572-1-mjguzik@gmail.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250401143520.1113572-1-mjguzik@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 01.04.25 16:35, Mateusz Guzik wrote: > The prefetchw dates back decades and the fundamental notion of doing > something like this on a lock is shady. > > Moreover, for few years now in the fast path faults are handled with RCU > + per-vma locking, hopefully not even looking at the lock to begin with. > > As such just remove it. > > I did not see a point benchmarking this. Given that it is not expected > to be looked at by default justifies not doing the prefetch. > > Signed-off-by: Mateusz Guzik > --- > arch/x86/mm/fault.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/arch/x86/mm/fault.c b/arch/x86/mm/fault.c > index 296d294142c8..697432f63c59 100644 > --- a/arch/x86/mm/fault.c > +++ b/arch/x86/mm/fault.c > @@ -13,7 +13,6 @@ > #include /* kmmio_handler, ... */ > #include /* perf_sw_event */ > #include /* hstate_index_to_shift */ > -#include /* prefetchw */ > #include /* exception_enter(), ... */ > #include /* faulthandler_disabled() */ > #include /* efi_crash_gracefully_on_page_fault()*/ > @@ -1496,8 +1495,6 @@ DEFINE_IDTENTRY_RAW_ERRORCODE(exc_page_fault) > > address = cpu_feature_enabled(X86_FEATURE_FRED) ? fred_event_data(regs) : read_cr2(); > > - prefetchw(¤t->mm->mmap_lock); > - > /* > * KVM uses #PF vector to deliver 'page not present' events to guests > * (asynchronous page fault mechanism). The event happens when a I'm sure if this would have any value, we'd get notified about it :) Acked-by: David Hildenbrand -- Cheers, David / dhildenb