From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f99.google.com (mail-yx1-f99.google.com [74.125.224.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44BBE29992A for ; Wed, 5 Aug 2026 06:01:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.99 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785909684; cv=none; b=cGdm3OcjwQdu1/h6UKoeJJkkK121qgyxU9T6Ko8UCmnPtSllKwIJA1A+NMAZskfgHTmr/oPhVNtd3MTS03MibW8tszb35854QVyYaRaiLCD82a/1dTIXC+r0GdySopmJDTHOsdrh9MBxzpVDLdEkAs42ohsIwLNhkiAu50abif8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785909684; c=relaxed/simple; bh=l8bc8ytrxXEXmbcQbNdzYjz3gf5Gms+qc80pzWcDjNE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pFBM8l9MP0Xy0kPU8+LmEpD5wNYBL1YtpL0RkYEimNA4zQidqf0o6f0P//kNawddqFhDq65dkeRkbt9H20Kbbh19C+naC1s+kkL7lNiWd8KO81EVALVPK4AeTBA+cUik4dXGK4+vo5XrHremlSWiSa9tgAkhmDI8z4NjvMLb690= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=Kc99ZuNB; arc=none smtp.client-ip=74.125.224.99 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="Kc99ZuNB" Received: by mail-yx1-f99.google.com with SMTP id 956f58d0204a3-667bae10ba3so601761d50.2 for ; Tue, 04 Aug 2026 23:01:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785909682; x=1786514482; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:dkim-signature:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=zQ/9RIR1VNN0hukmG5NlD01qt4vqhJek43rGR5IpLsY=; b=RwY6WmHkt1ijLLGaOgFpcLi/HBPG7UVxgUzs0A3KEQvJOZAxIFrAcjyD2cHAHemUbT AsI9zoqCe67PK2uj8xLu5oD8cknobtqAhxE++YyF1u1DgPuPxaj0hIrtXSsBFMMwWn41 oxPj2jNesIwengHOTYrNicW3Opn16IFxqWJ1S4y2hJ/d7Z64KqQDTaIOpx60PhEiIahP 0EN/lfjT3cfF1/b0LsOh3lYZnApU31ibU9KKbMY1N7k0PA3eBxeVi0C2LfItJ4KHradC c9l/lADs6IyFt9b+340IHu6rM9yQez60TVXPhrwOzQB/sQd9VkpLtsR44DEhJuGEHiuw ygcg== X-Forwarded-Encrypted: i=1; AHgh+RrLDNZ9zwYCOX9NTDZx39VF7VmL0eZHrTQI+yMMRV3HCn8Kl99kWdYXA2UjSOLZWfa86CosZydKNOZQf4k=@vger.kernel.org X-Gm-Message-State: AOJu0Yw7uKu/6RnzQ2A1z63d17FtoHhYRak7WdBzeRVNvsV1DrCfqFV9 OX6MpaHZEGsKi+Sjl7R4tb+BKWn+Jmq+cpFy7ZBy7my/hN0A7DXItKhKu1sxZv6c7qpEZqZGHch /rsaxDYMs2s9Kicv+pl3t+AQKdOcrRyQxv/oTrxReIvdMyRSRqvb+ADxTLed+ffjUWWPcLvDd7k iuDokBjrrAiFZK6rr/7wcvueWu3xyTG4lUZvpo+itnjrCfph+PUyvcS+/NSdIO+aTqEfcso1Qmy oW27wXSKgTWYHoc0PCWoAHU0g== X-Gm-Gg: AR+sD1049KfdnvfcaYFwudAK5KxMH5rV9RK+vAiwyhD9GvgWWmEJrqogs/TRF6NSenr hYc3lqFratZ6gb3rL/FJbJsQsUKXl8HQpg2xR9dx1o252AGk5xlxokYur7yDDtBHjhWdpV7CZDw qwoQYyfTvAiS4WokfYsBiPLEAx0OIQtMrggfRcOhHUIQp6nyT/4mLh2syhNLEsettsHve5nSIai tEzcyzYRv88gYzn7XSYcftMCIT0Q2RNJylesbk4J9xtDue6mJUKcTApxK6RXp0bF7kgKMKgVefD otjRTqfRl6Y8wHojMs8niRC0KG8hNdc6FvCPWk4Lvgrc+aWtPIRECQx+VRpne0QPlPfEz08K4Zr hX8LjY4p2339BQeYXoD4jvNpKvT4cFTLFXeQ+AnPTZhn4NynJFHIFc8U8d0MKTXwP+CbVUTRHhZ pnUsMI7Ynf1yGjYYTz+s6pTnyUboR9eqy9wep4R2Y= X-Received: by 2002:a05:690e:4548:20b0:669:4843:f2e2 with SMTP id 956f58d0204a3-6699abfbad4mr1837918d50.36.1785909682096; Tue, 04 Aug 2026 23:01:22 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-22.dlp.protect.broadcom.com. [144.49.247.22]) by smtp-relay.gmail.com with ESMTPS id 956f58d0204a3-669915c9fa1sm196735d50.18.2026.08.04.23.01.21 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Aug 2026 23:01:22 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-51c20762d21so6309061cf.0 for ; Tue, 04 Aug 2026 23:01:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1785909681; x=1786514481; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=zQ/9RIR1VNN0hukmG5NlD01qt4vqhJek43rGR5IpLsY=; b=Kc99ZuNBjYkQ7CIJYkqTRRK0G+Yj2N1T/O1uWkAUO9HLyDOX7PGXo9d+uGS6FDurU9 gpb0QbkznswBnc7rKxNXdfTaqkHE/l7uJDRKK5KmOV72huhkKU3ILhOckxrXmwcfxU2T vnxaUDltp8sb5uekf+45pNqQMSIS7cm98eDWU= X-Forwarded-Encrypted: i=1; AHgh+RrFcidr++Z7w5I9xyibeDTUc9J8ibVsgEhLq1ml0wzXr8h983KQ+/sTQfVZT/tOTDmgq4uqAmi/KmPvxnU=@vger.kernel.org X-Received: by 2002:a05:622a:355:b0:519:8998:661b with SMTP id d75a77b69052e-52ce60c07c6mr43080031cf.20.1785909681035; Tue, 04 Aug 2026 23:01:21 -0700 (PDT) X-Received: by 2002:a05:622a:355:b0:519:8998:661b with SMTP id d75a77b69052e-52ce60c07c6mr43075121cf.20.1785909674142; Tue, 04 Aug 2026 23:01:14 -0700 (PDT) Received: from [192.168.178.26] (f215227.upc-f.chello.nl. [80.56.215.227]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-9087ff9d720sm18740276d6.4.2026.08.04.23.01.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Aug 2026 23:01:13 -0700 (PDT) Message-ID: <8338ad7e-8707-473c-b677-be3594f7a7f5@broadcom.com> Date: Wed, 5 Aug 2026 08:01:11 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] wifi: brcmfmac: remove extra blank lines in msgbuf.c To: Can Peng , johannes@sipsolutions.net Cc: linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-kernel@vger.kernel.org References: <20260803080912.553948-1-pengcan@kylinos.cn> Content-Language: en-US From: Arend van Spriel In-Reply-To: <20260803080912.553948-1-pengcan@kylinos.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e On 03/08/2026 10:09, Can Peng wrote: > msgbuf.c uses two blank lines in many places, including between > top-level declarations and functions. > > Keep a single blank line instead to match common kernel coding style. Yeah. It has been like that since this source file was added so maybe just leave it like it is and forget I ever mentioned it. Regards, Arend > Reviewed-by: johannes@sipsolutions.net > Reviewed-by: arend.vanspriel@broadcom.com > Signed-off-by: Can Peng