From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=198.175.65.15 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794376933; b=zgywrERPFnlSwQJ/I49oCOEMB2zjYcsjRHBtzIMrl4NwumFBdXZymG7JKTosEuL5l1+2 fzXR1M3VyPfASTPxNSbwaB9+XqJh6yeLdf5iGwilWMP51JJsJttDibaAK7p24dPGL/z2l CN7C3L6zZWRpSMs3+Zv6d5oA7y9CN/wIq5sq2RSDozcBKbR3mVpwTTqvdC34SdVIxnABi vr3ejAbbbyXkWuOVZ3syIJVSD39lE8SG9JP0sxCMsYxUSK/nAF79dmclBJBUDUhVDAie3 dXIgXEgsh1ebcZRHnHCgdtMwnyMuQRL+QchO31E+CVHtbBPfsYbR3HcXdQDnw4uRqww== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794376933; h=DMARC-Filter:DKIM-Signature:X-CSE-ConnectionGUID:X-CSE-MsgGUID: X-IronPort-AV:X-IronPort-AV:Received:X-CSE-ConnectionGUID: X-CSE-MsgGUID:X-ExtLoop1:X-IronPort-AV:Received:Message-ID:Date: MIME-Version:User-Agent:Subject:To:Cc:References:Content-Language: From:In-Reply-To:Content-Type:Content-Transfer-Encoding; bh=EBXimyKc1it/KxK5bNdiXlKjJH276vdebWnV1cX0e3Y=; b=L+xiWfPssk5KNMJqy/adk2FPFgw41EQTx2lH33myxwG5fioJ0N38gXdi1emjsXmAyD1G 3IG0jeP/mnAaj6g+xGc77F1o10lHjTL1+QqiflueEIq5pezQgTcpN9aZsgY9UIJi9UIoD gD/QXnth7qVNvH38mI6/wWu/udpaIDFRP8EFT2VHFqORKbHBwNFQOCFBpExZhSHZGroal d0ilg95YDy9jelqS2jAots7QFxt1LMOGpe9z+SDiQAp0UQ/zcjRZbfVbQeU5hzGXRpFRT 5V0xo74MsZhtGqvQPWzxAq8UNWOPlLhADlNZfaxzYeZaFpzk/hhTrezDWmWacL6U+XQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=iJnzOVHI; arc=none smtp.remote-ip=198.175.65.15 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62AF6606AC6D; Wed, 11 Nov 2026 06:02:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 62AF6606AC6D Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=iJnzOVHI DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1794376934; x=1825912934; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=2/6PoKpF2TFtdqVTOCp6q1iPfEWPxp8sOLejEI8tLVk=; b=iJnzOVHI0ihLBn1+tQaZwOe3LnFUrvnZ/OGxmi3a7oUfzRjlsSlvrW4U 3QkqSyx0cUSr43mZV06TpALmrSOB5GuldBN7rjdnN9o4/zX4owzL+md4u 1wkCU1iumRJ/fKu1auHKOOIvHdUXLohgMh2gmB8UlvD3/vk44vSNLjSP8 Ge1k3ItNvRc+WkXXWjbdVwrqtG4e4fTPD6a99GrD9tbMMk+CHS0qdOZXx q0Juh/Jn7srHVTXa/TaljRjKn2h7ZmJufSTBoXMkZBZ30CELkBHS7YJSY m/eNEZNhurIYk0zn2dRLmRVMo9QD5eIGNixz+wbiUpFjZyO8YjODnznBv g==; X-CSE-ConnectionGUID: YxYpFWS5QICiN1flZSygDA== X-CSE-MsgGUID: OmMu3PIFS1e8r1msIY9ODA== X-IronPort-AV: E=McAfee;i="6800,10657,11962"; a="3147440" X-IronPort-AV: E=Sophos;i="6.27,207,1787036400"; d="scan'208";a="3147440" Received: from fmviesa012.fm.intel.com ([10.60.135.152]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2026 22:02:13 -0800 X-CSE-ConnectionGUID: tsvKuNOJQsmrUuC69pHrbg== X-CSE-MsgGUID: iwByyT5kTcuDOj/gnAcyBQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,207,1787036400"; d="scan'208";a="10076430" Received: from xiaoyaol-hp-g830.ccr.corp.intel.com (HELO [10.124.240.71]) ([10.124.240.71]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2026 22:02:05 -0800 Message-ID: <833af78b-60b9-4031-88e0-555363f8dd0b@intel.com> Date: Wed, 11 Nov 2026 14:02:03 +0800 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v16 12/20] KVM: selftests: Call KVM_TDX_INIT_VCPU when creating a new TDX vcpu To: Lisa Wang , Andrew Jones , Ackerley Tng , Binbin Wu , Chao Gao , Chenyi Qiang , Dave Hansen , Erdem Aktas , Ira Weiny , Isaku Yamahata , Kiryl Shutsemau , linux-kselftest@vger.kernel.org, Paolo Bonzini , "Pratik R. Sampat" , Reinette Chatre , Rick Edgecombe , Roger Wang , Ryan Afranji , Sagi Shahar , Sean Christopherson , Shuah Khan , Oliver Upton Cc: Jeremiah McReynolds , kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org, x86@kernel.org References: <20261105-tdx-selftests-v16-0-2024e8fa517a@google.com> <20261105-tdx-selftests-v16-12-2024e8fa517a@google.com> Content-Language: en-US From: Xiaoyao Li In-Reply-To: <20261105-tdx-selftests-v16-12-2024e8fa517a@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/6/2026 7:46 AM, Lisa Wang wrote: > From: Sagi Shahar > > TDX VMs need to issue the KVM_TDX_INIT_VCPU ioctl for each vcpu after > vcpu creation. > > KVM_TDX_INIT_VCPU has a strict prerequisite for the CPUID state. To > satisfy this requirement, call KVM_TDX_GET_CPUID and KVM_SET_CPUID2 to > pull the CPUID configuration from the TDCS and commit it into KVM, > allowing KVM_TDX_INIT_VCPU to succeed. > > Additionally, unlike tdx_vm_ioctl(), tdx_vcpu_ioctl() doesn't check > hw_error. KVM's vCPU-scoped TDX ioctl handlers don't propagate SEAMCALL > errors into hw_error: the error is handled in the kernel and only an > errno is returned. Checking the ioctl's return value and errno is > therefore sufficient. > > Signed-off-by: Sagi Shahar > Signed-off-by: Lisa Wang Reviewed-by: Xiaoyao > --- > .../selftests/kvm/include/x86/tdx/tdx_util.h | 22 ++++++++++++++++++ > tools/testing/selftests/kvm/lib/x86/processor.c | 27 +++++++++++++++------- > tools/testing/selftests/kvm/lib/x86/tdx/tdx_util.c | 11 +++++++++ > 3 files changed, 52 insertions(+), 8 deletions(-) > > diff --git a/tools/testing/selftests/kvm/include/x86/tdx/tdx_util.h b/tools/testing/selftests/kvm/include/x86/tdx/tdx_util.h > index 4330290d29e9..9d951f67b3b5 100644 > --- a/tools/testing/selftests/kvm/include/x86/tdx/tdx_util.h > +++ b/tools/testing/selftests/kvm/include/x86/tdx/tdx_util.h > @@ -46,9 +46,31 @@ static inline bool is_tdx_vm(struct kvm_vm *vm) > #cmd, ret, errno, strerror(errno), hw_error); \ > }) > > +#define __tdx_vcpu_ioctl(vcpu, cmd, _flags, arg) \ > +({ \ > + union { \ > + struct kvm_tdx_cmd c; \ > + unsigned long raw; \ > + } tdx_cmd = { .c = { \ > + .id = (cmd), \ > + .flags = (u32)(_flags), \ > + .data = (u64)(arg), \ > + } }; \ > + \ > + __vcpu_ioctl(vcpu, KVM_MEMORY_ENCRYPT_OP, &tdx_cmd.raw); \ > +}) > + > +#define tdx_vcpu_ioctl(vcpu, cmd, flags, arg) \ > +({ \ > + int ret = __tdx_vcpu_ioctl(vcpu, cmd, flags, arg); \ > + \ > + TEST_ASSERT(!ret, "%s failed, rc: %i errno: %i (%s)", \ Nit: tdx_vm_ioctl() uses %d for ret, while it uses %i for ret. It's better to make them consitent. I think we can fix it when applying.