From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2700E12D148 for ; Tue, 6 Feb 2024 11:19:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707218379; cv=none; b=bkKLuuVgo8zSm18czH5ePiqfK/GoKJNQBIBb4AelfN8jrcODR8zNUGfBlnqYw3jfBqSCo/SRv4zdrQBnAtkNgR0glnDT5r5s+Jk22EfnqNQCuYDmRw9eCAibEpmfRig42ia6SI4MvxnKpSzq4niRK4KcD0njQVnIdZZUrxlJmiE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707218379; c=relaxed/simple; bh=05SBW2RoA/3K/8YQO0Gnyq+1QSApd62hUKEdwlkTng4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=QDIppqfkrBs81u/ne8cwNvdXYv7GUeJI/f7O+JZA+3klMt52YhaB//ghEkIr84r+tz1exM2n2CR3u+Ly9Df2Oikp1Aj+ume3YDahtVAyXHuazvjytMJoQgGiC7ybMFP+JG0vwYAOnP/aqk7g5tlNwrB/fhbLZ29u3VwJa15W1P8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Emd4rPro; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Emd4rPro" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-40ef64d8955so6187635e9.3 for ; Tue, 06 Feb 2024 03:19:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707218375; x=1707823175; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=SNpmqyJxnfCh5R1BTBiPSOmEnJKZc/yAOGWwkfGZJqE=; b=Emd4rProubXt7OpdySUKtxvFneQRpgK8pYClmjoiX0SrtLvgEU1fZQGwFNSgakMFVH bkiWdFabaXMwiQQRbuQyvtAf1aTAWRgXmMOiGI26Qa2ICsO5hrnwt3Sa1gEAPqH4PlNg kMY0tBkp5AWzOhnx8D18AbE3pO+1rh8GHuycNYnZNlyEPvzDglcLKiKyedzBOp5ozp6b EzjEBC1aCn+2JuLbOPZw/E+LvSAInzlMxNaCyMFoUsb4FMpJ7F8CnlUvurlLJSpI0LHq tVc5zqV6sHC7gjUVgBpd+MxcRCNhHR6XTezuhnAz7l92imKvdiS6FJWZTjdamWISH6gJ QrrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707218375; x=1707823175; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SNpmqyJxnfCh5R1BTBiPSOmEnJKZc/yAOGWwkfGZJqE=; b=O9etBy+yfy+ERqtBcTWq7IXfHtD5oZaew1FvKLqlfAleIXOt28dO4BjUJE5sK/pZHo qCOW3rvVAM4jSCZclOmig8/zqqV16E6fg2Ll/AKnI1KZVQfiojXspP3CXg/cTOHtuT7/ OCp/wW0tYD83FptSLFvuz6MP1LUtMxHf1kCs2um7HCVuA2rsjzTRI8CBGW56J6ADzG6m wngUJRB+LYM/4yH2Z2pdsISmj8Ki9ZqRFbC2+NkG5gM2YzGQrHzVdf1AKU8Lp/64PWR5 qcQyvhAnkzm7l/H2ncvq7sG2W6vBHl17iNYWNUNVhMVSL3w5d/Wajo9SzdkysSuYuz+f 5qwg== X-Gm-Message-State: AOJu0YyLyM8mSt97XnFM0QSLYfCbs6eMu/yDaeXDPXocxVmXBAkA2Hxn MWJ9fvguXvjjHU564EnTbte4vv/xVwlMfTyw1k5wyaRzc1v7H3JJBWdR90zmJZs= X-Google-Smtp-Source: AGHT+IFjT1Ydvn2sv5V2yh8bL/NCBlUPaNM+YZt3iGNOjRt9GuolrvDTXzr6SS95u7t+EQ6TQH6hZQ== X-Received: by 2002:a05:600c:4f8e:b0:40e:7d8f:6b1a with SMTP id n14-20020a05600c4f8e00b0040e7d8f6b1amr2157121wmq.5.1707218375391; Tue, 06 Feb 2024 03:19:35 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCW/7bw9GxgRT6lT0V974NgAvuX45uGhaWOue3hlgthJXjdo3VAWQZgLcwNb6jALIecCLaC0fq9xwTGFqhKXzSbuDTvQyEV1EeUJWy0zx3P7lO5hTu95lsEMXM7rtuiF2G15dzlB9yGn5D1vhXDOGGOIZ48x2Riz6bKnH9A3yMizJgEa8TwZdd93VMTvJegYb7D0KmfLbhtF7OOT7DFQTSC38AQBvyJSEOn0xuqL9Gjxjkc2x/ot1ytZcQngaoMPe0yJuCl3r1feBesov+VLP9A0rEnAr5pOemWAlg1xXVPlvSU1x7emubM/KP8/uc3iQmKUBbLwdTLNIR6mGLdWGwKQjAy8aNMyCsdaGTNnKwNJy0mTOLrlqgX0OwgKMY62SxbonLwPiQ4hA6MTPS/+GNXy21R/yuI2OkeKbZOFmEOGAMbxwjdZLYXxjgWG7XTG1uzZfEDPRBQvoKINk/l+6Nnodj3BZML1WcHO18UJG6cSvD1qwVRNZR3Jhx1Xvor+pFdFq/+OyProJr4VMKPFrfv8ml2XCYO6TGiZzzcNG0XZa7O59LT4GIpOPHmeUKvDcoI= Received: from [192.168.0.107] ([79.115.63.202]) by smtp.gmail.com with ESMTPSA id j6-20020a05600c300600b0040fdd8f5e18sm1612761wmh.34.2024.02.06.03.19.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Feb 2024 03:19:34 -0800 (PST) Message-ID: <833b96e5-348f-4c5c-b157-c57c9a67e0f2@linaro.org> Date: Tue, 6 Feb 2024 11:19:33 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/4] spi: s3c64xx: add support for google,gs101-spi To: Mark Brown , Peter Griffin Cc: andi.shyti@kernel.org, semen.protsenko@linaro.org, krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, kernel-team@android.com, willmcvicker@google.com, robh+dt@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org References: <20240206085238.1208256-1-tudor.ambarus@linaro.org> <20240206085238.1208256-5-tudor.ambarus@linaro.org> Content-Language: en-US From: Tudor Ambarus In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/6/24 11:04, Mark Brown wrote: > On Tue, Feb 06, 2024 at 10:12:30AM +0000, Peter Griffin wrote: > >> The patch ordering seems a bit off with this series..I believe it should be >> 1) dt-bindings patch (docs first) >> 2) Add the use_32bit_io flag / functionality >> 3) gs101 support (this patch) that uses the use_32bit_io functionality > > That's the ordering the series has? There's a random cleanup patch > tacked on the front but that really ought to be separate anyway. I put the include patch first because I considered it a fix (driver is using u32) and because I need types.h in patch 3/4. Fixes first, then bindings, then driver. Was I wrong?