From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757004AbdEUUOd (ORCPT ); Sun, 21 May 2017 16:14:33 -0400 Received: from mout.web.de ([217.72.192.78]:49957 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756902AbdEUUOb (ORCPT ); Sun, 21 May 2017 16:14:31 -0400 Subject: [PATCH 1/5] atm: Improve a size determination in four functions From: SF Markus Elfring To: netdev@vger.kernel.org, Augusto Mecking Caringi , "David S. Miller" , Jarod Wilson , Javier Martinez Canillas , Kees Cook Cc: LKML , kernel-janitors@vger.kernel.org References: <49543220-93e4-781c-877b-381277837152@users.sourceforge.net> Message-ID: <83404a6d-c7bc-7b06-fa93-0971b1116b9d@users.sourceforge.net> Date: Sun, 21 May 2017 22:14:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <49543220-93e4-781c-877b-381277837152@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:CwBSwpMcHKHb2i+z79D0lPbPopZQ3///4GEAdNbwdEwXJdUAOce vrCrVGvdZJbtxcKJ2CjM0WxbiHqlw9REEAOmyEJk4w74aIguvdlzJoOZJcvthnHpQ8rigym Bdokx3dw+BuHsjHV54Kw3NrINBrnuNSu6wa4M+BstD7iZw4GQ72wbMDpRH9jApX4RKgDfQ8 oMDAxrTkjYvzNFIum3RMQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:qxoK3IIo8FI=:iImhIKujTigmdACVFd0Iiu cSF+U9DWAgs5MjGquQIH64MgthqjmEVqfov419BFAjutk1buu0utd561fS1ImzQHB3UirpgZx F1j9DgmXUJvwCrwoWSBZf4IwLTn+L1vbIn00cVbZLnWougNvd5x1OOOg9MohuzxkuM4JILOgk ceG/Bd61OaX+veRq1FyYbaXA5Np6Qq6x4RWPUdDyzRWDI3K5hXQOb0ygwDczKL9Y8ACURfvBp BtTbN9XVBT9YLxporXwm73UziLzKM8zVRH4uLTUrXhx8t1O56Yuokj8j9XRRF5yv42vOoEFHL VJTdAaZGajoj9ZE++cp1K33BDy5aTg16qADW5DynUBh7Jrg8IXff8rmjVQz2hlEyKxo3QOFla MGdJTWBKKHfFw6+hsQM9WUziTRfvWOrDgYSkiyGoQXNy4ttHZ5bF4ZXwz0wrytcndx9r4EauC nzMJXxqWl89/Sq+Z+N8D+7xQmeCRjEvqlmG6RLKhymga4v5TFmYWipMKaVn0tPXAP5cgPr1eA 5OLBTJkVIw0Z1rHaTUtspVPKemcFVldgN/eWWcbFrY1ojvqpItlb7JAQ/U7WgDUefnabnaGYJ l6lQACPVoAOjMLiSyXBI9EGq1BFpnL7raRs0oV+U9M+mKrwCmdc5i/DpY24pGuinYrNl2koUq xpe/NiiZkIbRCcJse7LHr9YorqAlr+8vuc28b48ZxSebhYjE7DYX/jTEqXmmXsVS2dNTAmjqf xbPPZPNGoNPm4yS774uNJ/8Xa++2idId0we8k20DXyrd8m6hgsW9skOKIpZsmuZc5uXTEVrRe WnzxRCX Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sun, 21 May 2017 21:20:44 +0200 Replace the specification of four data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- net/atm/lec.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/net/atm/lec.c b/net/atm/lec.c index 09cfe87f0a44..6ad3ca625a44 100644 --- a/net/atm/lec.c +++ b/net/atm/lec.c @@ -518,5 +518,5 @@ send_to_lecd(struct lec_priv *priv, atmlec_msg_type type, return -1; skb->len = sizeof(struct atmlec_msg); mesg = (struct atmlec_msg *)skb->data; - memset(mesg, 0, sizeof(struct atmlec_msg)); + memset(mesg, 0, sizeof(*mesg)); mesg->type = type; @@ -690,5 +690,5 @@ static int lec_vcc_attach(struct atm_vcc *vcc, void __user *arg) if (ioc_data.dev_num < 0 || ioc_data.dev_num >= MAX_LEC_ITF || !dev_lec[ioc_data.dev_num]) return -EINVAL; - vpriv = kmalloc(sizeof(struct lec_vcc_priv), GFP_KERNEL); + vpriv = kmalloc(sizeof(*vpriv), GFP_KERNEL); if (!vpriv) @@ -1552,5 +1552,5 @@ static struct lec_arp_table *make_entry(struct lec_priv *priv, { struct lec_arp_table *to_return; - to_return = kzalloc(sizeof(struct lec_arp_table), GFP_ATOMIC); + to_return = kzalloc(sizeof(*to_return), GFP_ATOMIC); if (!to_return) { @@ -2156,5 +2156,5 @@ static int lec_mcast_make(struct lec_priv *priv, struct atm_vcc *vcc) struct lec_vcc_priv *vpriv; int err = 0; - vpriv = kmalloc(sizeof(struct lec_vcc_priv), GFP_KERNEL); + vpriv = kmalloc(sizeof(*vpriv), GFP_KERNEL); if (!vpriv) -- 2.13.0