mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>,
	Andy Whitcroft <apw@canonical.com>
Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de
Subject: Re: checkpatch: false positive "Alignment should match open parenthesis" with struct_group_tagged()
Date: Sat, 21 Nov 2026 13:51:05 -0800	[thread overview]
Message-ID: <834075e9deed32d899fd2be851620ece2c906404.camel@perches.com> (raw)
In-Reply-To: <20261121-gifted-cryptic-mouse-9362cf-mkl@pengutronix.de>

On Sat, 2026-11-21 at 22:37 +0100, Marc Kleine-Budde wrote:
> Hello,

Hello to you.

> it seems that all users of struct_group_tagged() in the kernel indent
> with 1 tab, like this:
> 
> > struct gs_host_frame {
> > 	struct_group_tagged(gs_host_frame_header, header,
> > 		u32 echo_id;
> > 		__le32 can_id;
> > 
> > 		u8 can_dlc;
> > 		u8 channel;
> > 		u8 flags;
> > 		u8 reserved;
> > 	);

Thanks for the report, but I don't care.
It's just an unusual macro mechanism.

include/linux/stddef.h:#define struct_group_tagged(TAG, NAME, MEMBERS...) \

etc..,

      reply	other threads:[~2026-11-21 21:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-21 21:37 Marc Kleine-Budde
2026-11-21 21:51 ` Joe Perches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=834075e9deed32d899fd2be851620ece2c906404.camel@perches.com \
    --to=joe@perches.com \
    --cc=apw@canonical.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mkl@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®