From: Dave Hansen <dave.hansen@intel.com>
To: Jack Allister <jalliste@amazon.com>
Cc: bp@alien8.de, dave.hansen@linux.intel.com, hdegoede@redhat.com,
hpa@zytor.com, juew@amazon.com, len.brown@intel.com,
linux-kernel@vger.kernel.org, mingo@redhat.com,
pdurrant@amazon.com, peterz@infradead.org,
rafael.j.wysocki@intel.com, rafael@kernel.org,
tglx@linutronix.de, usama.arif@bytedance.com, x86@kernel.org
Subject: Re: [PATCH v4] x86: intel_epb: Add earlyparam option to keep bias at performance
Date: Tue, 2 Jan 2024 07:09:42 -0800 [thread overview]
Message-ID: <83431857-7182-471a-9ff1-9dac37e5a02f@intel.com> (raw)
In-Reply-To: <20240102144646.44355-1-jalliste@amazon.com>
On 1/2/24 06:46, Jack Allister wrote:
> With the suggestion above you mentioned implementing this, if this was to be implemented
> do you think keeping it `intel_epb_restore_default` as a bool is still worth it? e.g:
...
> Or do you think it would be worth actually removing `intel_epb_no_override` and creating
> a module variable `intel_epb_restore_default` which is an enum of the performance values.
>
> Doing so would then allow for expansability in the future which you had already alluded to
> e.g setting to other values such as EPB_INDEX_BALANCE_POWERSAVE/PERFORMANCE.
You should leave 'intel_epb_restore_default' as a bool unless there is
some compelling reason to change it. A _possible_ future need for more
settings isn't compelling.
next prev parent reply other threads:[~2024-01-02 15:09 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 17:28 [PATCH] " Jack Allister
2023-12-04 17:44 ` Dave Hansen
2023-12-05 9:00 ` Durrant, Paul
2023-12-05 12:00 ` David Woodhouse
2023-12-05 12:12 ` Rafael J. Wysocki
2023-12-05 12:15 ` David Woodhouse
2023-12-05 12:31 ` Rafael J. Wysocki
2023-12-05 12:32 ` David Woodhouse
2023-12-05 12:43 ` Rafael J. Wysocki
2023-12-05 15:19 ` Dave Hansen
2023-12-05 15:27 ` Dave Hansen
2023-12-05 10:23 ` Jack Allister
2023-12-05 12:48 ` Rafael J. Wysocki
2023-12-05 13:13 ` Jack Allister
2023-12-05 13:23 ` [PATCH v3] " Jack Allister
2023-12-05 15:26 ` Dave Hansen
2023-12-05 13:30 ` [PATCH] " Rafael J. Wysocki
2023-12-05 15:14 ` [PATCH v4] " Jack Allister
2023-12-05 16:17 ` Dave Hansen
2024-01-02 14:46 ` Jack Allister
2024-01-02 15:09 ` Dave Hansen [this message]
2024-01-03 14:46 ` [PATCH v5] " Jack Allister
2024-01-03 15:17 ` Dave Hansen
2024-01-04 9:05 ` [PATCH v6] " Jack Allister
2024-01-04 9:22 ` Durrant, Paul
2024-01-03 15:18 ` [External] [PATCH v5] " Usama Arif
2024-01-04 9:00 ` Jack Allister
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83431857-7182-471a-9ff1-9dac37e5a02f@intel.com \
--to=dave.hansen@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=hpa@zytor.com \
--cc=jalliste@amazon.com \
--cc=juew@amazon.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pdurrant@amazon.com \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
--cc=tglx@linutronix.de \
--cc=usama.arif@bytedance.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®