From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2114C433E6 for ; Tue, 5 Jan 2021 10:38:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 673D522525 for ; Tue, 5 Jan 2021 10:38:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729356AbhAEKiX (ORCPT ); Tue, 5 Jan 2021 05:38:23 -0500 Received: from smtprelay0027.hostedemail.com ([216.40.44.27]:32962 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729244AbhAEKiW (ORCPT ); Tue, 5 Jan 2021 05:38:22 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay08.hostedemail.com (Postfix) with ESMTP id 2516D182CF66C; Tue, 5 Jan 2021 10:37:41 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: watch31_3a0e7d1274d8 X-Filterd-Recvd-Size: 3854 Received: from [192.168.1.159] (unknown [47.151.137.21]) (Authenticated sender: joe@perches.com) by omf06.hostedemail.com (Postfix) with ESMTPA; Tue, 5 Jan 2021 10:37:38 +0000 (UTC) Message-ID: <834383f004e107752d21ca8331add97808b3719d.camel@perches.com> Subject: Re: [PATCH] checkpatch: trivial style fixes From: Joe Perches To: Dwaipayan Ray , Andrew Morton Cc: linux-kernel-mentees@lists.linuxfoundation.org, linux-kernel@vger.kernel.org, lukas.bulwahn@gmail.com Date: Tue, 05 Jan 2021 02:37:37 -0800 In-Reply-To: <20210105103044.40282-1-dwaipayanray1@gmail.com> References: <20210105103044.40282-1-dwaipayanray1@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2021-01-05 at 16:00 +0530, Dwaipayan Ray wrote: > Indentations should use tabs wherever possible. > Replace spaces by tabs for indents. Thanks. Acked-by: Joe Perches > > Signed-off-by: Dwaipayan Ray > --- >  scripts/checkpatch.pl | 18 +++++++++--------- >  1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index e6857bdfcb2d..7a323ca8a177 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -2974,7 +2974,7 @@ sub process { >   } >   if (!defined $lines[$linenr]) { >   WARN("BAD_SIGN_OFF", > - "Co-developed-by: must be immediately followed by Signed-off-by:\n" . "$here\n" . $rawline); > + "Co-developed-by: must be immediately followed by Signed-off-by:\n" . "$here\n" . $rawline); >   } elsif ($rawlines[$linenr] !~ /^\s*signed-off-by:\s*(.*)/i) { >   WARN("BAD_SIGN_OFF", >   "Co-developed-by: must be immediately followed by Signed-off-by:\n" . "$here\n" . $rawline . "\n" .$rawlines[$linenr]); > @@ -2997,8 +2997,8 @@ sub process { >   if (ERROR("GERRIT_CHANGE_ID", >   "Remove Gerrit Change-Id's before submitting upstream\n" . $herecurr) && >   $fix) { > - fix_delete_line($fixlinenr, $rawline); > - } > + fix_delete_line($fixlinenr, $rawline); > + } >   } >   > >  # Check if the commit log is in a possible stack dump > @@ -3240,10 +3240,10 @@ sub process { >   next if ($start_char =~ /^\S$/); >   next if (index(" \t.,;?!", $end_char) == -1); >   > > - # avoid repeating hex occurrences like 'ff ff fe 09 ...' > - if ($first =~ /\b[0-9a-f]{2,}\b/i) { > - next if (!exists($allow_repeated_words{lc($first)})); > - } > + # avoid repeating hex occurrences like 'ff ff fe 09 ...' > + if ($first =~ /\b[0-9a-f]{2,}\b/i) { > + next if (!exists($allow_repeated_words{lc($first)})); > + } >   > >   if (WARN("REPEATED_WORD", >   "Possible repeated word: '$first'\n" . $herecurr) && > @@ -4432,7 +4432,7 @@ sub process { >   WARN("STATIC_CONST_CHAR_ARRAY", >   "char * array declaration might be better as static const\n" . >   $herecurr); > - } > + } >   > >  # check for sizeof(foo)/sizeof(foo[0]) that could be ARRAY_SIZE(foo) >   if ($line =~ m@\bsizeof\s*\(\s*($Lval)\s*\)@) { > @@ -5285,7 +5285,7 @@ sub process { >   $lines[$linenr - 3] !~ /^[ +]\s*$Ident\s*:/) { >   WARN("RETURN_VOID", >   "void function return statements are not generally useful\n" . $hereprev); > - } > + } >   > >  # if statements using unnecessary parentheses - ie: if ((foo == bar)) >   if ($perl_version_ok &&