From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D302AC4332F for ; Mon, 14 Feb 2022 17:28:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357094AbiBNR2y (ORCPT ); Mon, 14 Feb 2022 12:28:54 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:54404 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231523AbiBNR2v (ORCPT ); Mon, 14 Feb 2022 12:28:51 -0500 Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2615CA1AC for ; Mon, 14 Feb 2022 09:28:43 -0800 (PST) Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id DF6B640333 for ; Mon, 14 Feb 2022 17:28:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1644859721; bh=KsqdtAFgibXHueDPOB/KCI/9BNIh532HNP/vcYwtlGo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EaotnB1Q5yFIEvnLwgJI6YMC1Xh/XBf44S5x37IY1i39FrjwMI3ocKRYXgpsXzDPn XQeG7yTkx9rNDjBpnMwvwIU6G2HrNi39XUycdjD/JSBFCTst5IPjeHY/Ry+gwBGBZc RwWiQsNYFVkBrlQLXGclo5D5nCjOalXmlzU9Dfvxb2E/btBJHYZ04msn6Z4d5A9ODx oR76eU683D4HmjxudjtgqoZASkGsNv6BVhtIEWEvANTBfHOSNERhHs6/xTY7v9wpdx OxTVIkwxvEpikBroDqPUoIAUcU5uub6veWIqifw5oFFFt87bldKS+qOu0u7+ZZop2g uvEPtRY0BayWQ== Received: by mail-wm1-f70.google.com with SMTP id 125-20020a1c0283000000b0037bf720e6a8so7412089wmc.8 for ; Mon, 14 Feb 2022 09:28:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=KsqdtAFgibXHueDPOB/KCI/9BNIh532HNP/vcYwtlGo=; b=wNCQokyZ2zgiDL9+tNXGjqw8Ul0rxrUbX0BdhoiEzvUI9G320yt+ndciBo6D60L2aW y+hPQQOKbj2r5++eRcX/FhpVdVM0Gl+upNTtodSzBId1P0Gm+seAvwnMLjb1NgRTN7rh gwBjn13sUM82ql+b1wD8Uymdd22Iz7BSwXZFVy2xNcTp8GahAMF+Q7d5B1UWN6jnJ+iY qXpwnj5d+s33mGs7cAZh4VdeuTecWfx+MS/hSDFA/nRF3CNu6szAAt9189UxlA/1RmKs VRAeAzrZz9VPDRrsKYJ549SUI/1YrGRfBs729WUHBsAcGa/cdgQvPK4dbf9Ltx6Fkiyx L07A== X-Gm-Message-State: AOAM5335BxRmq0ypXhWOSAiP/6K4nNQkL48V3JPqDXmMz5zhyNtHULVq El+pzjEEewtZr1akEZrtY14mAHOWsqIC/HxsIcHyApoD4q8pjQoWRWYzrlzKhCdozHw2GScIFpT wYuAD+cS6GZLT7cb7mJdkiRV8Sjfe02+hMZQWjiJaXA== X-Received: by 2002:a05:6000:1888:: with SMTP id a8mr70866wri.258.1644859721542; Mon, 14 Feb 2022 09:28:41 -0800 (PST) X-Google-Smtp-Source: ABdhPJw4VJ7GdAoNVKf4UbogMbxJVPbcvrv/rGMMFokvBRogG6Fr4FjAve/dO2zAbHh3hVqyQLkpPA== X-Received: by 2002:a05:6000:1888:: with SMTP id a8mr70852wri.258.1644859721314; Mon, 14 Feb 2022 09:28:41 -0800 (PST) Received: from [192.168.0.106] (xdsl-188-155-168-84.adslplus.ch. [188.155.168.84]) by smtp.gmail.com with ESMTPSA id p32sm12933096wms.1.2022.02.14.09.28.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Feb 2022 09:28:40 -0800 (PST) Message-ID: <8347bd3c-12d4-8479-153f-8a5beaec786c@canonical.com> Date: Mon, 14 Feb 2022 18:28:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v2 3/4] regulator: dt-bindings: maxim,max77693: convert to dtschema Content-Language: en-US To: Mark Brown Cc: Chanwoo Choi , Pavel Machek , Rob Herring , Lee Jones , Sebastian Reichel , Liam Girdwood , linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org References: <20220111175017.223966-1-krzysztof.kozlowski@canonical.com> <20220111175017.223966-4-krzysztof.kozlowski@canonical.com> <12c66ced-c4a4-3a4e-f84b-83edb9e3fc58@canonical.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/02/2022 18:07, Mark Brown wrote: > On Mon, Feb 14, 2022 at 06:01:17PM +0100, Krzysztof Kozlowski wrote: > >> You mantioned new features - this approach does not change that. If you >> add new properties to common schema, you already alter bindings. Just >> because we use common part, it does not change the fact that it is a >> bindings change. Adding new features in common schema is the same >> binding change as adding new feature in the specific binding, except >> more work. > >> I guess you though that work in scaling, so yes, this scales worse. The >> benefit is that this really restricts usage of regulator to what is >> supported, so allows to detect wrongly configured DTS. > > We should have a way of specifying generic properties that doesn't > require us to go through every single user of a binding and updating > them all, then auditing by hand any new users to make sure they didn't > forget one of the generic properties. This is just error prone and > miserable, especially when most of the checking is done by hand rather > than automated. I see. The hardware really does not support most of core regulator features, so if we switch to your proposal (unevaluatedProperties:false), the DTS could contain something which is good from the core regulator point of view, but does not fit at all this hardware. A disallow/deny-list could solve it... but it also does not scale. Best regards, Krzysztof