From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A72B1C433FE for ; Wed, 16 Nov 2022 08:50:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233014AbiKPIuf (ORCPT ); Wed, 16 Nov 2022 03:50:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48168 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232670AbiKPIua (ORCPT ); Wed, 16 Nov 2022 03:50:30 -0500 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8335DA473 for ; Wed, 16 Nov 2022 00:50:28 -0800 (PST) Received: by mail-lf1-x135.google.com with SMTP id j16so28383202lfe.12 for ; Wed, 16 Nov 2022 00:50:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=tmMdI4WFLpMX3R8QoEHliNFUihkav6luIBgijGBFVqM=; b=tZvavu3atKzH6HkUL4xw65NKlHm9/49SW8Zn6whRQEBNVZnh5Byst3O4WZpUtUKAz2 rzAyXnqJdOE+5IOh92jywg1HY9sJMnXrn6KueGawoWcxKj1fsILNwpuLEiQWzBErMRnQ QJ+tg5QkztqZDizu7ufkgCiJgpiDDDYl1l7vi2wKqEviSuK7GHmwr3tViDOElUTM0a4U SVxF67yaP8/z9l/RkfejDzYZZn7yDgusiAqwTnoe4DGhkGzQKey+JpZf4xoOQ1A2TNvP pkJPzgB740r5UHVnhKUlopDNYVMyW3br6pS8PTscUfd5nTpPmUBW7APXLqiOZIhsrxeP Z2lA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tmMdI4WFLpMX3R8QoEHliNFUihkav6luIBgijGBFVqM=; b=55rBm4INunDcdDqU31y24PTzthHfYTh5IJeqIj4Za20WEo1ZRYuoei78XDtUlb9N94 h0K5iE/ggSBKaKXM8Ke8zbw5dAIxxDOcCtuCAMj+5niaNaeNekpf0/d/gWjGCYJTjBzd ChOggxQBH/2fbEnZ+KOZpPig+hpooqq9p3rwbmHeJk9hY/auNnlYnya+QGvjux5tbTyo 2xJXoUVHjB5ivwn3KtJPbSs6NcsbxrNYJIPZizCap/QW+fuDJkoxNqkqaRINTWN6J+yx X0kbp6tDqQXl44p3UaT8QZJoWMgBEDRY9k6abS1lCPk06oAwzrAbzid5X3n0RSF6altO Vowg== X-Gm-Message-State: ANoB5plYCq6QiBVf5bM1PFsFcNmbedJbvObYewkS0f1oceHbqbTdPPzd Pa1inFlqmdwSybNgkOS932YOEQj4gutIoHjx X-Google-Smtp-Source: AA0mqf5Gm3nkC4nCOWNd3+CUtd+Ha8+85ZHi/1/29g6hyZDOEHrihpAtNiwzQ+GD1IeVwdiv6nz0cQ== X-Received: by 2002:a05:6512:12c1:b0:4b1:785c:838d with SMTP id p1-20020a05651212c100b004b1785c838dmr6620071lfg.388.1668588626874; Wed, 16 Nov 2022 00:50:26 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id s7-20020a056512202700b004a0589786ddsm2499844lfs.69.2022.11.16.00.50.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Nov 2022 00:50:26 -0800 (PST) Message-ID: <83492f7f-1217-69aa-8b38-ec1f08995832@linaro.org> Date: Wed, 16 Nov 2022 09:50:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v3 1/2] dt-bindings: clock: Add bindings for Renesas ProXO Content-Language: en-US To: Alex Helms , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org Cc: krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, sboyd@kernel.org, mturquette@baylibre.com, geert+renesas@glider.be References: <20221115233749.10161-1-alexander.helms.jy@renesas.com> <20221115233749.10161-2-alexander.helms.jy@renesas.com> From: Krzysztof Kozlowski In-Reply-To: <20221115233749.10161-2-alexander.helms.jy@renesas.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/11/2022 00:37, Alex Helms wrote: > Add dt bindings for the Renesas ProXO oscillator. > > Signed-off-by: Alex Helms > --- > .../bindings/clock/renesas,proxo.yaml | 51 +++++++++++++++++++ > MAINTAINERS | 5 ++ > 2 files changed, 56 insertions(+) > create mode 100644 Documentation/devicetree/bindings/clock/renesas,proxo.yaml > > diff --git a/Documentation/devicetree/bindings/clock/renesas,proxo.yaml b/Documentation/devicetree/bindings/clock/renesas,proxo.yaml > new file mode 100644 > index 000000000..ff960196d > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/renesas,proxo.yaml > @@ -0,0 +1,51 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/clock/renesas,proxo.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Renesas ProXO Oscillator Device Tree Bindings Same comments as for your other patch. All the same... > + > +maintainers: > + - Alex Helms > + > +description: > + Renesas ProXO is a family of programmable ultra-low phase noise > + quartz-based oscillators. > + > +properties: > + '#clock-cells': > + const: 0 > + > + compatible: > + enum: > + - renesas,proxo-xp > + > + reg: > + maxItems: 1 > + > + clock-output-names: > + maxItems: 1 > + > + renesas,crystal-frequency-hz: > + description: Internal crystal frequency, default is 50000000 (50MHz) If it is internal, then it is fixed, right? Embedded in the chip, always the same. Why do you need to specify it? Best regards, Krzysztof