mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Gary R Hook <gary.hook@amd.com>
To: Colin King <colin.king@canonical.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	"David S . Miller" <davem@davemloft.net>,
	linux-crypto@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org,
	Herbert Xu <herbert@gondor.apana.org.au>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] crypto: ccp: remove unused variable qim
Date: Tue, 17 Oct 2017 17:12:12 -0500	[thread overview]
Message-ID: <83517ed8-3dc5-4ecd-b3e1-7412e8eef472@amd.com> (raw)
In-Reply-To: <20171012165541.32256-1-colin.king@canonical.com>

On 10/12/2017 11:55 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variable qim is assigned but never read, it is redundant and can
> be removed.
>
> Cleans up clang warning: Value stored to 'qim' is never read
>
> Fixes: 4b394a232df7 ("crypto: ccp - Let a v5 CCP provide the same function as v3")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Acked-by: Gary R Hook <gary.hook@amd.com>

> ---
>  drivers/crypto/ccp/ccp-dev-v5.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/crypto/ccp/ccp-dev-v5.c b/drivers/crypto/ccp/ccp-dev-v5.c
> index 65604fc65e8f..44a4d2779b15 100644
> --- a/drivers/crypto/ccp/ccp-dev-v5.c
> +++ b/drivers/crypto/ccp/ccp-dev-v5.c
> @@ -788,13 +788,12 @@ static int ccp5_init(struct ccp_device *ccp)
>  	struct ccp_cmd_queue *cmd_q;
>  	struct dma_pool *dma_pool;
>  	char dma_pool_name[MAX_DMAPOOL_NAME_LEN];
> -	unsigned int qmr, qim, i;
> +	unsigned int qmr, i;
>  	u64 status;
>  	u32 status_lo, status_hi;
>  	int ret;
>
>  	/* Find available queues */
> -	qim = 0;
>  	qmr = ioread32(ccp->io_regs + Q_MASK_REG);
>  	for (i = 0; i < MAX_HW_QUEUES; i++) {
>
>

  reply	other threads:[~2017-10-17 22:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-12 16:55 Colin King
2017-10-17 22:12 ` Gary R Hook [this message]
2017-11-03 14:23 ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83517ed8-3dc5-4ecd-b3e1-7412e8eef472@amd.com \
    --to=gary.hook@amd.com \
    --cc=colin.king@canonical.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=thomas.lendacky@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®