From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6751EC77B6E for ; Thu, 6 Apr 2023 20:42:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240410AbjDFUmH (ORCPT ); Thu, 6 Apr 2023 16:42:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54978 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240337AbjDFUla (ORCPT ); Thu, 6 Apr 2023 16:41:30 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B5DFB45D; Thu, 6 Apr 2023 13:38:09 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AC10860F77; Thu, 6 Apr 2023 20:38:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9211FC433D2; Thu, 6 Apr 2023 20:38:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680813488; bh=3Cznac5B+3sy6hB9DB3/iijT0kNRLGM0krGAPHIjwzU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=XFJOGBaUci1k2qda+64OPr7W9hnUOcTeNhu8CRqtWNtPwUevBZwT16jGG3OVwhyt6 AuNgxgN1jYEMc5w6gdtT9yJkiZucj+V/TNA30stBeFypoEk7ngGvA6hqr02fwi5Aez GHIbpj6mPZOr3k79jsZDKz8U4hCkRCsxNRrSyrRO+wsrPoD+BVL8nkL8cgyQi8KOCn dERdf/af6ZVxFtDuA+E7sSDkjuZjomZO80b6DxcjawKGW1SgxcO7nPGGFoR+oMlhid NBMfqT6f5zCbIiEtVmuoanCXWzgnXbMAvqboU/k95P4EGkmZtrMa7LljcY1ea7YzzI TCri2M0SRZ1vg== Message-ID: <8353399f-c6de-8da7-78f1-d6a558c462d0@kernel.org> Date: Thu, 6 Apr 2023 22:38:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH V2 3/3] ARM: dts: imx6ull-dhcor: Add Marantec maveo box To: Christoph Niedermaier , "linux-arm-kernel@lists.infradead.org" Cc: Rob Herring , Krzysztof Kozlowski , Shawn Guo , Li Yang , Marek Vasut , Fabio Estevam , NXP Linux Team , kernel , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <20230406154900.6423-1-cniedermaier@dh-electronics.com> <20230406154900.6423-3-cniedermaier@dh-electronics.com> <5478133e-7772-1db9-3473-1ec86fa2aae2@linaro.org> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/04/2023 21:57, Christoph Niedermaier wrote: >>>>> + aliases { >>>>> + /delete-property/ mmc0; /* Avoid double definitions */ >>>> >>>> I don't understand it. What is "double definition" of aliases? >>> >>> Otherwise I end up like this: >>> mmc0 = &usdhc1; >>> mmc1 = &usdhc2; >>> mmc2 = &usdhc2; >>> >>> Is "Ensure unique allocation" a better comment here? >>> >>>> >>>>> + /delete-property/ mmc1; >>>>> + mmc2 = &usdhc2; /* eMMC should be mmc2 */ >>>> >>>> Why? How is this labeled on the board (physically or on schematics)? If >>>> you answer here "for booting", then the answer is NAK. Don't add >>>> software policies to Devicetree. >>> >>> The name in the schematics is "SD2". >> >> Answering also to above - then likely the aliases should be dropped from >> SoM. I doubt that Som calls it SD1 and your board SD2... > > Maybe I don't quite get it, but the hardware starts counting at 1. The first > interface is SD1 and it is used as WiFi. The second one is SD2 which is the > eMMC. So with this aliases it should match SD2 to mmc2. > Do you want me to delete the aliases in the include file "imx6ull-dhcor-som.dtsi" Yes, because it incorrectly calls eMMC as mmc1. You said it is SD2, right? Best regards, Krzysztof