From: Dan Carpenter <dan.carpenter@linaro.org>
To: Aman Sharma <210100011@iitb.ac.in>
Cc: Gregkh <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] Staging: pi433: Updated bitrate range from datasheet
Date: Mon, 4 Mar 2024 13:18:53 +0300 [thread overview]
Message-ID: <835bba82-c144-4674-b8ec-a6bd6af89daa@moroto.mountain> (raw)
In-Reply-To: <74ec69941cb67e3a351ebd23d5ad4a5b@iitb.ac.in>
On Mon, Mar 04, 2024 at 02:04:08PM +0530, Aman Sharma wrote:
> Tbh this is my first patch and I don't have the hardware to test this. I
> thought updating the values from the datasheet directly might be a good idea
> as it would be the correct range. Please correct me if there is something
> that I missed / need to know.
>
No, patch is fine. There is no downside to updating the .txt
documentation in this way. I was just wondering.
> On 2024-03-04 13:55, Dan Carpenter wrote:
> > On Mon, Mar 04, 2024 at 11:23:40AM +0530, Aman Sharma wrote:
> > > Updated bitrate range for FSK and OOK modulation from the RFM69
> > > Datasheet.
> > > The values are mentioned in Section 2.3.2 of the datasheet.
> >
> > Have you tested these as well? Sending untested patches is not
> > necessarily against the rules, but it seems like maybe you have this
> > hardware and can test it. Could you please talk about what testing you
> > did?
> >
> > >
> > > Signed-off-by: Aman Sharma<amansharma6122002@gmail.com>
> > ^
> > Missing space.
> >
>
> I'll fix this if I am allowed to submit a new patch.
regards,
dan carpenter
prev parent reply other threads:[~2024-03-04 10:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-04 5:53 Aman Sharma
2024-03-04 6:20 ` Gregkh
2024-03-04 8:25 ` Dan Carpenter
2024-03-04 8:34 ` Aman Sharma
2024-03-04 10:18 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=835bba82-c144-4674-b8ec-a6bd6af89daa@moroto.mountain \
--to=dan.carpenter@linaro.org \
--cc=210100011@iitb.ac.in \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®