From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from CO1PR03CU002.outbound.protection.outlook.com (mail-westus2azon11010045.outbound.protection.outlook.com [52.101.46.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32149376490 for ; Fri, 23 Jan 2026 10:42:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.46.45 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769164938; cv=fail; b=gq6nQ/4f4B9FpXWUts9uIPGQicjUMEsRv7LFR+rmMCM8bgxfipxbHo2hsTLfAKDEymX2yQZAcxfe5uOZMlCwyYlqwzqdjd6WLH+iU9uVLucz/kZl1wjZS07KTnhGyNZ/z8Cab08KngiwOc3BPxF1uVqhRG3ldg58ArqRt4k1pqY= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769164938; c=relaxed/simple; bh=3KVyc4HPVbD8VyNmkQwHsCJkBAgOQc6TdiCYiNwvBSg=; h=Message-ID:Date:Subject:From:To:Cc:References:In-Reply-To: Content-Type:MIME-Version; b=XGTd4UkL8acdHheC7jPGG9yvTchjSsPzQUuphS/qbn0JRMsL5dK/Nu9l4GOb5rFCzbG6UI0k4K6Y4WaDrZYO8rJvz/oC8uxctqwBWEaA9HNog12lb/IqSW+8ZoOFlfGgR/mNE6W/mH23vUOYxcA3FklHyDfQE2I0qIyzfcSxejo= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=sYPf+Zug; arc=fail smtp.client-ip=52.101.46.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="sYPf+Zug" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=KF2qp6oI0/ahc2MEKQVOQxFdmUw4UC69MZWFfVlF4rLAYmxOgDNltIEjGhDljZZIjuWAdOeE67KyoWz3uR8F2eyaV3ou6Cb8ZwO4Q5MnCrri/ygaeQR6iXB6baQ9KUWlnK/FzV9dS59U6od2bh0tBsVH/sdTkJkb1CC4iTyMGid0ugw+KRu9a6joECb9ECr8wLre9K9YUqqP6BuXP6wfSMAFbQGjd8Cf94ESQiEnn/Hm+evNIweXWh9r3X5Pijj9rwV0riQ8Jg6IvwkWs058eDemt2C/sAiCRwj0zrUynA8Hhl1hRk0SXisWLm+k7R+3c3uUPIFvyufMQsBuDPOOKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=02hlO+gU/RfRxZyVq2bL7ywdHosxEm6naRALWXR3cDc=; b=ucLISERc6EBHlz/NNB/dI/R796Knhsoi5yUb/Nou1QONfek3OAK/BJB+1LN6PnImXUAQDtVA+FiX5PqkjumGvhHuOzyjjmfDesErCksDQ0t/ohc0g/azLNWDEoXVvZOyvnfKodGSou2GS7nSkAGkJa1aWUoKqqJYi0Tnb1kMqPdWChY/W+K4Nk5+UDecsay2Hn3nKAoDWnhJvjiK95Fg/FkKbiDtq5bRyPLHzhHvT/b6OZYp0Y/2rC5fNXoJs3FffuFXopJh5NGIUZpqv8yMUmFjfqwQpl83DEk+rzRTXrq+Or9isvS+zn7o2FMnVQ5eI/R0QADXV/Pw/S600AsLdg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=02hlO+gU/RfRxZyVq2bL7ywdHosxEm6naRALWXR3cDc=; b=sYPf+ZugIott20GFnRFvg1xu1F3Z4qaITOtysvE0kP0ox4JwSL8uF8QkORWz8E6tW0Wb00Il5vMEIooOFgikM7vOO0VEHXbf5TJ/+uk5VWHrNrT+j5Pc6vqXmDLQi6icWROmCtPqI2qqQnfOruDYYlhfz6DCHjL3G4KF30xBT4I= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from MW4PR12MB7465.namprd12.prod.outlook.com (2603:10b6:303:212::18) by MN2PR12MB4093.namprd12.prod.outlook.com (2603:10b6:208:198::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9542.12; Fri, 23 Jan 2026 10:42:14 +0000 Received: from MW4PR12MB7465.namprd12.prod.outlook.com ([fe80::d8ab:cadd:74a8:5132]) by MW4PR12MB7465.namprd12.prod.outlook.com ([fe80::d8ab:cadd:74a8:5132%6]) with mapi id 15.20.9542.010; Fri, 23 Jan 2026 10:42:14 +0000 Message-ID: <836669ac-473f-4c30-a368-c05bfa86c306@amd.com> Date: Fri, 23 Jan 2026 16:12:07 +0530 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V3 2/5] mm/khugepaged: count small VMAs towards scan limit From: "Garg, Shivank" To: Andrew Morton Cc: Zi Yan , Baolin Wang , "Liam R . Howlett" , Nico Pache , David Hildenbrand , Ryan Roberts , Barry Song , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Wei Yang , Lorenzo Stoakes References: <20260118192253.9263-4-shivankg@amd.com> <20260118192253.9263-8-shivankg@amd.com> <829b62c8-e3eb-485f-8d7b-01419c841cc8@arm.com> <7193b89e-ac2d-47c9-8fa5-68e35c57d4b6@amd.com> Content-Language: en-US In-Reply-To: <7193b89e-ac2d-47c9-8fa5-68e35c57d4b6@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: BM1PR01CA0148.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:68::18) To MW4PR12MB7465.namprd12.prod.outlook.com (2603:10b6:303:212::18) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW4PR12MB7465:EE_|MN2PR12MB4093:EE_ X-MS-Office365-Filtering-Correlation-Id: a4f545f7-ed97-4aed-e2f3-08de5a6c1270 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?SmpoOU5MTHRsU0lNN0V6TmdLeHB0VWZSZ3hVUDNEYVBrU1ZZWmswQk1aL1c4?= =?utf-8?B?bXAvbFQycGxBaThmKzBxc3hjbEtmZFdEdWVpMmovRXhwbmQrWDIvR0pId01a?= =?utf-8?B?M21SVnRmUFJWV05DT1Q4S2hJOFFLd1BjL0thOWg1ZXQrQmdjQmJ6SGNaaVZr?= =?utf-8?B?N3NuS1ZjOW8vNHVQL0RPQzJIdng5cjhxUlRmTERaV3pKM3J3Y29wYXY3LzVX?= =?utf-8?B?QXNEQWFuRjFuN3BrME9vRjRIY3hjTlUzWjRTSFFka2dkeUFuZUFGNlB0N2U5?= =?utf-8?B?SHQ2ZndNR1QzK0hVT0NqaFRVWWNPZmxWNlZBck5CbTBlTjVjVlhCYmVkRmN5?= =?utf-8?B?b2Zpc0xua1dhOWdvVWtueERRYWJRRFV3eFp3NFlrdm1JOWJVS3FKazhPb1JO?= =?utf-8?B?QnVKU3E5UGFVTW1NM2lOSHBCQkhIM2pobHkyVk1ydCtlK1pUQUVmakNWdEZM?= =?utf-8?B?eUorR01PZytLSkl3Y0lqWUNCRkpCeVpEbkdyZHVpNUVLa3lUN2pIdWZ2ZXRZ?= =?utf-8?B?SVQ0ckJXNW9lZ2dvVWhZNk5ybWYyODdoMjNwR1BINVBReUhyY014ODNPWEYx?= =?utf-8?B?OG1wQldGSFFzcTRVUWpIMXdZcG95VjZvY1lydFVpa3BNTmYrdVRYMFUzOWM4?= =?utf-8?B?cFN3SSs1U3NpdndrWEtMRVpsQzQ1c3JZVUJXeFkyNk5tS1BLTENwQlUxVFVL?= =?utf-8?B?UEM0cHozWkxQOXBRUVk3OVhxTGFwSGhRTVlKNnNCY0FrNFNzVkRKZGh5TmpO?= =?utf-8?B?QXZiUmx5c2kxa3pjOHpCaEVRYTlORkx6TlVwblYvU0g0c2prdU5zTXd1OXda?= =?utf-8?B?ZlNGRm5jRzUzZStROVpHeU1LTGsrdEV5OWM3SkVabWs2aWpGTVI3WVE0Mk9E?= =?utf-8?B?STY1Ukszckd6ZW1hTUJWc3djL3FzanZCQ0NOS2l0S3hRWFJNVDlWV29yK2xa?= =?utf-8?B?Wk9OdVNLalRUdEZtUnBxWU1pR3pXd1MwQ09xbUNJZ1RsdlJLcmtVc29tUy9k?= =?utf-8?B?S2ZTbVQ4M1N3OXBURzNwejFzcnF1R1JpN3RYblBDNjVVbHBkRkxsYU4wVVVq?= =?utf-8?B?bUZiODhCTlBMb0RITWJXS1dsbnhuM01TM29OVGRFVkNoa0QxUnVpbkRjSEwr?= =?utf-8?B?UWdOeDVqNVB1eVFXZDJLQzYxY1ZQRlBqQ09YWWplVnRXbnl1TU5hTUNsZStL?= =?utf-8?B?ODhIVkFvZHhncHJ5ZGx4T3pLanQrU3hnS1liaTh2REJzUjZUMVo5WFVPVFBk?= =?utf-8?B?Yy9QWTQxczM3djJBeEFLRng2S1U0MWFxbnNXUkNDWXMweW00bmk5WXhPbSsr?= =?utf-8?B?TlNNdFU1dUdUT1B3NEQwL21SL0gwLzJ2eUlpWDNjY2ZiNUVacjQ4T05DODB2?= =?utf-8?B?aHFFL2tjTkVBS0lMam03TTRaVVJWYmNQaTlIMStodUdXWGVFWUNtRU5EZzZH?= =?utf-8?B?cUNVUDNoOGVlajk3cHQ5c1Z3d2tHRWdBOUpyMWQ5TVF2bnBPM0JGTDhBUTNv?= =?utf-8?B?YzRjdnhiU2dTSFkweUc3V3I1bmU0MWhrLzNpckFrMjZxa3Nna0YvcndmQjhU?= =?utf-8?B?MkE1VGRvYllncStzUmxpT2xLQnUvRk1uYWhlaU9zSlpUQUlSbXphbk1TRmRH?= =?utf-8?B?OVo2RVd4ak0wTGFHaEZmdTRWWFVTMW1kZkFNSUlrN3BnVE1DSjB3Umpld3Zn?= =?utf-8?B?WGJRbFBFend3UUlFOW8vQUQrTVFhRVBudnNocnhTQlpIc2hidGw0VU9LdFRx?= =?utf-8?B?NlkzZlVqdWlhVXBBSDI0aWZXNnRLZVpENlkvZHVjWW9UcFpBUTRvQnJlbFYv?= =?utf-8?B?TTRIZmp3aTZXSFJXdm8wa1VBSGlYT2pGQUozMGsrWWY3VVEzdi9iZEtTM2Jp?= =?utf-8?B?NWR2TThvS0ozbng2OUN6eFBPbWtFcHRySTd6VnZiMCtHTDFlQllMV2NMOHov?= =?utf-8?B?WlVTa3BwSjVXTno2K1ByRWo0QlM2RE1xNjJKSjlzM293dGdRNlY1aXNoalcz?= =?utf-8?B?WEk2THJTemFFVFlSTUtnQmZ5ZjROb3J1VUYwbWJjTVltNC9Obm8yY2Z4enV2?= =?utf-8?B?eFF3UEo0WFJKWmlKRjM2Mk1xRmhQY2UzRzNqbHR6b1VLZ1YzdkZXZncvNUt3?= =?utf-8?Q?QVdE=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR12MB7465.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(366016)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TFRRaWo1L2NuSVJCZy81bWpiWkJSUXpaQ2FoK0xTZEVNTkpiMXhBMktCaVox?= =?utf-8?B?NXpQSzJTK0hwcEp1WGt4aHZFSGc2elI2OG1RZ25Zc1ZnbDE4SFRoMVhKVTBx?= =?utf-8?B?VnVkdExqUVhVY1hVMzlFYVBKWjBhdW5tK0RncWhQWDB6SVZvay9lcGtLYnZj?= =?utf-8?B?THBaTk9ia2w0K2xZc3F5OHNsUEJGWTAwWVJvajdEdlNnbS9ORDdHU2RZcXFa?= =?utf-8?B?ZnZSZlJhaWo3NkdxbjJUeW1iU2JwRWNLeGx2RmVvdUF3c1k0Zm9Dd3lJbzY3?= =?utf-8?B?YmJGeEpsMVRlRnBzR2RsZ0R4THVZMnBoand0T1d0SHh6K0x1MkxUQThOWnlv?= =?utf-8?B?OS9FMkFPK3kzQWJ1K1ZnRVdYOEdEV3BQeDhHOVBkaVV3Vnp3WGdxOFpTMTZT?= =?utf-8?B?UlEyUnZyMTYvL2FNVy8wOVZ4OFpkTnZoUDdPeEpQVFpKL2FMSzk3RTExU2R3?= =?utf-8?B?di9KYnBraVlFS1poMnNlRFRZaWRPM2hwKzQ1WC9qZCtlZngzSy9ISjFhT2Nj?= =?utf-8?B?aWhuWU13YzdWc1FOb25ZQThBTE42Ni81SWl0ZWtSaVhqbFdWNTNBUFduam5i?= =?utf-8?B?VVRVaGNFaDdxOThZTkxnRGZxdXpFVDBic1c0dnpIL1dScGFrOEtTdWZSeUZR?= =?utf-8?B?MjJmam1WaDZCajdEZkFKOVBZZ2FlNHYxejRGN25uMEVSdzEvL28vcXNkQ2FM?= =?utf-8?B?dWVxdzFiZ0Fsdk96VEFjKyt1UzFrK1VyVEo0VG1uSURwNVg1b0dkc1ZLT2ds?= =?utf-8?B?NUI4ZkZFM0VkWGp3QXhPdE5FSzFUMzNWa1h2SW9ZWFRhV3RoeGhENXBuaWwr?= =?utf-8?B?NEx1akJDMXBReEV4QXlZME94aTY0ME56M2EvL0FpSTdHWlNzcDBBTmVHZ0hS?= =?utf-8?B?K0JHajVDa3JqVGVnWXBFbm1hbU5rWW1BWnBJOGdneE1kVDJFTi9mK3B4b3Ew?= =?utf-8?B?NWg5M2tqTVliK3g0UXRyUTlhZnczNHdZU2tMNnl6SFVPMEZZei9Oak4raWdX?= =?utf-8?B?SUIzUTB2RXVWb1daZnRkNWV5dXlvaG5KZEduK2hOTnBoNGVCVy9oaW1SSTRn?= =?utf-8?B?UGx5YXZnb0xuYXNwaG83VVN5ZTNkMHBCUk03RkZjZE10bk1XV0VTVGJ6UHBX?= =?utf-8?B?VzVldG1WQk9NaVRJdENjRXoyN0N4UlhkbFdycEFFSkwxNDV5OVpkS2p1d1pq?= =?utf-8?B?a2dRSDdjd0Y5Wnora0VlRHdMMEMrNEZQdDd3eEx2WkhVOXVQZ1d2WDJ3OVJk?= =?utf-8?B?c0hBYmlxOEI3SWNWN3NMeGkySzNBalROUzVLTHFScno0WTZ2bmdkaE9GTXdx?= =?utf-8?B?eTUxTnlGckpkLzdrOGJiZjM4N1JTeVNJU3A3aCtkMURNTElxNHplTGxnc3pu?= =?utf-8?B?WkxrajB5MmxHRzZDejEvanZhcWN2MHkvNnFqYjl6SWswWXg2eCtuaEtTL1o2?= =?utf-8?B?SE5sVjhxenR3eldONnVvQzA5aHk3Smp4S3NZT3hTemFLeWNHRzgzMnUzTno4?= =?utf-8?B?aVgyZlVNL0RlQUNwbk5OVEtVWlVhVHh6RCtxWVVZL0lXQURFdysxQVJvcWxP?= =?utf-8?B?ODY2ZmkvR3RXTitRR1JFcE1ZSXFDVHpkSm0yRzhweXNOZGRHWHY0RWNhUGl0?= =?utf-8?B?QU11Z0VBNHpsc2MxRzd1VllpRnlFNmxXOE1ua0c1bXU4T0pER2JOVndzQy9L?= =?utf-8?B?ME9KcmFtb1VsS05OL2M5OGRRcDJ1MlpVeTV1TVc2Vk1iMmlJYVNBWmpCRXdw?= =?utf-8?B?YkFuSElyVkNhWktCQTh3MkFtblRDY1AvSmI5dUdiak1mRVU1eER4RHZjcXQx?= =?utf-8?B?TFpiNy9FT1Y2QVY2SFJia3FqU0UrSWJyUzB3TSswTXpXTVdLakF5R29FRlp0?= =?utf-8?B?c3NqeTlPUEV1WHFSVjhPM1ZrbHRGMVJzeW5lTjJROGNQdklIRkdObXBTNzRB?= =?utf-8?B?eXJLNFNQMGVvT2Vvelh5SFpsZXB3QzZBOHNLM1VjUVlrNUdZNms1Tlp6aDkx?= =?utf-8?B?L3Vid2JFOWJyWXRzY2xuZEpONm5FTEhZL3JtQ0hKUVlBUHhjendBY0x2TUNB?= =?utf-8?B?TDNhMGwrYm9GRHg2Nmc1SEw4N2o5UHoveW9qK1psWHdmWmJWUGdGYXBTQkJ2?= =?utf-8?B?aWVLK0lycmFJSEYyeUFtdERQVnorekdGZ214TnFSbnVENE4yb2xvSHhKUFdW?= =?utf-8?B?Qll4Y2tBcVlMMDFsSHZ4UEhCQnc4QXRRNDEwWExwWTN1THpQV2hadWpYWG9n?= =?utf-8?B?MDVrcXo0Tk5EMEFPRmJmMml1MnN5aGhGVEpRc0lKbkZwSmxYMmtWSFVZS2w0?= =?utf-8?B?NjRWOTFlVkJjdk9OTHhNeXM3NFdqMFNoNnNHZFhYcXBreklDT2NIQT09?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: a4f545f7-ed97-4aed-e2f3-08de5a6c1270 X-MS-Exchange-CrossTenant-AuthSource: MW4PR12MB7465.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jan 2026 10:42:14.6897 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HqZw/OWN7I1/Fj+qhfkiNcOULFjGwAcmncShAQ3jdTy3UoBWeADS0zHyQaWVizr4IMgr+o+iqNVYE8gQ4PIpng== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4093 On 1/22/2026 5:56 PM, Garg, Shivank wrote: > > > On 1/22/2026 2:14 PM, Lance Yang wrote: >> >> >> On 2026/1/22 15:32, Dev Jain wrote: >>> >>> On 19/01/26 12:52 am, Shivank Garg wrote: >>>> The khugepaged_scan_mm_slot() uses a 'progress' counter to limit the >>>> amount of work performed and consists of three components: >>>> 1. Transitioning to a new mm (+1). >>>> 2. Skipping an unsuitable VMA (+1). >>>> 3. Scanning a PMD-sized range (+HPAGE_PMD_NR). >>>> >>>> Consider a 1MB VMA sitting between two 2MB alignment boundaries: >>>> >>>>       vma1       vma2   vma3 >>>>      +----------+------+----------+ >>>>      |2M        |1M    |2M        | >>>>      +----------+------+----------+ >>>>                 ^      ^ >>>>                 start  end >>>>                 ^ >>>>            hstart,hend >>> >>> Won't such a VMA be skipped by thp_vma_allowable_order()? That internally >>> checks, apart from eligibility by sysfs, that the extent of the VMA can >>> map a hugepage. >> >> Ah, you're right! >> >> I was worrying about a case that doesn't actually happen. >> > You're right, thp_vma_allowable_order() is taking care of this, making > hend <= hstart check redundant. > > Thank you for catching this. > > I'll drop this change and send revision keeping only the unsigned int type > change for 'progress'. > Hi Andrew, Please drop this patch. As Dev and Lance noted that the hend <= hstart handling check is redundant. The 'progress' variable to unsigned int is not critical either. Other patches from series remain unchanged. Sorry for the noise, and thanks. Regards, Shivank