mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Sverdlin, Alexander" <alexander.sverdlin@siemens.com>
To: "aradhya.bhatia@linux.dev" <aradhya.bhatia@linux.dev>
Cc: "j-choudhary@ti.com" <j-choudhary@ti.com>,
	"u-kumar1@ti.com" <u-kumar1@ti.com>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"devarsht@ti.com" <devarsht@ti.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"nm@ti.com" <nm@ti.com>, "vigneshr@ti.com" <vigneshr@ti.com>,
	"praneeth@ti.com" <praneeth@ti.com>
Subject: Re: [PATCH v4 0/3] drm/tidss: Add OLDI bridge support
Date: Wed, 19 Mar 2025 18:00:21 +0000	[thread overview]
Message-ID: <8366a3d736f9937667aab024895a59e5947dd4a5.camel@siemens.com> (raw)
In-Reply-To: <20241124143649.686995-1-aradhya.bhatia@linux.dev>

Thank you for the patches, Aradhya!

On Sun, 2024-11-24 at 20:06 +0530, Aradhya Bhatia wrote:
> Regardless, I'd appreciate it if somebody can test it, and report back if they
> observe any issues.

I've tried to test the patchset with necessary pre-requisites and DT additions
with a single channel LVDS pannel and while I'm not successful yet, I've also noticed
the following warning:

tidss 30200000.dss: vp0: Clock rate 24285714 differs over 5% from requested 37000000

even though later the clock seems to be correctly set up:

$ cat /sys/kernel/debug/clk/clk_summary 

                                 enable  prepare  protect                                duty  hardware                            connection
   clock                          count    count    count        rate   accuracy phase  cycle    enable   consumer                         id
---------------------------------------------------------------------------------------------------------------------------------------------
 clk:186:6                           1       1        0        250000000   0          0     50000      Y   30200000.dss                    fck                      
                                                                                                           deviceless                      no_connection_id         
 clk:186:4                           0       0        0        0           0          0     50000      Y   deviceless                      no_connection_id         
 clk:186:3                           0       0        0        170000000   0          0     50000      Y   deviceless                      no_connection_id         
    clk:186:2                        0       0        0        170000000   0          0     50000      Y      30200000.dss                    vp2                      
                                                                                                              deviceless                      no_connection_id         
 clk:186:0                           1       1        0        259090909   0          0     50000      Y   oldi@0                          serial                   
                                                                                                           deviceless                      no_connection_id         
    clock-divider-oldi               1       1        0        37012987    0          0     50000      Y      30200000.dss                    vp1                      

Looks like "clock-divider-oldi" doesn't propagate clk_set_rate() to the parent,
but the parent is being set later independently?

-- 
Alexander Sverdlin
Siemens AG
www.siemens.com

  parent reply	other threads:[~2025-03-19 18:00 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-24 14:36 Aradhya Bhatia
2024-11-24 14:36 ` [PATCH v4 1/3] dt-bindings: display: ti,am65x-dss: Re-indent the example Aradhya Bhatia
2024-11-24 14:36 ` [PATCH v4 2/3] dt-bindings: display: ti: Add schema for AM625 OLDI Transmitter Aradhya Bhatia
2024-12-04 14:09   ` Rob Herring
2024-11-24 14:36 ` [PATCH v4 3/3] drm/tidss: Add OLDI bridge support Aradhya Bhatia
2025-03-18 13:35   ` Sverdlin, Alexander
2025-03-20 13:27     ` Aradhya Bhatia
2024-12-03 12:12 ` [PATCH v4 0/3] " Tomi Valkeinen
2024-12-03 18:14   ` Aradhya Bhatia
2024-12-03 18:36     ` Tomi Valkeinen
2024-12-09  4:17       ` Aradhya Bhatia
2025-03-19 18:00 ` Sverdlin, Alexander [this message]
2025-03-20 13:24   ` Aradhya Bhatia
2025-03-20 13:30     ` Sverdlin, Alexander
2025-03-25 18:57     ` Sverdlin, Alexander
2025-03-29 13:45       ` Aradhya Bhatia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8366a3d736f9937667aab024895a59e5947dd4a5.camel@siemens.com \
    --to=alexander.sverdlin@siemens.com \
    --cc=aradhya.bhatia@linux.dev \
    --cc=devarsht@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=j-choudhary@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=praneeth@ti.com \
    --cc=u-kumar1@ti.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®