mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Derek J. Clark" <derekjohn.clark@gmail.com>
To: Jiri Kosina <jikos@kernel.org>, Aditya Dash <mradityadash@gmail.com>
Cc: Benjamin Tissoires <bentiss@kernel.org>,
	Mark Pearson <mpearson-lenovo@squebb.ca>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 5/7] HID: hid-lenovo-go: normalize calibration failure status
Date: Tue, 22 Sep 2026 14:25:00 -0700	[thread overview]
Message-ID: <836F1B09-60CA-4A82-8293-0F9CF506E593@gmail.com> (raw)
In-Reply-To: <p1o757n0-2rro-rnqp-56qo-56q08q5p29pp@xreary.bet>

On September 22, 2026 11:54:36 AM PDT, Jiri Kosina <jikos@kernel.org> wrote:
>On Sat, 5 Sep 2026, Aditya Dash wrote:
>
>> Hi Derek,
>> 
>> The Stop reply changes based on calibration state. Its status appears to be
>> the current failure_mask + 1. However, this mask does not always match the
>> failure mask returned when calibration times out.
>> 
>> Here are some requests and responses from the experiments done:
>
>[ ... snip ... ]
>
>Derek,
>
>do you have any final followup / verdict on this series, please?
>
>Thanks,
>
Hi Jiri,

Thanks for the ping. I missed the last response.

Aditya,

Seems pretty inconsistent and I can't really see a pattern emerging. I'll look into this more later when I revisit the driver architecture with some other much needed fixes. For now I think just reporting success/fail like we have been is fine, we just need to make sure we're reading from the correct byte.

Thanks,
Derek


  reply	other threads:[~2026-09-22 21:25 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-01  6:36 [PATCH v3 0/7] HID: hid-lenovo-go: fix controller configuration Aditya Dash
2026-09-01  6:36 ` [PATCH v3 1/7] HID: hid-lenovo-go: use the correct calibration commands Aditya Dash
2026-09-01  6:36 ` [PATCH v3 2/7] HID: hid-lenovo-go: use the right controller selectors Aditya Dash
2026-09-01  6:36 ` [PATCH v3 3/7] HID: hid-lenovo-go: initialize command completion before hardware Aditya Dash
2026-09-01  6:36 ` [PATCH v3 4/7] HID: hid-lenovo-go: return configuration request errors Aditya Dash
2026-09-01  6:36 ` [PATCH v3 5/7] HID: hid-lenovo-go: normalize calibration failure status Aditya Dash
2026-09-01 15:57   ` Derek John Clark
2026-09-01 17:06     ` Aditya
2026-09-02 12:40       ` Derek J. Clark
2026-09-05  6:10         ` Aditya Dash
2026-09-22 18:54           ` Jiri Kosina
2026-09-22 21:25             ` Derek J. Clark [this message]
2026-09-23 21:14               ` Aditya Dash
2026-09-23 22:45                 ` Derek J. Clark
2026-09-01  6:36 ` [PATCH v3 6/7] HID: hid-lenovo-go: reject unknown calibration action Aditya Dash
2026-09-01  6:36 ` [PATCH v3 7/7] HID: hid-lenovo-go: clear calibration status on start Aditya Dash

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=836F1B09-60CA-4A82-8293-0F9CF506E593@gmail.com \
    --to=derekjohn.clark@gmail.com \
    --cc=bentiss@kernel.org \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpearson-lenovo@squebb.ca \
    --cc=mradityadash@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®