From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C37DA233954 for ; Tue, 30 Jun 2026 03:50:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782791407; cv=none; b=MeG/Qt8zMoDk+jkOnSxmXgoOAE6nP58WVJTr7igR+LCIUyCFLf7UDMt2lADE7TvxLh04P47mChOYSGOdUVjZ+0eX4QvZD52Psvy2Ayyza1zxZM9zYxNXrk68tHiy/xqsWpkF5bqiZpUaDf6iaO3tCzhF0RzZZ5KTzad/ClDes+k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782791407; c=relaxed/simple; bh=JvndTcbdQfQeO0UnijpOjRGRT/07a4Eg6ZYoroFiGBo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=UJ5zrvnAq4G5pHmVry1kyQOZ/ERNAuaSIsIQiQiZ0nehUrZf2E8atjNqciAN7juKUXS+zKaM7JGlfK1gPBjnSQ+Bv9vwGZYFHhPXnZ1t9QLygvcmPEW7xuy/n6jxoQ1dP8xGDnME0+9dQDr3+529wI9IEo9tlOevPzsmX/EUDfY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=laZqm1hP; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="laZqm1hP" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2c8c30492a0so33830995ad.2 for ; Mon, 29 Jun 2026 20:50:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782791404; x=1783396204; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=9jNn6l3C++B0B2TNE2QWEt8huvRiKl6q6nWK2b2vEJo=; b=laZqm1hPkItOWfi9zs+hKCr+qvAuSZrXwpEx826JGy17VjyoAe1hW5/WSrWn18Xa45 nQDfbrWP4Jtw5Ol5GYLuJSD10Ag132ycKqV13TfvgZWD7TmXvM75E42rTzr33nTtJTTn twE+L/94qwLif5jK2NWTGTz3UcppBdXR8YAM6rnwW2COTqaQoq8+Ej/Qq1uowDIIZkHx sPhryP3I9JwjLrkDogbVSJNAr8U5ftrvFA8dOCSpgXX/lQhxO5Ar/Bnx+DZzGQ3OOV09 AVD4zuSpyHz1jKJS9GQByyPKOSYSflrqwehjI7ZHF5xeGIvZjlRwUYtYySGEqUSgyffU Fg9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782791404; x=1783396204; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9jNn6l3C++B0B2TNE2QWEt8huvRiKl6q6nWK2b2vEJo=; b=MX1XTwSdCChsoZECHXwNr1+tudA7Q0/pSnJqtoebJVIV7wtNFw6eCdmuWiKpAnbHvf nrC68IXaoDnYiYjZQ4oRZhcjxm+N8SmmPE11aOGqQI+mLQPkJ2SQcCScwIXRw1wo/cl6 YsIOqMDKdm0SYYVhqN9dESa2Mwmwl9fSoTJVmDStVIF9YEMTnPrCp/vV0f6QJ9UwWz+7 qyeJZX1coK5AV3JF9zRLSg7z8vp9GANkuV2yvTvDpJyWRUE9kCFaRLFBosRu4VvB1W1g 29x3ftmZ1+YzyWaqG8rRXd4ivADmIjMx69dKq25By28qcITo9u0v3pDtzyHCYR5x3R56 F5lg== X-Forwarded-Encrypted: i=1; AHgh+RoBOWcUmy3agMXDywUQ8q5mfhxDZt4LC8T98K1ptenxvHLwCjL/J9bbME5iybGKe3Sd3W4pXuAUyCbKYa4=@vger.kernel.org X-Gm-Message-State: AOJu0YzfPJPmwgM98U/JRW3wKptHUA6K26oQPAOQuU+4eIUdFFvF8d2T YqAV4H27HkHFUeeLvLSKEVsxYRILs29F2wBv5ssniuwJqokO4BAYbrN5imdgNA== X-Gm-Gg: AfdE7cmJ1D2g9ht4QMLn25gclTqBVuJ7OnTSzMvJWmqLyiTvbQXMij51LuvSa4nH+rd +6T5VfUV0Tp++gztU42jcDEgv6jytYZOECVHsX/1+IrGR3FIyScVYxjlOnfZCGWy72DiHJgy3tn N9M3kre4Mogbtq1dT7bfnjk8H0Ji8aDVzivVVu/JpURb72GJKoOWE6n6cgEMBslnMC9YKTU7SZk YRtjUXYe7Q2pv3s7seiNw717dCNRiYjCon7X0dFiDtGfvjDLhX6qLo4j6q2hc/dydfTxYbNllpq TtYOn81eGBrTci4Xs+E9DlX5JtfwpMSZFWKWxBaSYl2D/nzVfrDQSjSIXQZOaHgDL4z4HDDFkbI igBcx83I6n55JWx4mvVJ1CPpje9awnJLm9C5i9hcb/Zmr+dGYruqL3HL0gfQYMXTfrFpIGnaUzx DKQ3l+lEhC/uCqm8G6uYcONM6L1/RF+3yfDHBkCly20eSarU5bfHIZsvkEtDHSdw== X-Received: by 2002:a17:902:f607:b0:2c9:97a7:3275 with SMTP id d9443c01a7336-2ca2ea334b3mr15260325ad.38.1782791403973; Mon, 29 Jun 2026 20:50:03 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:da43:aeff:fecc:bfd5? ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ca37c738easm4553965ad.20.2026.06.29.20.50.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Jun 2026 20:50:03 -0700 (PDT) Sender: Guenter Roeck Message-ID: <836b833e-e503-4cbb-92f7-3574f3fb430f@roeck-us.net> Date: Mon, 29 Jun 2026 20:50:02 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/6] hwmon: (pmbus/max20830): add support for enable GPIO To: Alexis Czezar Torreno , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jonathan Corbet , Shuah Khan Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org References: <20260630-dev-max20830c-v1-0-a02786bde470@analog.com> <20260630-dev-max20830c-v1-2-a02786bde470@analog.com> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAmgrMyQFCSbODQkACgkQyx8mb86fmYGcWRAA oRwrk7V8fULqnGGpBIjp7pvR187Yzx+lhMGUHuM5H56TFEqeVwCMLWB2x1YRolYbY4MEFlQg VUFcfeW0OknSr1s6wtrtQm0gdkolM8OcCL9ptTHOg1mmXa4YpW8QJiL0AVtbpE9BroeWGl9v 2TGILPm9mVp+GmMQgkNeCS7Jonq5f5pDUGumAMguWzMFEg+Imt9wr2YA7aGen7KPSqJeQPpj onPKhu7O/KJKkuC50ylxizHzmGx+IUSmOZxN950pZUFvVZH9CwhAAl+NYUtcF5ry/uSYG2U7 DCvpzqOryJRemKN63qt1bjF6cltsXwxjKOw6CvdjJYA3n6xCWLuJ6yk6CAy1Ukh545NhgBAs rGGVkl6TUBi0ixL3EF3RWLa9IMDcHN32r7OBhw6vbul8HqyTFZWY2ksTvlTl+qG3zV6AJuzT WdXmbcKN+TdhO5XlxVlbZoCm7ViBj1+PvIFQZCnLAhqSd/DJlhaq8fFXx1dCUPgQDcD+wo65 qulV/NijfU8bzFfEPgYP/3LP+BSAyFs33y/mdP8kbMxSCjnLEhimQMrSSo/To1Gxp5C97fw5 3m1CaMILGKCmfI1B8iA8zd8ib7t1Rg0qCwcAnvsM36SkrID32GfFbv873bNskJCHAISK3Xkz qo7IYZmjk/IJGbsiGzxUhvicwkgKE9r7a1rOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAmgrMyQFCSbODQkACgkQyx8mb86fmYHlgg/9 H5JeDmB4jsreE9Bn621wZk7NMzxy9STxiVKSh8Mq4pb+IDu1RU2iLyetCY1TiJlcxnE362kj njrfAdqyPteHM+LU59NtEbGwrfcXdQoh4XdMuPA5ADetPLma3YiRa3VsVkLwpnR7ilgwQw6u dycEaOxQ7LUXCs0JaGVVP25Z2hMkHBwx6BlW6EZLNgzGI2rswSZ7SKcsBd1IRHVf0miwIFYy j/UEfAFNW+tbtKPNn3xZTLs3quQN7GdYLh+J0XxITpBZaFOpwEKV+VS36pSLnNl0T5wm0E/y scPJ0OVY7ly5Vm1nnoH4licaU5Y1nSkFR/j2douI5P7Cj687WuNMC6CcFd6j72kRfxklOqXw zvy+2NEcXyziiLXp84130yxAKXfluax9sZhhrhKT6VrD45S6N3HxJpXQ/RY/EX35neH2/F7B RgSloce2+zWfpELyS1qRkCUTt1tlGV2p+y2BPfXzrHn2vxvbhEn1QpQ6t+85FKN8YEhJEygJ F0WaMvQMNrk9UAUziVcUkLU52NS9SXqpVg8vgrO0JKx97IXFPcNh0DWsSj/0Y8HO/RDkGXYn FDMj7fZSPKyPQPmEHg+W/KzxSSfdgWIHF2QaQ0b2q1wOSec4Rti52ohmNSY+KNIW/zODhugJ np3900V20aS7eD9K8GTU0TGC1pyz6IVJwIE= In-Reply-To: <20260630-dev-max20830c-v1-2-a02786bde470@analog.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 6/29/26 19:46, Alexis Czezar Torreno wrote: > Add support for the GPIO controlled EN pin. The EN pin is asserted high > for device to operate. > > Signed-off-by: Alexis Czezar Torreno > --- > drivers/hwmon/pmbus/max20830.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/hwmon/pmbus/max20830.c b/drivers/hwmon/pmbus/max20830.c > index cb2c23672166d641852199ca07eb716924f4f286..cb3a39d747edee3aefb0fb4051ef957436b3c15b 100644 > --- a/drivers/hwmon/pmbus/max20830.c > +++ b/drivers/hwmon/pmbus/max20830.c > @@ -6,6 +6,7 @@ > */ > > #include > +#include > #include > #include > #include > @@ -29,8 +30,14 @@ static struct pmbus_driver_info max20830_info = { > static int max20830_probe(struct i2c_client *client) > { > u8 buf[I2C_SMBUS_BLOCK_MAX + 1] = {}; > + struct gpio_desc *enable_gpio; > int ret; > > + enable_gpio = devm_gpiod_get_optional(&client->dev, "enable", GPIOD_OUT_HIGH); > + if (IS_ERR(enable_gpio)) > + return dev_err_probe(&client->dev, PTR_ERR(enable_gpio), > + "Failed to get enable GPIO\n"); > + The above code gets the gpio reference, and then it doesn't do anything with it. What exactly is the point of this exercise ? Where is the chip actually enabled ? Do you have an actual customer with such a set-up or is this "just in case" ? Have you tested this code to ensure that the chip is actually enabled in this setup ? If there is indeed a use case where a customer indeed connects the enable pin to a gpio output, wouldn't that same customer also want to connect the "pgood" output to a gpio pin ? And what about the LDOIN pin ? Shouldn't that be connected to a power supply ? Guenter