From: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
To: Mark Brown <broonie@kernel.org>
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
mohammad.rafi.shaik@oss.qualcomm.com,
linux-sound@vger.kernel.org, lgirdwood@gmail.com, perex@perex.cz,
tiwai@suse.com, johan@kernel.org,
dmitry.baryshkov@oss.qualcomm.com,
konrad.dybcio@oss.qualcomm.com, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
mailingradian@gmail.com
Subject: Re: [PATCH v5 13/13] ASoC: qcom: q6apm: Add support for early buffer mapping on DSP
Date: Wed, 18 Mar 2026 08:22:42 +0000 [thread overview]
Message-ID: <8370077d-ba1d-4924-87de-91b061c5c5ac@oss.qualcomm.com> (raw)
In-Reply-To: <a93db619-7539-46ac-b2c0-d4b42a0478a5@sirena.org.uk>
On 3/17/26 6:03 PM, Mark Brown wrote:
> On Mon, Mar 09, 2026 at 06:51:37AM +0000, Srinivas Kandagatla wrote:
>
>> +static void q6apm_dai_pcm_destruct(struct snd_soc_component *component, struct snd_pcm *pcm)
>> +{
>> + struct snd_pcm_substream *substream;
>> + struct snd_soc_pcm_runtime *soc_prtd;
>> + struct snd_soc_dai *cpu_dai;
>> + int graph_id;
>> +
>> + if (pcm->streams[SNDRV_PCM_STREAM_CAPTURE].substream)
>> + substream = pcm->streams[SNDRV_PCM_STREAM_PLAYBACK].substream;
>> + else
>> + substream = pcm->streams[SNDRV_PCM_STREAM_CAPTURE].substream;
>
> This looks weird, we're destructing the playback substream if the
> capture one is present and the capture stream otherwise? If that's
> correct the logic is very non-obvious, especially in the case where the
> capture stream isn't presenta and...
Looks like this is a typo in the patch it should be
if (pcm->streams[SNDRV_PCM_STREAM_CAPTURE].substream)
substream = pcm->streams[SNDRV_PCM_STREAM_CAPTURE].substream;
else
substream = pcm->streams[SNDRV_PCM_STREAM_PLAYBACK].substream;
will fix this in next spin, along with converting the destruct to pcm_free
--srini
>
>> + soc_prtd = snd_soc_substream_to_rtd(substream);
>> + cpu_dai = snd_soc_rtd_to_cpu(soc_prtd, 0);
>
> ...we immediately try convert it into a runtime and CPU DAI?
prev parent reply other threads:[~2026-03-18 8:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-09 6:51 [PATCH v5 00/13] SoC: qcom: q6dsp: few fixes and enhancements Srinivas Kandagatla
2026-03-09 6:51 ` [PATCH v5 01/13] ASoC: qcom: q6apm: move component registration to unmanaged version Srinivas Kandagatla
2026-03-09 6:51 ` [PATCH v5 02/13] ASoC: qcom: q6apm: remove child devices when apm is removed Srinivas Kandagatla
2026-03-09 6:51 ` [PATCH v5 03/13] ASoC: qcom: qdsp6: topology: check widget type before accessing data Srinivas Kandagatla
2026-03-09 6:51 ` [PATCH v5 04/13] ASoC: qcom: q6apm-lpass-dai: Fix multiple graph opens Srinivas Kandagatla
2026-03-09 6:51 ` [PATCH v5 05/13] ASoC: qcom: q6apm-dai: reset queue ptr on trigger stop Srinivas Kandagatla
2026-03-09 6:51 ` [PATCH v5 06/13] ASoC: dt-bindings: qcom: add LPASS LPI MI2S dai ids Srinivas Kandagatla
2026-03-10 7:44 ` Krzysztof Kozlowski
2026-03-09 6:51 ` [PATCH v5 07/13] ASoC: qcom: qdsp6: lpass-ports: add support for LPASS LPI MI2S dais Srinivas Kandagatla
2026-03-09 6:51 ` [PATCH v5 08/13] ASoC: qcom: q6dsp: Add Senary MI2S audio interface support Srinivas Kandagatla
2026-03-19 5:17 ` Val Packett
2026-03-20 12:34 ` Srinivas Kandagatla
2026-03-09 6:51 ` [PATCH v5 09/13] ASoC: qcom: common: validate cpu dai id during parsing Srinivas Kandagatla
2026-03-09 6:51 ` [PATCH v5 10/13] ASoC: qcom: qdapm-lpass-dai: correct the error message Srinivas Kandagatla
2026-03-09 6:51 ` [PATCH v5 11/13] ASoC: qcom: q6apm-lpass-dai: move graph start to trigger Srinivas Kandagatla
2026-03-09 6:51 ` [PATCH v5 12/13] ASoC: qcom: qdsp6: remove search for module iid in hot path Srinivas Kandagatla
2026-03-09 6:51 ` [PATCH v5 13/13] ASoC: qcom: q6apm: Add support for early buffer mapping on DSP Srinivas Kandagatla
2026-03-17 18:03 ` Mark Brown
2026-03-18 8:22 ` Srinivas Kandagatla [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8370077d-ba1d-4924-87de-91b061c5c5ac@oss.qualcomm.com \
--to=srinivas.kandagatla@oss.qualcomm.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=johan@kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=mailingradian@gmail.com \
--cc=mohammad.rafi.shaik@oss.qualcomm.com \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®