From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A673B1DD9AD for ; Mon, 7 Oct 2024 18:54:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728327248; cv=none; b=nH5zqvJ9H488cJKN1bZtaqOOnb4wb8CMPMIHipg/yTj5yLbn1KayuWBe2xZXh4PSxuGOihkVCuQHLm38gzYcmdsdOcOJC1EPWsJGKtf65b1LhD2MxL4hPFTfJpkckwQNqR/Te1f7wMcvRPXkg566J1fGNrX4KptM5USaLk0ZHq0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728327248; c=relaxed/simple; bh=hnTBwamPDAsTLDF+Js1D5YUZ3/8QsfQbBw6PXRBHvlw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RMWao7MkHGHozJE1y1cl/hE36cZWorW//fiW7n9SBbhGPO1v+6ccdAr9ylleIxqR0uIAF0NUe6VRqix9dMJSdpcr7ye1coTGUX5hGmMYFVCjSvNSgvz12NNRn9gu3c8opHXrQSF2PCaoUDx+cbYz3xMXUBxI9lYOcQJz0GJ9lsE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=b66dAsxT; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="b66dAsxT" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728327244; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TXl/fSOrjemj+ajnFjFM4CSMF/fXgBTJBQOb6whFU1E=; b=b66dAsxTTZQYW6SCSUHKilVUrLSbRtFCt7TYcuc+BcbKccz7u8wk65fzxX9Rgq3wncpkCK ygLnlkydYaYELag6+M6RG8bjMNyvu8kZshvdal4Keu7CNlEkpxsUm/Xf7Yw/LNcHZ70U4J nWBixa2FHUfigboTdVSvISsnnkeP8UU= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-640-VIYZPeBzM-KdQ80MpRt3Xg-1; Mon, 07 Oct 2024 14:54:03 -0400 X-MC-Unique: VIYZPeBzM-KdQ80MpRt3Xg-1 Received: by mail-ed1-f70.google.com with SMTP id 4fb4d7f45d1cf-5c8838677c0so4509807a12.0 for ; Mon, 07 Oct 2024 11:54:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728327242; x=1728932042; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TXl/fSOrjemj+ajnFjFM4CSMF/fXgBTJBQOb6whFU1E=; b=hwyc2M3fYe+nYffLH0tYGzd/MT8MQx4v/p/Rl+7ClgCW15Xt0oKDlXzd2sbV6oaTDI u/tnje6H/gzsXQNZpQi0ONuOkifD1YSRBy/hyUeFQxpLpoMo+xl25650YSCkvyc8K4iy 261k3R6uWxGMBzcAFnBZ0N8yxK1F6lkeksjKBVuaeeZNNNnEOWCvdw1JZYiwMzOlwIBg gcYnm7JBOYQ1p0SGulHcbBALaOJLYhwyU2479mUZfOAsOLSkSWk8sGOdRAfeTHxSmoHd 3R43bPexOp5EDZAT5sYJTuoBTSbWum61nDbUuAC4VeOFc3PkDFo8gq/RX9fppblhuJSO 1jlA== X-Forwarded-Encrypted: i=1; AJvYcCW3AtPFhtWM3xMU00c4RYpdJ5314CtRedo/H6nHFmDSsVrE8BrsANKFJg38c7m/7aI7ZOxo0pr/VYtQRXo=@vger.kernel.org X-Gm-Message-State: AOJu0YzmdA5pQzPyZZyPtYydB1CArZyuPhKHaPYae4Z3hoqTQgB8TCAj YLuQ2gOu76rChQR5IxB4h/5Fgnu0YPvC+fS60PRF3OfpJylxMvHpNFjffz/CQMWu55y3LJXbAkG tFrZY8kg7JxoHl6NsNRzVcttsq9KdG6JeBBhCVGR7bCTtOXekbKbh7DCEIYS71Q== X-Received: by 2002:a05:6402:35d1:b0:5c9:3f2:e69c with SMTP id 4fb4d7f45d1cf-5c903f2ea42mr1122641a12.9.1728327242262; Mon, 07 Oct 2024 11:54:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGtc/wASbpmCC3oX4yHn0opV5qAfwjsWz7nSRdYzab2WVqdaotFQbRwUdiaixLyJyahsBAPsA== X-Received: by 2002:a05:6402:35d1:b0:5c9:3f2:e69c with SMTP id 4fb4d7f45d1cf-5c903f2ea42mr1122594a12.9.1728327241693; Mon, 07 Oct 2024 11:54:01 -0700 (PDT) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c8e05ecda3sm3473540a12.73.2024.10.07.11.53.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Oct 2024 11:54:00 -0700 (PDT) Message-ID: <8370d062-b3d2-46f5-9e7b-8e16edde8480@redhat.com> Date: Mon, 7 Oct 2024 20:53:59 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/5] platform/surface: aggregator_registry: Add Surface Pro 9 5G To: =?UTF-8?Q?J=C3=A9r=C3=B4me_de_Bretagne?= , Maximilian Luz , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Johan Hovold , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org References: <20240908223505.21011-1-jerome.debretagne@gmail.com> <20240908223505.21011-4-jerome.debretagne@gmail.com> Content-Language: en-US, nl From: Hans de Goede In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi Jérôme, On 7-Oct-24 8:44 PM, Jérôme de Bretagne wrote: > Hi, > > I'm replying with Hans and Ilpo, who I initially forgot for this > patch, sorry about that. No worries thank you for forwarding Maximilian's review. > Le mar. 10 sept. 2024 à 23:29, Maximilian Luz > a écrit : >> >> Looks good. Two very small nit-picks below, if this goes for a v3: > > Atm I'm not planning for a v3 as Bjorn has applied the other v2 > patches earlier today. > Feel free to include the 2 small suggestions when applying this patch maybe? > >> On 9/9/24 12:35 AM, Jérôme de Bretagne wrote: >>> Add SAM client device nodes for the Surface Pro 9 5G, with the usual >>> battery/AC and HID nodes for keyboard and touchpad support. >>> >>> Signed-off-by: Jérôme de Bretagne >>> --- >>> .../surface/surface_aggregator_registry.c | 17 +++++++++++++++++ >>> 1 file changed, 17 insertions(+) >>> >>> diff --git a/drivers/platform/surface/surface_aggregator_registry.c b/drivers/platform/surface/surface_aggregator_registry.c >>> index 25c8aa2131d6..8b34d7e465c2 100644 >>> --- a/drivers/platform/surface/surface_aggregator_registry.c >>> +++ b/drivers/platform/surface/surface_aggregator_registry.c >>> @@ -390,6 +390,21 @@ static const struct software_node *ssam_node_group_sp9[] = { >>> NULL, >>> }; >>> >>> +/* Devices for Surface Pro 9 5G. */ >> >> Would be nice if you could change the comment on the SP9 node group to >> "Surface Pro 9 (Intel/x86)" and the comment here to "Surface Pro 9 5G >> (ARM/QCOM)" or something along those lines to make things a bit more >> clear. >> >>> +static const struct software_node *ssam_node_group_sp9_5G[] = { >> >> (This is really just me being a bit obsessive:) It would be nice to have >> all-lowercase variable names (regarding the 5G). > > :) > >>> + &ssam_node_root, >>> + &ssam_node_hub_kip, >>> + &ssam_node_bat_ac, >>> + &ssam_node_bat_main, >>> + &ssam_node_tmp_sensors, >>> + &ssam_node_hid_kip_keyboard, >>> + &ssam_node_hid_kip_penstash, >>> + &ssam_node_hid_kip_touchpad, >>> + &ssam_node_hid_kip_fwupd, >>> + &ssam_node_hid_sam_sensors, >>> + &ssam_node_kip_tablet_switch, >>> + NULL, >>> +}; >>> >>> /* -- SSAM platform/meta-hub driver. ---------------------------------------- */ >>> >>> @@ -462,6 +477,8 @@ static const struct acpi_device_id ssam_platform_hub_acpi_match[] = { >>> MODULE_DEVICE_TABLE(acpi, ssam_platform_hub_acpi_match); >>> >>> static const struct of_device_id ssam_platform_hub_of_match[] __maybe_unused = { >>> + /* Surface Pro 9 5G */ >>> + { .compatible = "microsoft,arcata", (void *)ssam_node_group_sp9_5G }, >>> /* Surface Laptop 7 */ >>> { .compatible = "microsoft,romulus13", (void *)ssam_node_group_sl7 }, >>> { .compatible = "microsoft,romulus15", (void *)ssam_node_group_sl7 }, >> >> Thanks! >> >> Reviewed-by: Maximilian Luz > > Thanks for your review and all the work about SSAM for Surface owners! FWIW I agree with Maximilian's remarks and I would really like to see these applied to clearly differentiate the x86 and ARM versions. Normally I would pick up a patch like this which just adds hw-ids as a fix for 6.12-rc# and squash in the suggested changes. But looking at the test of the series this is more 6.13 material since the rest is landing in 6.13, right ? Patches for linux-next / 6.13 are managed by Ilpo this cycle. So I'll leave it up to Ilpo if he will squash in the suggested changes or if he wants a new version (of just this patch, no need for a v3 of the already applied patches). Regards, Hans