From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EDBF7267386 for ; Wed, 9 Apr 2025 14:49:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744210188; cv=none; b=k+kWEJzXTFzU3RCelc0wczlcLs8tHdvaJMiD0PMuYGpW390f2FYV07qGvg1GIVkxXRX/G4+asJk1irs+/vmwq8HYiOwmDSxLi6L6iSWLn6lgJZ2unWjedLwTqXS/bNyr3KpJ7LckGh9aGa5R2Q4Tl7sfQ/8in7/8F+GD2gqwL0c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744210188; c=relaxed/simple; bh=85+UIcf1eKLU/wNzZgNVq10Yo7Ip9fEDwLj2BK/wH0Q=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FZzy0UPBbUygBzFab3iv0TN6hW+6blElu2cFUk/Zm7LO1Po6uZeCLeaOt5g2JGtu9Lt9HgHH5fooOGN/KQTCypIlnLw+i3yh3JkDkel7NMO0A2REQzJ05q9cBPsPe3z2WV/SEh1Mj9RtXG/VynxGa4LVSiwNsh3LseKiE1puYxs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=PAwKdEvj; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="PAwKdEvj" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 53983U0H004584 for ; Wed, 9 Apr 2025 14:49:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= NAji33sbWftR/X6dZ2NUeyfjXLgktdVt707HtkxaLX0=; b=PAwKdEvjtewbtaba 2V2qQjPJwGOamRfReF4UgYHmeMQPWAMYT6bC8e2TsfZzNn5hpIluqBIcCB2VD5gc oIcllz4ev5MxKTTUAPQFCQpXLI0okxFDYPb+0hqeu2guc4fWqE4WpMVWiqA6TDkm 1Nu7jGCBtZabRfZRQHgLGTpe+6bNB7hC04kvxNiG7Z9fPjZTYfFWlXM+fBE5DMk5 I2kHcg/lPeC1cHyJgoYwIdpDZgC0VDBBsw/tRTNrxw3Z0Zex0SaxodPfbAQHR5hd xUSYZLu71lvANyR44l+aMLnRsMs7iprErdrR2G9V117gWTJx0e8Eh89vuI4XbtaV qqfsaQ== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 45twtb3teh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 09 Apr 2025 14:49:45 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-7c54734292aso162256885a.2 for ; Wed, 09 Apr 2025 07:49:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744210184; x=1744814984; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NAji33sbWftR/X6dZ2NUeyfjXLgktdVt707HtkxaLX0=; b=XIHSNAHvmt1swRBhKmciBkzfFJRkvRGnGRnWZyylMmT1o5XN4HvnRwO6J+VW5pG52W XsWxhNx3ASZIBceuzO083Od+qlXhTqUtTU8qXHpYKipet5mycbm+R8N8d8bxWBIiSFry dSsM7zj6teq/MTpl3WzhoswW50H32jWDVicNC0YJCYSz8YKJv+nhFTy4sgUsbKpLbLON uSjIIVZbWvXJJ24N5zbINHHosB8WBn7J00dcraxaKx3/pHHhkmWsGgC6ZSIkgXYkuCV3 cTlH5Mpa7BCTf+RvEV8HuxwqrFRl9dnILOrlKinT3SAiODegt9j7B8/JjjQc3VoM93Y5 ox1A== X-Forwarded-Encrypted: i=1; AJvYcCWiKvSj5AI0ftGzL8wNHzxcWVYiKMuNj3fLcJOjih25avPfGpn9m1vOmMF7UP/Cj2jnf67fUam7iCfoB6w=@vger.kernel.org X-Gm-Message-State: AOJu0YwrmxWTEKw8a6EVUUITtd1+efHr5+kb+kqS68A0qYkCleecD1VC NF3L1CsDFv1tDfuL/4zhicUYdLkjdqVbkjlOc/5WRxraJyu54JRDOYkHzTjSpLfrbgeZbnLbVmC /NBf73QoSAcWmxt0mqyhA6Ctxh5vs8APc9LWoIHlWZQEF5OTEqGH/aYUlCmSl8so= X-Gm-Gg: ASbGncv5GOOkQTmElh15CcAIvjPBcEvxnLVnM/vnxdAwxvbW+ao0KYvtpogUY9PZQOH aeb/oh6amjS8o74FJDhsKWN85y2eMudFA+W+LDKdsouEcIuL9ZJ/mgWetT+skeOpl0lsaOSty/f W14K1K306NUTi09v/RJk68dpEZnf4wi6NjUaPBwWs+cQSu4RZcyZHZQDdl7pIFmaAPz3gB3qIXG PMnGL/Foszew8aIkinyH3XOZMOVQyUyI7crvbrnI1rXFmo8IYbn/KANYyJp4o8j9bzTCqd4m33h 6Rgz6oWpJJuq7fI66e+L726o+5A6M5ruEIUmB0EMOpZxTNtkPZd6HumcdabetfiW4Q== X-Received: by 2002:a05:620a:1792:b0:7c3:c9d4:95e3 with SMTP id af79cd13be357-7c79cc382dcmr170872085a.10.1744210184449; Wed, 09 Apr 2025 07:49:44 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFMm5nWNQB+SUuTMx8XfwA9o0yrLRkaTZP7ACAR3JyVEdTKjbhOMoZD8lRtbWW3IF+TISiTyg== X-Received: by 2002:a05:620a:1792:b0:7c3:c9d4:95e3 with SMTP id af79cd13be357-7c79cc382dcmr170869385a.10.1744210183947; Wed, 09 Apr 2025 07:49:43 -0700 (PDT) Received: from [192.168.65.90] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-acaa1ccd205sm108975966b.141.2025.04.09.07.49.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Apr 2025 07:49:43 -0700 (PDT) Message-ID: <83713b15-d74d-4620-b9a0-9c57f216c6bc@oss.qualcomm.com> Date: Wed, 9 Apr 2025 16:49:40 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 01/10] dt-bindings: PCI: Add binding for Toshiba TC956x PCIe switch To: Konrad Dybcio , Krishna Chaitanya Chundru , Krzysztof Kozlowski Cc: Bjorn Helgaas , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Krzysztof Kozlowski , Conor Dooley , chaitanya chundru , Bjorn Andersson , Konrad Dybcio , cros-qcom-dts-watchers@chromium.org, Jingoo Han , Bartosz Golaszewski , quic_vbadigan@quicnic.com, amitk@kernel.org, dmitry.baryshkov@linaro.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, jorge.ramirez@oss.qualcomm.com References: <20250225-qps615_v4_1-v4-0-e08633a7bdf8@oss.qualcomm.com> <20250225-qps615_v4_1-v4-1-e08633a7bdf8@oss.qualcomm.com> <20250226-eager-urchin-of-performance-b71ae4@krzk-bin> <8e301a7b-c475-4642-bf91-7a5176a00d1f@oss.qualcomm.com> <385c7c77-0cb7-f899-4934-dfa58328235a@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: nCux4Qoy7n1tQPGSpKBWbdohmDxKnHMY X-Authority-Analysis: v=2.4 cv=LLlmQIW9 c=1 sm=1 tr=0 ts=67f6890a cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=XR8D0OoHHMoA:10 a=COk6AnOGAAAA:8 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=3h54kFN3o8ui-8ShBWYA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-ORIG-GUID: nCux4Qoy7n1tQPGSpKBWbdohmDxKnHMY X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-09_05,2025-04-08_04,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 bulkscore=0 clxscore=1015 mlxlogscore=999 malwarescore=0 phishscore=0 lowpriorityscore=0 priorityscore=1501 mlxscore=0 spamscore=0 adultscore=0 suspectscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2504090093 On 4/9/25 3:22 PM, Konrad Dybcio wrote: > On 4/1/25 7:52 AM, Krishna Chaitanya Chundru wrote: >> >> >> On 3/25/2025 7:26 PM, Konrad Dybcio wrote: >>> On 2/26/25 8:30 AM, Krzysztof Kozlowski wrote: >>>> On Tue, Feb 25, 2025 at 03:03:58PM +0530, Krishna Chaitanya Chundru wrote: >>>>> From: Krishna chaitanya chundru >>>>> >>>>> Add a device tree binding for the Toshiba TC956x PCIe switch, which >>>>> provides an Ethernet MAC integrated to the 3rd downstream port and two >>>>> downstream PCIe ports. >>>>> >>>>> Signed-off-by: Krishna chaitanya chundru >>>>> Reviewed-by: Bjorn Andersson >>>> >>>> Drop, file was named entirely different. I see other changes, altough >>>> comparing with b4 is impossible. >>>> >>>> Why b4 does not work for this patch? >>>> >>>>    b4 diff '20250225-qps615_v4_1-v4-1-e08633a7bdf8@oss.qualcomm.com' >>>>    Checking for older revisions >>>>    Grabbing search results from lore.kernel.org >>>>    Nothing matching that query. >>>> >>>> Looks like you use b4 but decide to not use b4 changesets/versions. Why >>>> making it difficult for reviewers and for yourself? >>>> >>>> >>>>> --- >>>>>   .../devicetree/bindings/pci/toshiba,tc956x.yaml    | 178 +++++++++++++++++++++ >>>>>   1 file changed, 178 insertions(+) >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/pci/toshiba,tc956x.yaml b/Documentation/devicetree/bindings/pci/toshiba,tc956x.yaml >>>>> new file mode 100644 >>>>> index 000000000000..ffed23004f0d >>>>> --- /dev/null >>>>> +++ b/Documentation/devicetree/bindings/pci/toshiba,tc956x.yaml >>>> >>>> What is "x" here? Wildcard? >>> >>> Yes, an overly broad one. Let's use the actual name going forward. >>> >> ok I will update the next series the name from tc956x to tc9563 as >> suggested. > > As per internal discussions, 956*4* would be the correct name for this one I misread. It's supposed to be 3. Sorry for the confusion. Konrad