From: Coly Li <colyli@suse.de>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Kent Overstreet <kent.overstreet@gmail.com>,
y2038 Mailman List <y2038@lists.linaro.org>,
Jens Axboe <axboe@kernel.dk>, Michael Lyle <mlyle@lyle.org>,
Tang Junhui <tang.junhui@zte.com.cn>,
Hannes Reinecke <hare@suse.com>,
linux-bcache@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] [v2] bcache: stop using the deprecated get_seconds()
Date: Fri, 13 Jul 2018 23:34:55 +0800 [thread overview]
Message-ID: <83724892-de0f-40ff-e16a-792a90d77ff1@suse.de> (raw)
In-Reply-To: <CAK8P3a3FULT7uakRyZ4Nfq3E-ij+Gkn06=XP4Rn2m9u4Wd2OWA@mail.gmail.com>
On 2018/7/13 10:20 PM, Arnd Bergmann wrote:
> On Sat, Jun 23, 2018 at 10:12 AM, Coly Li <colyli@suse.de> wrote:
>> On 2018/6/22 9:48 PM, Arnd Bergmann wrote:
>>> The get_seconds function is deprecated now since it returns a 32-bit
>>> value that will eventually overflow, and we are replacing it throughout
>>> the kernel with ktime_get_seconds() or ktime_get_real_seconds() that
>>> return a time64_t.
>>>
>>> bcache uses get_seconds() to read the current system time and store it in
>>> the superblock as well as in uuid_entry structures that are user visible.
>>>
>>> Unfortunately, the two structures in are still limited to 32 bits, so this
>>> won't fix any real problems but will still overflow in year 2106. Let's
>>> at least document that properly, in case we get an updated format in the
>>> future it can be fixed. We still have a long time before the overflow
>>> and checking the tools at https://github.com/koverstreet/bcache-tools
>>> reveals no access to any of them.
>>>
>>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>>
>> Added to 4.19 for-next.
>
> I noticed this isn't part of linux-next (yet). Did it get dropped?
>
> Arnd
>
Hi Arnd,
It is here,
https://git.kernel.org/pub/scm/linux/kernel/git/colyli/bcache-patches.git/tree/for-next/0004-bcache-stop-using-the-deprecated-get_seconds.patch
It is for Linux v4.19, the merge window is not available yet, and I
don't post them to Jens yet.
Thanks.
Coly Li
next prev parent reply other threads:[~2018-07-13 15:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-22 13:48 Arnd Bergmann
2018-06-23 8:12 ` Coly Li
2018-07-13 14:20 ` Arnd Bergmann
2018-07-13 15:34 ` Coly Li [this message]
2018-07-13 18:57 ` Arnd Bergmann
2018-07-13 19:38 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83724892-de0f-40ff-e16a-792a90d77ff1@suse.de \
--to=colyli@suse.de \
--cc=arnd@arndb.de \
--cc=axboe@kernel.dk \
--cc=hare@suse.com \
--cc=kent.overstreet@gmail.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mlyle@lyle.org \
--cc=tang.junhui@zte.com.cn \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome