From: Quentin Monnet <qmo@kernel.org>
To: Daniel Xu <dxu@dxuuu.xyz>,
andrii@kernel.org, ast@kernel.org, daniel@iogearbox.net
Cc: martin.lau@linux.dev, eddyz87@gmail.com, song@kernel.org,
yonghong.song@linux.dev, john.fastabend@gmail.com,
kpsingh@kernel.org, sdf@fomichev.me, haoluo@google.com,
jolsa@kernel.org, bpf@vger.kernel.org,
linux-kernel@vger.kernel.org, andrii.nakryiko@gmail.com,
antony@phenome.org, toke@kernel.org
Subject: Re: [PATCH bpf-next v4 4/4] bpftool: bash: Add bash completion for root_id argument
Date: Fri, 13 Dec 2024 15:17:57 +0000 [thread overview]
Message-ID: <8372554b-0d4d-4f65-b000-a1a6c00d80ab@kernel.org> (raw)
In-Reply-To: <7aa45a2c19ac50b72be1921e0d94f9bc77c97896.1734052995.git.dxu@dxuuu.xyz>
2024-12-12 18:24 UTC-0700 ~ Daniel Xu <dxu@dxuuu.xyz>
> This commit updates the bash completion script with the new root_id
> argument.
>
> Signed-off-by: Daniel Xu <dxu@dxuuu.xyz>
> ---
> tools/bpf/bpftool/bash-completion/bpftool | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/tools/bpf/bpftool/bash-completion/bpftool b/tools/bpf/bpftool/bash-completion/bpftool
> index 0c541498c301..097d406ee21f 100644
> --- a/tools/bpf/bpftool/bash-completion/bpftool
> +++ b/tools/bpf/bpftool/bash-completion/bpftool
> @@ -930,6 +930,9 @@ _bpftool()
> format)
> COMPREPLY=( $( compgen -W "c raw" -- "$cur" ) )
> ;;
> + root_id)
> + return 0;
> + ;;
> c)
> COMPREPLY=( $( compgen -W "unsorted" -- "$cur" ) )
> ;;
> @@ -937,13 +940,13 @@ _bpftool()
> # emit extra options
> case ${words[3]} in
> id|file)
> - _bpftool_once_attr 'format'
> + _bpftool_once_attr 'format root_id'
> ;;
> map|prog)
> if [[ ${words[3]} == "map" ]] && [[ $cword == 6 ]]; then
> COMPREPLY+=( $( compgen -W "key value kv all" -- "$cur" ) )
> fi
> - _bpftool_once_attr 'format'
> + _bpftool_once_attr 'format root_id'
> ;;
> *)
> ;;
Thanks! If we support multiple occurrences for root_id, let's adjust the
completion (and also complete with root_id after "format c", by the way,
I missed it last time):
------
diff --git a/tools/bpf/bpftool/bash-completion/bpftool b/tools/bpf/bpftool/bash-completion/bpftool
index 0c541498c301..e5bf809656ed 100644
--- a/tools/bpf/bpftool/bash-completion/bpftool
+++ b/tools/bpf/bpftool/bash-completion/bpftool
@@ -930,19 +930,24 @@ _bpftool()
format)
COMPREPLY=( $( compgen -W "c raw" -- "$cur" ) )
;;
+ root_id)
+ return 0
+ ;;
c)
- COMPREPLY=( $( compgen -W "unsorted" -- "$cur" ) )
+ COMPREPLY=( $( compgen -W "unsorted root_id" -- "$cur" ) )
;;
*)
# emit extra options
case ${words[3]} in
id|file)
+ COMPREPLY=( $( compgen -W "root_id" -- "$cur" ) )
_bpftool_once_attr 'format'
;;
map|prog)
if [[ ${words[3]} == "map" ]] && [[ $cword == 6 ]]; then
COMPREPLY+=( $( compgen -W "key value kv all" -- "$cur" ) )
fi
+ COMPREPLY=( $( compgen -W "root_id" -- "$cur" ) )
_bpftool_once_attr 'format'
;;
*)
------
prev parent reply other threads:[~2024-12-13 15:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-13 1:24 [PATCH bpf-next v4 0/4] bpftool: btf: Support dumping a single type from file Daniel Xu
2024-12-13 1:24 ` [PATCH bpf-next v4 1/4] bpftool: man: Add missing format argument to command description Daniel Xu
2024-12-13 15:15 ` Quentin Monnet
2024-12-13 1:24 ` [PATCH bpf-next v4 2/4] bpftool: btf: Validate root_type_ids early Daniel Xu
2024-12-13 15:15 ` Quentin Monnet
2024-12-13 1:24 ` [PATCH bpf-next v4 3/4] bpftool: btf: Support dumping a specific types from file Daniel Xu
2024-12-13 15:17 ` Quentin Monnet
2024-12-13 16:45 ` Daniel Xu
2024-12-13 16:55 ` Quentin Monnet
2024-12-13 18:01 ` Daniel Xu
2024-12-13 1:24 ` [PATCH bpf-next v4 4/4] bpftool: bash: Add bash completion for root_id argument Daniel Xu
2024-12-13 15:17 ` Quentin Monnet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8372554b-0d4d-4f65-b000-a1a6c00d80ab@kernel.org \
--to=qmo@kernel.org \
--cc=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=antony@phenome.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=dxu@dxuuu.xyz \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=sdf@fomichev.me \
--cc=song@kernel.org \
--cc=toke@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®