From: Kyle Moffett <mrmacman_g4@mac.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Andrew Morton <akpm@osdl.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>, Andi Kleen <ak@suse.de>,
linux-kernel@vger.kernel.org,
Russell King <rmk+lkml@arm.linux.org.uk>,
Jakub Jelinek <jakub@redhat.com>, Mike Galbraith <efault@gmx.de>,
Albert Cahalan <acahalan@gmail.com>,
Bill Nottingham <notting@redhat.com>,
Marco Roeland <marco.roeland@xs4all.nl>,
Linus Torvalds <torvalds@osdl.org>
Subject: Re: [RFD][PATCH 2/2] sysctl: Implement CTL_UNNUMBERED
Date: Mon, 23 Oct 2006 06:28:15 -0400 [thread overview]
Message-ID: <837CA6CF-DA35-4AAF-8F92-0912B7D3166D@mac.com> (raw)
In-Reply-To: <m1y7r7wl2e.fsf@ebiederm.dsl.xmission.com>
On Oct 23, 2006, at 03:25:13, Eric W. Biederman wrote:
> --- a/fs/lockd/svc.c
> -/* Something that isn't CTL_ANY, CTL_NONE or a value that may
> clash. */
> -#define CTL_UNNUMBERED -2
> -
> --- a/fs/nfs/sysctl.c
> -/*
> - * Something that isn't CTL_ANY, CTL_NONE or a value that may clash.
> - * Use the same values as fs/lockd/svc.c
> - */
> -#define CTL_UNNUMBERED -2
> +++ b/include/linux/sysctl.h
> #ifdef __KERNEL__
> #define CTL_ANY -1 /* Matches any name */
> #define CTL_NONE 0
> +#define CTL_UNNUMBERED CTL_NONE /* sysctl without a binary number */
> #endif
This change looks totally broken. Before this patch, CTL_UNNUMBERED
== -2, a number that isn't CTL_ANY, CTL_NONE, or a valid sysctl
number. After this patch, CTL_UNNUMBERED == 0, or CTL_NONE.
Cheers,
Kyle Moffett
next prev parent reply other threads:[~2006-10-23 10:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-23 7:22 [RFD][PATCH 1/2] sysctl: Allow a zero ctl_name in the middle of a sysctl table Eric W. Biederman
2006-10-23 7:25 ` [RFD][PATCH 2/2] sysctl: Implement CTL_UNNUMBERED Eric W. Biederman
2006-10-23 10:28 ` Kyle Moffett [this message]
2006-10-23 15:12 ` Eric W. Biederman
2006-10-23 21:15 ` Andi Kleen
2006-10-23 10:08 ` [RFD][PATCH 1/2] sysctl: Allow a zero ctl_name in the middle of a sysctl table Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=837CA6CF-DA35-4AAF-8F92-0912B7D3166D@mac.com \
--to=mrmacman_g4@mac.com \
--cc=acahalan@gmail.com \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=ebiederm@xmission.com \
--cc=efault@gmx.de \
--cc=jakub@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marco.roeland@xs4all.nl \
--cc=notting@redhat.com \
--cc=rmk+lkml@arm.linux.org.uk \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®