From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08FEEC433EF for ; Mon, 4 Apr 2022 09:51:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354852AbiDDJxE (ORCPT ); Mon, 4 Apr 2022 05:53:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354905AbiDDJw7 (ORCPT ); Mon, 4 Apr 2022 05:52:59 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 2F73E3AA4F for ; Mon, 4 Apr 2022 02:51:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1649065862; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eNn7OZer9rTtvos0scrbqStJB9ITAkgBId/kZt8wGqU=; b=KP3YKE+X6s+o4hx4YVAqrd2uKLKocCYhyRmF62N4Zhc2N5964wRjRpo7CCWtTZ4Tv5y7jL k11tuPrn80bfoybUhFj0pMRzoehyxbnhRIv3Itll9xRD1yIry8iLuJxHtWiQ1zAbRVGdxd Btb93m2MSnQLmjbyqGKIthWr1n6hPvg= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-138-dALdLs2bMXycxz_RvAqKcg-1; Mon, 04 Apr 2022 05:50:57 -0400 X-MC-Unique: dALdLs2bMXycxz_RvAqKcg-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7FEE4811E83; Mon, 4 Apr 2022 09:50:56 +0000 (UTC) Received: from starship (unknown [10.40.194.231]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5A1E95745E0; Mon, 4 Apr 2022 09:50:53 +0000 (UTC) Message-ID: <837ad042dcbfc699c54434e9ed473e3b409546b0.camel@redhat.com> Subject: Re: [PATCH 2/5] KVM: SVM: Downgrade BUG_ON() to WARN_ON() in svm_inject_irq() From: Maxim Levitsky To: "Maciej S. Szmigiero" , Paolo Bonzini Cc: Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Tom Lendacky , Brijesh Singh , Jon Grimm , David Kaplan , Boris Ostrovsky , Liam Merwick , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 04 Apr 2022 12:50:52 +0300 In-Reply-To: <3f8422d9185477148e53440a4c6d66acbf387f65.1646944472.git.maciej.szmigiero@oracle.com> References: <3f8422d9185477148e53440a4c6d66acbf387f65.1646944472.git.maciej.szmigiero@oracle.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 (3.36.5-2.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2022-03-10 at 22:38 +0100, Maciej S. Szmigiero wrote: > From: "Maciej S. Szmigiero" > > There is no need to bring down the whole host just because there might be > some issue with respect to guest GIF handling in KVM. > > Signed-off-by: Maciej S. Szmigiero > --- > arch/x86/kvm/svm/svm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c > index b069493ad5c7..1e5d904aeec3 100644 > --- a/arch/x86/kvm/svm/svm.c > +++ b/arch/x86/kvm/svm/svm.c > @@ -3322,7 +3322,7 @@ static void svm_inject_irq(struct kvm_vcpu *vcpu) > { > struct vcpu_svm *svm = to_svm(vcpu); > > - BUG_ON(!(gif_set(svm))); > + WARN_ON(!gif_set(svm)); > > trace_kvm_inj_virq(vcpu->arch.interrupt.nr); > ++vcpu->stat.irq_injections; > Reviewed-by: Maxim Levitsky Best regards, Maxim Levitsky