From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A37D2F6572 for ; Mon, 8 Dec 2025 13:40:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765201248; cv=none; b=Pidb9U4cDhfpRVOL8yYJe4QSGkZZy01RwEI/ifzLp42jsUQSBqcrQnqWMYVqrOWYWrarYgrRbIt7exJTy2YqVQFzlBVqi8QhM/fOjAhydlJiKvrfQufg6QtuSKZwb0s9GO9ypq1G8n/f2ai2HSTBRPBD5E4spj/YXf2yKVELGfU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765201248; c=relaxed/simple; bh=c03rWGellbVHJXYhUe7LbI0Fsb1v9e2LaGoYvPo9N9Q=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=PtVuxsZdEGSY4Cf7alt7BvlSuFb/sZedSVyvrsL/uDV1BByM6Ft4COL0OK3oTUiAkw4RHG3VbCTJbp6mUtG3gBQE2hqmb1LkP96vZY1PClfQ2SghtDR7dlR2G5nEj/EGxU9CRmVHIAmYMp/kGcjLmYBQTaOcsyqAqZI9kZFePZI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=S2ZPVfNl; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ZQuz/Ya9; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="S2ZPVfNl"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ZQuz/Ya9" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B88aGY2095647 for ; Mon, 8 Dec 2025 13:40:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Ng5jW/XFxY6TkKxsaL1XvkuCaD/iKRVXnFTAkSbhtgM=; b=S2ZPVfNlrJdqoRir iGLUEyqETeeL22xKtxba25mTF4epo1abrhUb6uWju5WlmuR257GKkMSbH1lyIJ+f p1QYgtd60xJrqFl58DVKR8DZdUsnkBo2IRY1HCrHDZKuKSS6+ShjR9RD2lmmeS5t 4iBt6oULzncVqOxoAy4IFG7slTZobB0Dmna+5JXuDzR+NH3jYWZ8IptFFU4nEWkh OzH8KWJi2+tJtvUveiusfCoWnk7oSgO5T4Wv490v7f0xHmvDZQMjs2JfQkBZPLL3 J1xqG+QNZS2Xzkl16GOs2M8PNHjIcyz5ixsE1Kh0jMm1xH3HJdLVYzrlFvfvN/jM xLwsLA== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4awuafruj6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 08 Dec 2025 13:40:45 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2958c80fcabso98308835ad.0 for ; Mon, 08 Dec 2025 05:40:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1765201245; x=1765806045; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=Ng5jW/XFxY6TkKxsaL1XvkuCaD/iKRVXnFTAkSbhtgM=; b=ZQuz/Ya9b1qqGthKr/RQ5AQKxD4nMFGJoPznJO22awecSClYhoj2G+4HsdkkfdPfqz ahRHonexWsmRXneuc7SiuDASTzC03r4YhnOSNrUbjnXfB4f7JzMnL5IRvzqb8/PlgYP6 G2CHqFf47h7wMQ8eLFJRE5Dxqud7UtWc2l0pWnt76F/deTmekGUa3yo3BzNDs8q1cu9f 0v0esWRdgEoXNEgVr2eJSKVQB9A2sC4A3RhEw5YQs2duc61Osh+OeZ6JPhk6JAfhJzKg Lr040wSyrcqqHd98t/mnP3h3u+7+anfF9fvaW8o+p1vLkDgd/PaL0M2HXeUs+O6fxgtZ vTmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765201245; x=1765806045; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ng5jW/XFxY6TkKxsaL1XvkuCaD/iKRVXnFTAkSbhtgM=; b=GVrfsrJhLEegdq1NuxHpiRP/sh49Wc6+y6/szEPJopBPAeB1EkK20NTrPWIzRKm0BO tSWOQ30E9Yo6TRiZQqCd5H4dsjTjV+EETwfaC/+iK61Dmr+StqHDljHjCso07wn5fG7z w/6dscFgRGJ8ErY/r1wbEIVYYzvf0k/opqTarB/D9qKyydSUHiOW0EvBkaBSPFaZMLbe Dybdj4E4tyqjnc94Izyhg8L8JEcf720QAOdeBMrgsTNdCRjYbBcqQLV4MubMvzSX+/lX UzqQnCyz+QFXvVkhDEO43BQmwKuRpHqGuoFxIwPja9EwXJUpDJku0QatrmY+XokrXUih 1UAQ== X-Forwarded-Encrypted: i=1; AJvYcCXgsqvL0wnahCnmOurp32sWK0yNFfbWcYVtqxmmOISHmpcknBwAauvngvhjRIYdcPyAuLxiMGtExEqpJ+c=@vger.kernel.org X-Gm-Message-State: AOJu0Yzx1JjGHlLtpvQokdzp0hFlgyc/ytnXDwok2mSyYnCxz+meQLqV UWaqINeJk1wy84qcbsbf3KxZsKPkxTECi8GLqcWgoVM8XL+cEej4a2507kpvtmltInE5Djhjdam MtEO08lAQgxszlagChRJIY9woQQApmekTBEtkUxZ99DEZoIi+KLl4+Iw/K/IWOGq1TxE= X-Gm-Gg: ASbGncth7iynfl5QWkUhQLCcSSVmcR2rKY3/mkl7nDPX4DNXJ0BOECyo+av1J5mrknq xTM8eWUlNXB5MDb3YnIWDKbuQ/1Itdi4rJWP+sQbOTQ2MiJr1cGSTMF3tBzNH1ucAgpQWdW9Q// bEngkiKJ4eSdDf9A/hkraTuSz7Kp9+Dopg+3j2YpDN/xr7A8apIoBujEDlhfpMa/u+HLgQqyp58 R50AKPXl4qNk23wAgRqqnuHvoWiBIRSToSbrVqpUnXo5j4TlxrEk2HDoKph8ze8zAn8QaGRKYm+ 9DJHQL3O9JBwqQHuK+fFDUKeEzsDUABb4iK/sstISvU1MZeJKrZtc3/q+n2CoySJ9uykLSJ8v2J yXCMJG0DihCwOPK3w3V4wMlA36eqMW5tfDbi10Id2sYgJMw== X-Received: by 2002:a17:903:1965:b0:295:5625:7e41 with SMTP id d9443c01a7336-29df57924fbmr76806235ad.22.1765201244972; Mon, 08 Dec 2025 05:40:44 -0800 (PST) X-Google-Smtp-Source: AGHT+IHsFuiR54Gi4iuunMhcDxbWCnuzkSb4g0YincgSlJk3qleZrdBe8zXZT+yJe2Y4Hlr/EspoRQ== X-Received: by 2002:a17:903:1965:b0:295:5625:7e41 with SMTP id d9443c01a7336-29df57924fbmr76806035ad.22.1765201244432; Mon, 08 Dec 2025 05:40:44 -0800 (PST) Received: from [192.168.1.9] ([205.254.168.129]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29dae4cf996sm128464715ad.30.2025.12.08.05.40.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Dec 2025 05:40:44 -0800 (PST) Message-ID: <837be315-2eca-4990-94e8-6d0765a8ba44@oss.qualcomm.com> Date: Mon, 8 Dec 2025 19:10:32 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Vijayanand Jitta Subject: Re: [PATCH v2 2/3] of: factor arguments passed to of_map_id() into a struct To: Dmitry Baryshkov , robin.murphy@arm.com, will@kernel.org, joro@8bytes.org, robh@kernel.org, konrad.dybcio@oss.qualcomm.com, bjorn.andersson@oss.qualcomm.com, bod@kernel.org, conor+dt@kernel.org, krzk+dt@kernel.org, charan.kalla@oss.qualcomm.com, prakash.gupta@oss.qualcomm.com, vikash.garodia@oss.qualcomm.com Cc: iommu@lists.linux.dev, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20251204095530.8627-1-vijayanand.jitta@oss.qualcomm.com> <20251204095530.8627-3-vijayanand.jitta@oss.qualcomm.com> <75d44bf2-c518-444d-9b15-fca067e25877@oss.qualcomm.com> Content-Language: en-US In-Reply-To: <75d44bf2-c518-444d-9b15-fca067e25877@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=ep7SD4pX c=1 sm=1 tr=0 ts=6936d55d cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=qGVSFsv8/Tytdn00NEnLeQ==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=GBqTS8oSEQGj30kF9o4A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-ORIG-GUID: 9-RZ9H6fRgNHju5LSSu_5AlXzwtuaoCr X-Proofpoint-GUID: 9-RZ9H6fRgNHju5LSSu_5AlXzwtuaoCr X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjA4MDExNiBTYWx0ZWRfXw5rjf2Ge5i/A zZmzgqMdB1W/n6nQMbJgTlaD+bJtBD72ujZ0V+DoW2fhMEu4B587D2ZNWqAeCTT5QxGg5f/MGYQ sDuq3GFgFJgrYLPU0KhQjCN9q+SGuWWJoIdUba1YkhzlhV+w5fe7odwHfeed3K2LeE5UR4dAeC8 dNoXWkJU93QwVCJwKnNEPX9FTR8YfbRvdk2Bp2zEcLTsEnSrAdGwG+OM4/tviUrCc3sDObe05kg IE0mIcqMYUGxywN+dKGQn04X0jmfOYJKZyq01CkgshB38K5uyB4I9aVZPyNQiOeuxRWH1K6RhAa j0ePxT2fGYxBEYdYk/xfFmlBM8HJkBsWLyPrTqgBEf5iGKGD5ThO+YKSLCKLSvCtiQjY7tnJqHk oUwfFnlmaNH38wcKvkxQu+MR2++DwA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-06_02,2025-12-04_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 spamscore=0 clxscore=1015 bulkscore=0 adultscore=0 lowpriorityscore=0 suspectscore=0 priorityscore=1501 malwarescore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512080116 On 12/5/2025 10:17 PM, Dmitry Baryshkov wrote: > On 04/12/2025 11:55, Vijayanand Jitta wrote: >> From: Charan Teja Kalla >> >> Introduce a new struct type where the optional arguments passed to >> of_map_id() are in struct. Subsequent patches add additional arguments >> to the struct that the caller expects to be filled of_map_id(). > > Why do we need a separate struct? Can't we use of_phandle_args instead? > The idea is to use it for multi-map support mentioned in the cover letter, where we need to pass additional context (callback, dev etc..). Having a seperate structure here makes of_map_id() interface easier to extend. >> >> Signed-off-by: Charan Teja Kalla >> Signed-off-by: Vijayanand Jitta >> --- >>   drivers/iommu/of_iommu.c              |  6 +++++- >>   drivers/of/base.c                     | 31 ++++++++++++++------------- >>   drivers/pci/controller/dwc/pci-imx6.c |  6 +++++- >>   drivers/pci/controller/pcie-apple.c   |  5 ++++- >>   drivers/xen/grant-dma-ops.c           |  5 ++++- >>   include/linux/of.h                    | 23 ++++++++++++++------ >>   6 files changed, 50 insertions(+), 26 deletions(-) >>