From: Sinan Kaya <okaya@codeaurora.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-pci@vger.kernel.org, timur@codeaurora.org,
linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Jonathan Corbet <corbet@lwn.net>,
Bjorn Helgaas <bhelgaas@google.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@kernel.org>,
Christoffer Dall <cdall@linaro.org>,
Mimi Zohar <zohar@linux.vnet.ibm.com>,
Marc Zyngier <marc.zyngier@arm.com>,
Ding Tianhong <dingtianhong@huawei.com>,
Michal Hocko <mhocko@suse.com>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2 7/7] PCI: make reset poll time adjustable
Date: Tue, 28 Nov 2017 09:26:30 -0500 [thread overview]
Message-ID: <837be7ee-13c7-8e8a-1a6b-87fd5e42b166@codeaurora.org> (raw)
In-Reply-To: <20171128142044.GC11228@bhelgaas-glaptop.roam.corp.google.com>
On 11/28/2017 9:20 AM, Bjorn Helgaas wrote:
>> Introduce pci=resetpolltime= argument to override 60 seconds poll time in
>> units of milliseconds.
> I resist adding kernel parameters because they really complicate the
> user experience. Obviously you added this for a reason, but I don't
> know what that is. If we really need it, is there any way we could
> automatically figure out in the kernel when we need different poll
> times?
>
No, we can drop this patch if we want to . This was mostly a
scalability concern.
I worried adding 60 seconds would be too much for some use case. We can
hold onto this change until that use case happens if you want.
--
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
prev parent reply other threads:[~2017-11-28 14:26 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1511763628-11856-1-git-send-email-okaya@codeaurora.org>
2017-11-27 6:20 ` [PATCH V2 1/7] PCI: protect restore with device lock to be consistent Sinan Kaya
2017-11-29 17:36 ` Christoph Hellwig
2017-11-27 6:20 ` [PATCH V2 2/7] PCI: handle FLR failure and allow other reset types Sinan Kaya
2017-11-29 17:36 ` Christoph Hellwig
2017-11-27 6:20 ` [PATCH V2 3/7] PCI: make pci_flr_wait() generic and rename to pci_dev_wait() Sinan Kaya
2017-11-29 17:38 ` Christoph Hellwig
2017-12-04 13:17 ` Sinan Kaya
2017-12-13 22:43 ` Bjorn Helgaas
2018-01-02 15:47 ` Sinan Kaya
2017-11-27 6:20 ` [PATCH V2 4/7] PCI: wait device ready after pci_pm_reset() Sinan Kaya
2017-11-29 17:38 ` Christoph Hellwig
2017-11-27 6:20 ` [PATCH V2 5/7] PCI: add a return type for pci_reset_bridge_secondary_bus() Sinan Kaya
2017-11-29 17:38 ` Christoph Hellwig
2017-11-27 6:20 ` [PATCH V2 6/7] PCI: add device wait after slot and bus reset Sinan Kaya
2017-11-29 17:39 ` Christoph Hellwig
2017-11-27 6:20 ` [PATCH V2 7/7] PCI: make reset poll time adjustable Sinan Kaya
2017-11-28 14:20 ` Bjorn Helgaas
2017-11-28 14:26 ` Sinan Kaya [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=837be7ee-13c7-8e8a-1a6b-87fd5e42b166@codeaurora.org \
--to=okaya@codeaurora.org \
--cc=akpm@linux-foundation.org \
--cc=bhelgaas@google.com \
--cc=cdall@linaro.org \
--cc=corbet@lwn.net \
--cc=dingtianhong@huawei.com \
--cc=helgaas@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mhocko@suse.com \
--cc=mingo@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
--cc=timur@codeaurora.org \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome