From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750950AbdBBG52 (ORCPT ); Thu, 2 Feb 2017 01:57:28 -0500 Received: from mailout4.w1.samsung.com ([210.118.77.14]:37769 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750808AbdBBG5Z (ORCPT ); Thu, 2 Feb 2017 01:57:25 -0500 X-AuditID: cbfec7ef-f79d26d00000420c-63-5892d8539b50 Subject: Re: [PATCH] pinctrl: samsung: mark PM functions as __maybe_unused To: Arnd Bergmann , Linus Walleij Cc: Tomasz Figa , Krzysztof Kozlowski , Sylwester Nawrocki , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org From: Marek Szyprowski Message-id: <8385d3c5-2da6-e39e-de8c-e10fde820e43@samsung.com> Date: Thu, 02 Feb 2017 07:57:19 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-version: 1.0 In-reply-to: <20170201161636.2109091-1-arnd@arndb.de> Content-type: text/plain; charset=utf-8; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrKKsWRmVeSWpSXmKPExsWy7djP87rBNyZFGEzYIWfxd9Ixdovz5zew W0z5s5zJYtPja6wWm+f/YbS4vGsOm8WM8/uYLA6/aWe1WLXrD6MDp8fvX5MYPXbOusvusWlV J5vHnWt72Dw2L6n36NuyitHj8ya5APYoLpuU1JzMstQifbsErowL/08yFjQIV+z4vZOtgfEi fxcjJ4eEgInE7vsLmSBsMYkL99azdTFycQgJLGOUaLoMkgBxPjNKrDu7ggWm49+VVoSqzz9n MUI4zxklbkybDjZLWMBL4unBG8wgtoiAt8TRzUeZQYqYBVqYJK5d38EOkmATMJToetvFBmLz CthJ3N91kBXEZhFQldi4+R1YjahAjMTreX/ZIWoEJX5Mvgd2BqeAqcS1hSvBFjALWEk8+9fK CmHLS2xe8xZsmYTAPnaJM68nA53HAeTISmw6wAzxgovExM53UE8LS7w6voUdwpaRuDy5G+rN fmAAtGpD2DMYJc695YWwrSUOH78ItYtPYtK26cwQ43klOtqEIEo8JCbefs4IYTtKfG7/xQoJ oA6gMZN2Mk5glJ+F5J1ZSF6YheSFBYzMqxhFUkuLc9NTiw31ihNzi0vz0vWS83M3MQITz+l/ x9/vYHzaHHKIUYCDUYmHN0NsUoQQa2JZcWXuIUYJDmYlEd7Qq0Ah3pTEyqrUovz4otKc1OJD jNIcLErivHsXXAkXEkhPLEnNTk0tSC2CyTJxcEo1MBaeVXv0WOrAl4ZdrBNY5TWdzIXW79j6 8F+kQZLxr1V6wh4vv2Rdir3qdDGh79fsRS8fKXrbnw33lH1yTPHV12WaLNdL2tza20qi8kyD 1CbJvHk8I/Ydd7157xzDPaWMC50nHlxy4tPHRB73z/2/BcQ0FX3ZmVboezoKbeNcN7GFx+W+ hfM6ViWW4oxEQy3mouJEACuEKYM4AwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrGIsWRmVeSWpSXmKPExsVy+t/xa7r+NyZFGBxeb2Dxd9Ixdovz5zew W0z5s5zJYtPja6wWm+f/YbS4vGsOm8WM8/uYLA6/aWe1WLXrD6MDp8fvX5MYPXbOusvusWlV J5vHnWt72Dw2L6n36NuyitHj8ya5APYoN5uM1MSU1CKF1Lzk/JTMvHRbpdAQN10LJYW8xNxU W6UIXd+QICWFssScUiDPyAANODgHuAcr6dsluGVc+H+SsaBBuGLH751sDYwX+bsYOTkkBEwk /l1pZYOwxSQu3FsPZHNxCAksYZS4c2I7I4TznFFi54OdLCBVwgJeEk8P3mAGsUUEvCWObj7K DFHUxSix5v8GsA5mgRYmiYOT1rCDVLEJGEp0ve0C28ErYCdxf9dBVhCbRUBVYuPmd2A1ogIx Ei/3rGKBqBGU+DH5HpjNKWAqcW3hSrBtzAJmEl9eHmaFsOUlNq95yzyBUWAWkpZZSMpmISlb wMi8ilEktbQ4Nz232EivODG3uDQvXS85P3cTIzAOtx37uWUHY9e74EOMAhyMSjy8GWKTIoRY E8uKK3MPMUpwMCuJ8IZeBQrxpiRWVqUW5ccXleakFh9iNAV6YiKzlGhyPjBF5JXEG5oYmlsa GhlbWJgbGSmJ8079cCVcSCA9sSQ1OzW1ILUIpo+Jg1OqgdH/dGxPxNN3x85U+Nq8PrJixQSr kqzjdo7mu8Kbpab8v277pmOBo192vlEek2l4l75IxSLFSacjF8x4FxT9dB/fMT51rieBh7ju veDTnZx8PWUx/0adxNva7i3BCboOUckT1dzL3kV8lRNZZyF5K5Ltiquo1Mrz00P7Jwg+6MqS X9FVeOggvxJLcUaioRZzUXEiAPep1ArZAgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170202065720eucas1p2c89b5f5ab7fc99b5f8a5aace5d6985c2 X-Msg-Generator: CA X-Sender-IP: 182.198.249.180 X-Local-Sender: =?UTF-8?B?TWFyZWsgU3p5cHJvd3NraRtTUlBPTC1LZXJuZWwgKFRQKRs=?= =?UTF-8?B?7IK87ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?TWFyZWsgU3p5cHJvd3NraRtTUlBPTC1LZXJuZWwgKFRQKRtT?= =?UTF-8?B?YW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20170201161645epcas3p235bc144eb1f03127d707371f7cf963e1 X-RootMTR: 20170201161645epcas3p235bc144eb1f03127d707371f7cf963e1 References: <20170201161636.2109091-1-arnd@arndb.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnd, On 2017-02-01 17:16, Arnd Bergmann wrote: > The rework of the suspend/resume handling uses the wrong #ifdef check, leading > to a build warning without CONFIG_PM_SLEEP: > > drivers/pinctrl/samsung/pinctrl-samsung.c:1142:12: error: 'samsung_pinctrl_resume' defined but not used [-Werror=unused-function] > drivers/pinctrl/samsung/pinctrl-samsung.c:1092:12: error: 'samsung_pinctrl_suspend' defined but not used [-Werror=unused-function] > > Using a __maybe_unused annotation instead of the #ifdef is a simple way to > avoid this problem class. > > Fixes: 2b24efa8e5c5 ("pinctrl: samsung: Replace syscore ops with standard platform device pm_ops") > Signed-off-by: Arnd Bergmann Thanks for the fix! Acked-by: Marek Szyprowski > --- > drivers/pinctrl/samsung/pinctrl-samsung.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/pinctrl/samsung/pinctrl-samsung.c b/drivers/pinctrl/samsung/pinctrl-samsung.c > index d79eadad6c5f..d601b5303e73 100644 > --- a/drivers/pinctrl/samsung/pinctrl-samsung.c > +++ b/drivers/pinctrl/samsung/pinctrl-samsung.c > @@ -1083,13 +1083,12 @@ static int samsung_pinctrl_probe(struct platform_device *pdev) > return 0; > } > > -#ifdef CONFIG_PM > /** > * samsung_pinctrl_suspend - save pinctrl state for suspend > * > * Save data for all banks handled by this device. > */ > -static int samsung_pinctrl_suspend(struct device *dev) > +static int __maybe_unused samsung_pinctrl_suspend(struct device *dev) > { > struct samsung_pinctrl_drv_data *drvdata = dev_get_drvdata(dev); > int i; > @@ -1139,7 +1138,7 @@ static int samsung_pinctrl_suspend(struct device *dev) > * We don't bother doing anything complicated to avoid glitching lines since > * we're called before pad retention is turned off. > */ > -static int samsung_pinctrl_resume(struct device *dev) > +static int __maybe_unused samsung_pinctrl_resume(struct device *dev) > { > struct samsung_pinctrl_drv_data *drvdata = dev_get_drvdata(dev); > int i; > @@ -1183,7 +1182,6 @@ static int samsung_pinctrl_resume(struct device *dev) > > return 0; > } > -#endif > > static const struct of_device_id samsung_pinctrl_dt_match[] = { > #ifdef CONFIG_PINCTRL_EXYNOS Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland