From: Shreeya Patel <shreeya.patel@collabora.com>
To: Rob Herring <robh@kernel.org>
Cc: jic23@kernel.org, lars@metafoo.de, Zhigang.Shi@liteon.com,
krisman@collabora.com, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@collabora.com, alvaro.soliverez@collabora.com,
Krzysztof Kozlowski <krzk@kernel.org>
Subject: Re: [PATCH v4 1/3] dt-bindings: vendor-prefixes: Add 'ltr' as deprecated vendor prefix
Date: Tue, 17 May 2022 16:07:33 +0530 [thread overview]
Message-ID: <83907dd2-2a53-2448-576b-ae26462d432a@collabora.com> (raw)
In-Reply-To: <20220516170058.GA2825626-robh@kernel.org>
On 16/05/22 22:30, Rob Herring wrote:
> On Wed, May 11, 2022 at 03:10:22PM +0530, Shreeya Patel wrote:
>> 'liteon' is the correct vendor prefix for devices released by
>> LITE-ON Technology Corp. But one of the released device which uses
>> ltr216a light sensor exposes the vendor prefix name as 'ltr' through
>> ACPI.
> ACPI? NAK.
>
> There are no cases of 'ltr' for DT, so fix ACPI.
Hi Rob,
Yes, we understand there are no cases of 'ltr', but we have released devices
which uses this string for probing the ltrf216a light sensor driver (
x86 with DT )
If we don't document this in vendor-prefixes.yaml, then the following
warning
is generated.
WARNING: DT compatible string vendor "ltr" appears un-documented --
check ./Documentation/devicetree/bindings/vendor-prefixes.yaml 364:
FILE: drivers/iio/light/ltrf216a.c:313: + { .compatible = "ltr,ltrf216a" },
Can you suggest us what would be the right way to fix this warning if
not documenting
in vendor-prefixes.yaml?
Thanks,
Shreeya Patel
>
>> Hence, add 'ltr' as a deprecated vendor prefix which would suppress the
>> following warning in case the compatible string used in ltrf216a driver
>> is "ltr,ltrf216a"
>>
>> WARNING: DT compatible string vendor "ltr" appears un-documented --
>> check ./Documentation/devicetree/bindings/vendor-prefixes.yaml
>> 364: FILE: drivers/iio/light/ltrf216a.c:313:
>> + { .compatible = "ltr,ltrf216a" },
>>
>> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
>> Signed-off-by: Shreeya Patel <shreeya.patel@collabora.com>
>> ---
>>
>> Changes in v2
>> - Add vendor prefix name as per the alphabetical order.
>>
>> Documentation/devicetree/bindings/vendor-prefixes.yaml | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
>> index 01430973ecec..02f94fba03b6 100644
>> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
>> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
>> @@ -716,6 +716,9 @@ patternProperties:
>> description: Loongson Technology Corporation Limited
>> "^lsi,.*":
>> description: LSI Corp. (LSI Logic)
>> + "^ltr,.*":
>> + description: LITE-ON Technology Corp.
>> + deprecated: true
>> "^lwn,.*":
>> description: Liebherr-Werk Nenzing GmbH
>> "^lxa,.*":
>> --
>> 2.30.2
>>
>>
next prev parent reply other threads:[~2022-05-17 10:38 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-11 9:40 [PATCH v4 0/3] Add LTRF216A Driver Shreeya Patel
2022-05-11 9:40 ` [PATCH v4 1/3] dt-bindings: vendor-prefixes: Add 'ltr' as deprecated vendor prefix Shreeya Patel
2022-05-16 17:00 ` Rob Herring
2022-05-17 10:37 ` Shreeya Patel [this message]
2022-05-18 16:32 ` Rob Herring
2022-05-23 14:57 ` Shreeya Patel
2022-05-24 15:47 ` Rob Herring
2022-05-26 7:33 ` Shreeya Patel
2022-05-11 9:40 ` [PATCH v4 2/3] dt-bindings: Document ltrf216a light sensor bindings Shreeya Patel
2022-05-16 17:04 ` Rob Herring
2022-05-11 9:40 ` [PATCH v4 3/3] iio: light: Add support for ltrf216a sensor Shreeya Patel
2022-05-11 12:04 ` Andy Shevchenko
2022-05-12 23:40 ` Dmitry Osipenko
2022-05-14 16:17 ` Jonathan Cameron
2022-05-12 23:41 ` Dmitry Osipenko
2022-05-12 23:54 ` Dmitry Osipenko
2022-05-13 13:40 ` Shreeya Patel
2022-05-13 14:38 ` Shreeya Patel
2022-05-13 17:59 ` Dmitry Osipenko
2022-05-13 0:05 ` Dmitry Osipenko
2022-05-13 0:12 ` Dmitry Osipenko
2022-05-13 0:30 ` Dmitry Osipenko
2022-05-17 10:54 ` Shreeya Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83907dd2-2a53-2448-576b-ae26462d432a@collabora.com \
--to=shreeya.patel@collabora.com \
--cc=Zhigang.Shi@liteon.com \
--cc=alvaro.soliverez@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=kernel@collabora.com \
--cc=krisman@collabora.com \
--cc=krzk@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®