From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C63CE283FEA for ; Thu, 14 May 2026 12:36:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778762181; cv=none; b=WFX1BSR0jpRyXNEFFPw4Bd96kDQ1ch+/KHGtHEB5cPRK1tYF7I44j5h1fAfEFbnbQ7hZeUPYs0W7tDRCoNTXrIgfCAU8ikdeoUfswgwLtKD5MN/jqAtCUUTC8C7f321BlLau0vF9vJavCRhXBTk58P/mdmxQdY3E1eX0gbjG5Hk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778762181; c=relaxed/simple; bh=xQD6ynP2HswCTksRdrkuex7u22mk5r5rKc6Ptzhavws=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dsNgChlbDkv+x8V2+jFKZ4eWLrwACrcdVysjL43w7zLNNL62UcWHPTTvDmUImv3n1132Qa5PHOEjAyoYVZ7k/jr0UJPc8TjqjEfmMLkqC2YqUANRICTbkfvYLBFpT07zf7WMmam/c8j4eDudLz/UjZnPHzTCG4f+escZSyx88JI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=YdZfUXij; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=PNEjCCQH; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="YdZfUXij"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="PNEjCCQH" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64EBePTq1717719 for ; Thu, 14 May 2026 12:36:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= L3E4RMWJDlN4oTIAm3vwmxetHRc24rPFl0tCcoD9zto=; b=YdZfUXijc1B63K4O JdArn+cNh/r/AmZB/J0SRCcZ28FQsxxgqDgzALCmvHrC6TZ4czcJ5FSfjCVxIdLo m5wiUrTeTxnJ/Geh+XNmLOqRuJJHLJ+E7RGvS2ygDQ7P67Gp/VE6+L2Ue5sBctVH BcvvCPsVXEJYwbtK1F6ULFfEP4vh+3tMCFzVpzQz6u6wbT0/KOEcco6smNCe2tx+ 2WikL6CpTdyaCDtwnYRf16RPCqNwjI9OCSoJm6P77yHVgLxbj4DTGXUUg7br8UT2 RUMKUMe3kAUtmfFg5059U3y59k9H17t2qLjKS7i9zCV7MU/ScqOv4z/mAbF4AjxN AXdELQ== Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e57y7hfdf-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 14 May 2026 12:36:18 +0000 (GMT) Received: by mail-vk1-f197.google.com with SMTP id 71dfb90a1353d-5752affb36bso719548e0c.1 for ; Thu, 14 May 2026 05:36:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778762178; x=1779366978; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=L3E4RMWJDlN4oTIAm3vwmxetHRc24rPFl0tCcoD9zto=; b=PNEjCCQHBRrCqdNJbfRyd0MClW+4a30ymMExHYI2SpSUG8RCr14TXM8B/gcSIDPa5s PSiTqyEWS5hTpwJXhjrcZyKtj55108OfVTk9bEY6FssCPnpXQexD2ldClwPtGxzZSWlX T0HFkCArqbRDniBNfqePQgNsJkdzO62aZW1wxI528lcnUnWOIq2M54k6MZMfsIwYJWG+ KirJvcN4em2vv6ETO1CY4bgKLI/fO9a3rZnu5bYERx3XrnQN7NzQISHTkEGcANqs/wES fJBBarKV+Vhe/woC1SzTpzuKtMT1XFJs+cQ2XJoS8/oz97D5IUnQWtZnG7u03T+lemXR lxJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778762178; x=1779366978; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=L3E4RMWJDlN4oTIAm3vwmxetHRc24rPFl0tCcoD9zto=; b=OsFiqIlUAEqaus/X9YtgYMDAUSNmRxC757bdH7wADS7d+tH7/QfaBUoaxcuSM/rSAO mVc+FZK5uvmOyUZzjXAEueJmE+iecpv6v/CzNvjwGOOMcOTMeg5zojhauan7bKkxgjNK 4mhzpeX2zkGtAnqB7gXla72NbrQO2auK26CD/ebmsAHLYfO0IHKtfD+K89IYlqG+WNSn xo50AGzY83br+fcNElQoB6ojFmF8mTShg+Mm3Tcn6wx+cJl0U4iUK4Tu8g1Fi+tcstEb H9h4K0/e3T7XC2Eh+gMEUgMfJ+njdI9dGUUfHjTz1KxtWl/Ajs95amJxwojShGYWUuL9 eaWA== X-Forwarded-Encrypted: i=1; AFNElJ/D67HI6lMJPEfdIEQ8ztV4Ps3zpUINa964KSF7X2olwxa+vXVsp7KgBBIr+Jx6G6ZEYzZKb2oGSasQ0TE=@vger.kernel.org X-Gm-Message-State: AOJu0Yz1de/cKESwvfwri7s44qmeuYRaBuwzzz1pzjIPihIoZl0Yxyai ADVrLLJR+JNdcftsp62g0kenjJmkLKlAF2naSVO6GahnenTXrHuHoO5Z7ouoykEYOhODFyJdXD+ G4FrCA9lzcUxU7d7UmN83eEFn/nHGctCsx4bzlh3XpMp7PFWjLI6B0/1L2rSEjphlTJE= X-Gm-Gg: Acq92OHlnfOskF5Y6B78We3oUgTfxznQGZ2eYvQlFQIWhZS9CSFneyV8xRCRyJ/7pbi Gwh1w6Trqed0iUa5t6VgVLDLsPJf/1KQhlJ7dhrTRCaeOOxEFalbmedK2BMJjjeRkKYAr8yi9ZM Oxbs83wZw5aP8GtYQqdX59Zc8RgMx4nOHNCpy09mtoX0BlYaBN1hLCu+ephJwteS4+YQz1ikMFW lcPkUOsrHMJTyfAqpu0oWOlqZVtbcf76ln72BZx+RcIHShASVv72Wt/ieMWPrkiJ+2Frf5buvBa /ENlGJ8Z4i2O2mKhZqhKAQV+mUtOoxqHMqhJfQIFoPx0Pbeekg47TunrCIC1sOr8NMabmcxcH+Y DFQBua140o5BgBPgpbvAbQNz9Y+ipmRgG7dmoxNpctMdnqxsdE8pZpUnNEKVUlNVWGC4BaOU698 pns+7iIae3VFtjXQ== X-Received: by 2002:ac5:c7d4:0:b0:575:2300:9f54 with SMTP id 71dfb90a1353d-575e6f5a3b9mr1298039e0c.1.1778762177964; Thu, 14 May 2026 05:36:17 -0700 (PDT) X-Received: by 2002:ac5:c7d4:0:b0:575:2300:9f54 with SMTP id 71dfb90a1353d-575e6f5a3b9mr1298009e0c.1.1778762177520; Thu, 14 May 2026 05:36:17 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bd4f4bcf7f3sm85198466b.2.2026.05.14.05.36.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 May 2026 05:36:16 -0700 (PDT) Message-ID: <83958f30-59c5-4b15-a62a-92da02187c08@oss.qualcomm.com> Date: Thu, 14 May 2026 14:36:12 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/8] arm64: dts: qcom: kaanapali: add the GPU SMMU node To: Akhil P Oommen , Will Deacon , Robin Murphy , Joerg Roedel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: Sean Paul , linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Qingqing Zhou References: <20260512-kaana-gpu-dt-v1-0-13e1c07c2050@oss.qualcomm.com> <20260512-kaana-gpu-dt-v1-3-13e1c07c2050@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260512-kaana-gpu-dt-v1-3-13e1c07c2050@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: iZ0B6mm0iMeWTMEQ96W_5vOSMGT36ZmP X-Authority-Analysis: v=2.4 cv=UY9hjqSN c=1 sm=1 tr=0 ts=6a05c1c3 cx=c_pps a=JIY1xp/sjQ9K5JH4t62bdg==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=54KNg95dvv-uSQ5X8vIA:9 a=QEXdDO2ut3YA:10 a=tNoRWFLymzeba-QzToBc:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-GUID: iZ0B6mm0iMeWTMEQ96W_5vOSMGT36ZmP X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTE0MDEyNiBTYWx0ZWRfX+Vq2jrVsKsvi UqdTdVTICSWFnfncosoA4l2MKGwn2BgQ00MyYRZk92mTSZQA4OT5y3GH/qNSOaL2NlLgG51xaEw 34DHigDqE+pcp8S+F9YYBEZnLYGNljNmHV1NgCZxJ3pm/pZfKyV0B/EJkmJFBGIXA1xlom1X4Q6 jwDCDG3Fb0zYmq3Jqt+stFAUPEnAOu9i+2CxGA2Zu2sFvnfD5xXMFsriEfQsEkhWZJUmydsqKLv duDG3wSVABqwwmlMUG9ksnqZWgSbDs7sWZAJVlfmhwF7cbulOsCrCopefvsehwKTH9LJrBFYr7g jcZrmxuJ1qCVLSkl6stus6EbjMW/65z7qGVm48xTLl0UHcZPSE02A4Ef7y2cSWtx4j+xaOGiKJB H4GvbZVINuHIM/to+zM67Hw66YHjOkmgnxA9AMwZUzspEahMfKP0lSDVd1GyBqAiJirx2SBnZtv gQHknp+p6ePY360mJZg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-14_03,2026-05-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 malwarescore=0 clxscore=1015 lowpriorityscore=0 priorityscore=1501 bulkscore=0 impostorscore=0 phishscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605050000 definitions=main-2605140126 On 5/12/26 12:23 AM, Akhil P Oommen wrote: > From: Qingqing Zhou > > Add the Adreno GPU SMMU node for kaanapali platform. > > Signed-off-by: Qingqing Zhou > Signed-off-by: Akhil P Oommen > --- > arch/arm64/boot/dts/qcom/kaanapali.dtsi | 41 +++++++++++++++++++++++++++++++++ > 1 file changed, 41 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/kaanapali.dtsi b/arch/arm64/boot/dts/qcom/kaanapali.dtsi > index bab654bbd6d0..26a4de9c8d45 100644 > --- a/arch/arm64/boot/dts/qcom/kaanapali.dtsi > +++ b/arch/arm64/boot/dts/qcom/kaanapali.dtsi > @@ -2597,6 +2597,47 @@ gpucc: clock-controller@3d90000 { > #power-domain-cells = <1>; > }; > > + adreno_smmu: iommu@3da0000 { > + compatible = "qcom,kaanapali-smmu-500", "qcom,adreno-smmu", > + "qcom,smmu-500", "arm,mmu-500"; The lines are misaligned, but please reshuffle this to be 1 a line > + reg = <0x0 0x3da0000 0x0 0x40000>; Please keep the 8-hex-digit padding for addr > + #iommu-cells = <2>; > + #global-interrupts = <1>; > + dma-coherent; > + > + power-domains = <&gpucc GPU_CC_CX_GDSC>; > + > + clocks = <&gpucc GPU_CC_GPU_SMMU_VOTE_CLK>; > + clock-names = "hlos"; > + > + interrupts = , > + , likewise, please align the '<'s and align the property order in this node with Glymur Konrad