From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S966345AbdKPR6a (ORCPT <rfc822;w@1wt.eu>);
        Thu, 16 Nov 2017 12:58:30 -0500
Received: from mx1.redhat.com ([209.132.183.28]:60948 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S965632AbdKPRuu (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 16 Nov 2017 12:50:50 -0500
Subject: Re: [PATCH 1/2] x86,kvm: move qemu/guest FPU switching out to
 vcpu_run
To: Quan Xu <quan.xu0@gmail.com>, Rik van Riel <riel@redhat.com>,
        "quan.xu04@gmail.com" <quan.xu04@gmail.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, david@redhat.com,
        borntraeger@de.ibm.com, tglx@linutronix.de, rkrcmar@redhat.com
References: <20171114215424.32214-1-riel@redhat.com>
 <20171114215424.32214-2-riel@redhat.com>
 <2e83dd3f-8f03-03ac-45e0-f2fae1d17013@gmail.com>
 <1510756981.21121.291.camel@redhat.com>
 <c331a215-2b7c-3c79-91ce-2b10b1882d36@gmail.com>
 <1510806094.21121.303.camel@redhat.com>
 <0fc15536-0b34-51b6-cc14-00989825b0bc@gmail.com>
 <9ba2d4c1-0781-419e-ddeb-77e0494583d2@redhat.com>
 <afe14c82-1038-72f4-1471-50a5db5c2235@gmail.com>
 <00231a24-f1a2-324e-1c32-0a5a7a3995f1@redhat.com>
 <e3cf353c-a62f-8e1c-685d-3a971605590a@gmail.com>
 <756023cd-5ba5-bb31-c7cc-7c91b6201632@redhat.com>
 <d67cef62-3165-50cd-36e8-be7c555dc79e@gmail.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <8396b51f-674d-74f9-e67f-026504c24631@redhat.com>
Date: Thu, 16 Nov 2017 18:50:41 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <d67cef62-3165-50cd-36e8-be7c555dc79e@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Thu, 16 Nov 2017 17:50:49 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 16/11/2017 15:28, Quan Xu wrote:
>  	vcpu->srcu_idx = srcu_read_lock(&kvm->srcu);
>  
> + kvm_load_guest_fpu(vcpu);
> +
>  	for (;;) {
>  		if (kvm_vcpu_running(vcpu)) {
>  			r = vcpu_enter_guest(vcpu);
> 
> <<
> 
> 
> 
>   as Rik dropped  kvm_load_guest_fpu(vcpu) in  vcpu_enter_guest() ..
>   in case still in kvm mode, how to make sure to pkru is always the
> right one before enter guest mode, not be preempted before
> preempt_disable()  after migration? :(

As you know:

1) kvm_load_guest_fpu doesn't load the guest PKRU, it keeps the
userspace PKRU.

2) the guest PKRU is only ever set in a preemption-disabled area

Thus, context switch always sees the userspace PKRU.  The guest PKRU is
only set the next time vmx_vcpu_run executes.

Paolo