From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Dmitry Vyukov <dvyukov@google.com>
Cc: syzbot <syzbot+4386709c0c1284dca827@syzkaller.appspotmail.com>,
David Miller <davem@davemloft.net>,
linux-can@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
netdev <netdev@vger.kernel.org>,
Oliver Hartkopp <socketcan@hartkopp.net>,
syzkaller-bugs@googlegroups.com
Subject: Re: WARNING in can_rcv
Date: Tue, 16 Jan 2018 19:44:01 +0100 [thread overview]
Message-ID: <8396fb44-e8ab-3245-8c7b-dbc7e17cc9d7@pengutronix.de> (raw)
In-Reply-To: <CACT4Y+b0oUPVr7f973ZgBm9rUog=-mRWDFpcr-EzKaGYRnn8mQ@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 700 bytes --]
On 01/16/2018 07:11 PM, Dmitry Vyukov wrote:
>>> Kernel panic - not syncing: panic_on_warn set ...
>>
>> Invalid packages generate a warning (WARN_ONCE()), and you have
>> panic_on_warn active. Should we better silently drop these CAN packages?
>
> pr_warn_once() will be more appropriate. It prints a single line.
Thanks - just posted the patches, will send a pull request to David
tomorrow.
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-01-16 18:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-16 17:58 syzbot
2018-01-16 18:07 ` Marc Kleine-Budde
2018-01-16 18:11 ` Dmitry Vyukov
2018-01-16 18:44 ` Marc Kleine-Budde [this message]
2018-01-17 6:39 ` Oliver Hartkopp
2018-01-17 7:12 ` Eric Biggers
2018-01-17 7:39 ` Dmitry Vyukov
2018-01-17 8:22 ` Oliver Hartkopp
2018-01-17 8:46 ` Dmitry Vyukov
2018-01-17 8:07 ` Oliver Hartkopp
2018-01-17 9:43 ` Marc Kleine-Budde
2018-01-17 16:29 ` Oliver Hartkopp
2018-01-17 17:12 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8396fb44-e8ab-3245-8c7b-dbc7e17cc9d7@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=davem@davemloft.net \
--cc=dvyukov@google.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=socketcan@hartkopp.net \
--cc=syzbot+4386709c0c1284dca827@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®