From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D2F8149DFF for ; Sat, 30 Nov 2024 09:29:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732958985; cv=none; b=UQJV0sTj2wB8zKaipDVdZULMjI4odQzR4Gr1nMLdi+oNprR9b7y7TUVlYLW/6dX3HrNa+B9PgaEl7iNwHIc0zGvnl0I2OlMf2KRZvU/vVF2NZeHusTQBe9T+9myRSB4vmLQpgheQMD3xQyuZmBSmAORHXwye8006yasw13gpeG8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732958985; c=relaxed/simple; bh=8S8NqFJcmk19vBi6hz6u1QtV0eh5xbfO3D1K8U7K38U=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TX8FSKha+HarDck11CcBcat10pE3CZhuT9AVLbVSOG8uHMGOD0hI5ZkG0WLOqQG9ZqFqu56mzreRWbgyMWJLj7L/i+J6pBS7pwt8/0Pa1EuzDhbkCopWw2FG9iNn6NGlWy0+7gwAM3MutsRKYmxC8JFak+Xk6QFH1AeTjptZmm8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=kaxo2LXi; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="kaxo2LXi" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-4348f65e373so2868195e9.2 for ; Sat, 30 Nov 2024 01:29:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1732958982; x=1733563782; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=FO8MN/OOdM9uSwx0W1RkFiw2siggznBougNaykngYTo=; b=kaxo2LXi2g867DD6YceK/1EtaOu256XbIulHnHTY+4beIXUorP2U/wPq+NqWWol1iH ZfHjc/bIjK6qj/+RWhI/FQEVBzZ3CCBZ7hEZiXveqCYePgAiVtcTYbA1+wYKDNhm5xTG 58gWvzQwioiN2z64Q6o7K8HlvXdkInm1HIKrjoh92if9h6zi9sd1PLFWuvUZx7b8U9C8 c0ZleLk97gEr2wF5+LV5PmUPb5K1SEbS6LnLugo1NfMaXaXmSUwHPKXJEr/GEYlPuv86 5xNS4ie9r+sJ2tgtIyQmcR6tfVxtm9nNQ4QPhWInjKC9JOT6OWKgoFOhAPZkPPMlcjTE 1YmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732958982; x=1733563782; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FO8MN/OOdM9uSwx0W1RkFiw2siggznBougNaykngYTo=; b=htp6lQWYHpw48btMOhb3vgSZDgYInxt5amAqgPBG1CB18DY99zH4rlPxB9RGhLon4p u+68WXYq8jXo6R0uCTopwAPBeZpzdhEsZd0rWkXKXmzZQzwInmpo2YwxojoSZSZipjLu Ot6Rg13ZEDU4okF7zwqYxIQyAB+UCwJU0BC5JYzQceAkreyjvSXSjLFH591Ash/gYG27 yfrC95TlRtGDG+kXn6eL42Mr4LrgejuYcL4FnD2JZorU0l/qsmM1ZXfbihe9WLicRIWS iW+75O+jyt0kH9TqaplvpvbrGRZv24TNBy1yX8PyblAeFrlY21mXAMx2vzqBGTpz8lyN g0WA== X-Forwarded-Encrypted: i=1; AJvYcCW8FANPr1fwELuI8QNwm7dfJdMK8AZOfYmUsz4Eavg1ICJ0qDr342pU5rRV7Ciol906o5YasrRRPbGNt9E=@vger.kernel.org X-Gm-Message-State: AOJu0YwLa2Y4hOPYmBjZuDp13SyfnMzJs1iWjCMR/xnuaLf/aYJecbUV ic9xU37rtp/8rqbNlB8OxRXJxa72paJATcqjDw+HZWsrdZR0CBGFQvyi8beK/pw= X-Gm-Gg: ASbGncuNnBSfAVENtmwvonDA3MGX2AahIoBitzMsiJOb7abRusT6OXL8wewT3QZg2IU FwCQfVk2ecdQ9pk3sko5F0Rk1HKXv6uiuloqdoo2wi/+x3hqUs9FTULpl8gp6kuevthKGhF9DB6 1Gtet0TkeOjxDZbfrEHtgm3qgI+njkhhjHM4DobfEeDaQjW7JlrYNU+rcaNzWDGWylUgt0/YRMQ h94HxcaOuRZI/D7ey9K9LdZTs9/lRaIWXgD9A9sQEl64PJwPeJs5dXjlk5kAO4zfmSV X-Google-Smtp-Source: AGHT+IFweECIUTj+FnxOhsU/0xvsrtZXue0BuXrMRxKpQRCq6QGayrOYZjhOzmFyksu73yqogy6gnw== X-Received: by 2002:a05:6000:4817:b0:385:c878:62f4 with SMTP id ffacd0b85a97d-385c878656amr4908415f8f.13.1732958981906; Sat, 30 Nov 2024 01:29:41 -0800 (PST) Received: from [192.168.1.20] ([178.197.218.23]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-385e3cbe250sm1124898f8f.94.2024.11.30.01.29.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 30 Nov 2024 01:29:41 -0800 (PST) Message-ID: <83990b97-3f37-47f0-9cc6-fdaa730a8df1@linaro.org> Date: Sat, 30 Nov 2024 10:29:38 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 20/31] arm64: dts: qcom: ipq5018: move board clocks to ipq5018.dtsi file To: Dmitry Baryshkov , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Leo Yan , Joseph Gates , Georgi Djakov , Shawn Guo , Stephan Gerhold , Zac Crosby , =?UTF-8?Q?Bastian_K=C3=B6cher?= , Andy Gross , Jeremy McNicoll , Rohit Agarwal , Melody Olvera , Bhupesh Sharma , cros-qcom-dts-watchers@chromium.org, Stephen Boyd , Rajendra Nayak , Martin Botka , Jonathan Marek , Vinod Koul , Tengfei Fan , Fenglin Wu , Neil Armstrong , Abel Vesa , Alexandru Marc Serdeliuc , Vladimir Zapolskiy , Sibi Sankar , Bryan O'Donoghue , Jun Nie , James Willcox , Max Chen , Vincent Knecht , Benjamin Li , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20241130-fix-board-clocks-v2-0-b9a35858657e@linaro.org> <20241130-fix-board-clocks-v2-20-b9a35858657e@linaro.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <20241130-fix-board-clocks-v2-20-b9a35858657e@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 30/11/2024 02:44, Dmitry Baryshkov wrote: > IPQ5018 is one of the platforms where board-level clocks (XO, sleep) > definitions are split between the SoC dtsi file and the board file. > This is not optimal, as the clocks are a part of the SoC + PMICs design. > Frequencies are common for the whole set of devices using the same SoC. > Remove the split and move frequencies to the SoC DTSI file. > > Suggested-by: Bjorn Andersson > Signed-off-by: Dmitry Baryshkov This contradicts DTS coding style and all my existing review. Obviously that's a NAK from me. If you want to merge this patch, please kindly carry my formal objection for this and all following "move board clocks" patches: Nacked-by: Krzysztof Kozlowski (I'll respond in next patches as well, just for formality/b4) Best regards, Krzysztof