From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.216.98 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793206699; b=Tqnmb2F4mjBgdlKtdRIdcU0PD+y/Yg5/zLfH+hXtBHynsoRfmo9R0mQl5lGEIeWhPo6q wdU1pthz6a8jt+WdAceHtWodzhGUo3WsVTk84C+1Q2d/Zxo2Ux83YsX/iAGXMXaZ4iPqA WUX78TNvoCxMuflQbSr0ZsHx/JClVNesNEtlQgYBhHUS5jaOTb/fpMuv7ottL1WAx8VzB j3Z0tqn0ph0CtKuWyzHQpVSltPsbFzwCsSldLaYuBogr9vCnq6q/Gg8CZTHxSKI/5TOLj pvsbYAqIP1LgqVtzB3dAyndzUEuKzoCTePmhnHJYgs9hpyPHrHz443gjuwKn6NLjLbA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793206699; h=DMARC-Filter:Received:X-Google-DKIM-Signature:X-Forwarded-Encrypted: X-Gm-Message-State:X-Gm-Gg:X-Received:Received:X-Relaying-Domain: X-CFilter-Loop:Received:DKIM-Signature:X-Forwarded-Encrypted: X-Received:X-Received:Received:Message-ID:Date:MIME-Version: User-Agent:Subject:To:Cc:References:Content-Language:From:Autocrypt: In-Reply-To:Content-Type:Content-Transfer-Encoding: X-DetectorID-Processed; bh=/fQIsnXR3qpPiAPZg7Jk/FIpBsbfkQ7V9JvvLYl+Aqw=; b=mCB2QnSH+M6m0VTN5RohGvin2We4VurVxK1geJ6PjlHXZLJ7zj/UIU1xjMPPY6z02i2S jCK6yUu7QDWV2mq44hoQqhhoErgV9ZyvojPAHun8R30d/dPKpbZD5QlZxuW0NVgxnkTjG 5gldOfnRX/86YpPmRsIE1yfiUDvdjp9UuLbU4rbDzBy1HZJoxJeXU3i88f6ZI2jqSKOhE X2HWFmkNZVoj0xcVKjVgdvSAZl0SCq0ytx7CpCWtEgpvYql15kzcMXRQT/dIadtcMKtzD ELzc+ZgglUMFcbxxUgBMSQVfp+UC6w/k3mc/Q49XH/0rTaD9SzunUPk58+nDW/JiDMg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass header.d=broadcom.com header.i=@broadcom.com header.a=rsa-sha256 header.s=google header.b=MUdiEcIO; arc=none smtp.remote-ip=209.85.216.98 Received: from mail-pj1-f98.google.com (mail-pj1-f98.google.com [209.85.216.98]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 249E0606A31D for ; Wed, 28 Oct 2026 16:58:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 249E0606A31D Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=broadcom.com header.i=@broadcom.com header.a=rsa-sha256 header.s=google header.b=MUdiEcIO Received: by mail-pj1-f98.google.com with SMTP id 98e67ed59e1d1-3ac9f49b984so782719a91.1 for ; Wed, 28 Oct 2026 09:58:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793206698; x=1793811498; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:dkim-signature:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=/fQIsnXR3qpPiAPZg7Jk/FIpBsbfkQ7V9JvvLYl+Aqw=; b=da8pihHbJnCW29HZPwieRT3lQjDG6tdY9Vzi5XBsm3qGBExTe5aOr+IgLKyow5UlBU 4+CcG0jAiIsd+0wp6fPC/WO24/W50+kp+eMS4y8g/QXLjGGGcEWfyZFVHj6DZUI5MaB1 YimhL610H7Kg1Zhiml1U+0/051B1vJAaMuSfb6H23kyxCLLs753EtoH+S/mZwHOYyKh6 X/JflpMaXf6MVM2WufZU4O34r6GMi+M7aytSXZJ2Tlak/sk6AjHFEbfBnvTuZcxbs/Ix af3Yqi/DuBn362ptllaURxUOXwhN0p56ihbOZWu+L4jg693LkSSAJLCDIFPFeSqehv8d OERg== X-Forwarded-Encrypted: i=1; AKwUvBzM3xP0R451ZswygLICf5BZ2r8/L18NSGlQheA1kwFeFenRwzbwTmG+JLoD/zQLeAfkDKsDsdXewr5W/uc=@vger.kernel.org X-Gm-Message-State: AFq9FYICb4bZ2j8lq/wkOpQuXwtx5PykL6VnRkuWvO/myeX3CnHuUjV3 JANytCuoq4QBKphjXTkstbkMQjEDfvm1aHIz3UIWkbZZ4WOFe3z6TkptkVJqVuYB4xguTJQpaw4 kHVAaDtfaFCgBOXhP15xyodbjtulH1fuL1DS59VAa3aQDqlc45lhlztEVn1v4IY0nD8wkJXDBLz 8ggscbbxXK0tEmnP78xIELqFf48fBaPQP6PTYKdkkUt3bQ58iaqMjlFFPFyIOIArU4FTv2fepss JCMq5S7D3511PtOVVDg9A+G X-Gm-Gg: AYBFou1dt7fDkXDCeJB0iJFG9tXCjw/bFJgtu+uzzaajM8hVXJf3QvsRKXq36lqrjyO A5vHC9Fa1Tg5GXiM8DGGQ5BC6BiMJPI+9Skt0KLNbcyoNoSdEELYON/HaromTiqOAc+JcOBefJc 8gAVlqlAkQriLfd7fJ6fjLQBdev3P5avRAMukOxDnU0wqowrma9w7MiUiBKYQQDXV0opPxkriRI QsLdtJpE/09H9K9rKpU/2B9fXONWcRZAJRWUVtI8W9aneIrSlAmfch5+AfyOo0b6wOjIXT4B7EX yXghyd5LcNMSLB5U1yaSTHTRclUvFBvSZzr/ktXCw1GJf/dvNXRkEouTjmIgBoxYI1UJOAFZujc i/Vy2O0GmQQpWAQ+9VB74PSe6igZw8m0GY4lEGI34Q6/2rqeyQCOLQD7rszaTc3dI+uIFYrGPF+ 5u0IbFC0lqffsuFJZ4grgKD86FM/K7Qc/6yavPPdLcxlA= X-Received: by 2002:a17:90b:33c8:b0:3ac:a6a5:5757 with SMTP id 98e67ed59e1d1-3ae6ecfeff0mr63907a91.11.1793206698315; Wed, 28 Oct 2026 09:58:18 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-120.dlp.protect.broadcom.com. [144.49.247.120]) by smtp-relay.gmail.com with ESMTPS id 98e67ed59e1d1-3ae6e70a4c5sm139451a91.3.2026.10.28.09.58.16 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 28 Oct 2026 09:58:18 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-944101e6367so77828785a.1 for ; Wed, 28 Oct 2026 09:58:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1793206696; x=1793811496; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=/fQIsnXR3qpPiAPZg7Jk/FIpBsbfkQ7V9JvvLYl+Aqw=; b=MUdiEcIOvKQz0F+pTXiifrXrWAT2jiTavUa3R5hAo6uq0v6ZfR0uw78TRh8spXQ3sw F5OKLu+0ja4uZzgDWQyHt5G+DsHhZGIKfeFBYnNyQUZmDZYOrAbjsSK8f185nAxthWg9 QPc0eJNswSnvv0fArK90IvKXlNs4QoiUIh8FM= X-Forwarded-Encrypted: i=1; AKwUvBxy8L1imVGQ5/DFREWOyaBH9jLm2ePsFkzkLaprUw8fxMc6apFPNWIQB7Q/DraCJDa2obt0ujf1Em9PxOw=@vger.kernel.org X-Received: by 2002:a05:620a:3185:b0:943:e872:f521 with SMTP id af79cd13be357-94413358c99mr22450185a.9.1793206696097; Wed, 28 Oct 2026 09:58:16 -0700 (PDT) X-Received: by 2002:a05:620a:3185:b0:943:e872:f521 with SMTP id af79cd13be357-94413358c99mr22447085a.9.1793206695624; Wed, 28 Oct 2026 09:58:15 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id af79cd13be357-940f067c2e2sm1300362085a.18.2026.10.28.09.58.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Oct 2026 09:58:14 -0700 (PDT) Message-ID: <839ca732-c2a5-451b-bc9b-58afaaa01121@broadcom.com> Date: Wed, 28 Oct 2026 09:58:12 -0700 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net 3/5] net: dsa: b53: clear stale state when creating an ARL entry To: Jonas Gorski Cc: netdev@vger.kernel.org, Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Russell King , "Russell King (Oracle)" , open list References: <20261027202230.3539646-1-florian.fainelli@broadcom.com> <20261027202230.3539646-4-florian.fainelli@broadcom.com> Content-Language: en-US, fr-FR From: Florian Fainelli Autocrypt: addr=florian.fainelli@broadcom.com; keydata= xsBNBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAHNMEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPsLB IQQQAQgAywUCZWl41AUJI+Jo+hcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFr ZXktdXNhZ2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2Rp bmdAcGdwLmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29t Lm5ldAUbAwAAAAMWAgEFHgEAAAAEFQgJChYhBNXZKpfnkVze1+R8aIExtcQpvGagAAoJEIEx tcQpvGagWPEH/2l0DNr9QkTwJUxOoP9wgHfmVhqc0ZlDsBFv91I3BbhGKI5UATbipKNqG13Z TsBrJHcrnCqnTRS+8n9/myOF0ng2A4YT0EJnayzHugXm+hrkO5O9UEPJ8a+0553VqyoFhHqA zjxj8fUu1px5cbb4R9G4UAySqyeLLeqnYLCKb4+GklGSBGsLMYvLmIDNYlkhMdnnzsSUAS61 WJYW6jjnzMwuKJ0ZHv7xZvSHyhIsFRiYiEs44kiYjbUUMcXor/uLEuTIazGrE3MahuGdjpT2 IOjoMiTsbMc0yfhHp6G/2E769oDXMVxCCbMVpA+LUtVIQEA+8Zr6mX0Yk4nDS7OiBlvOwE0E U8AbwQEIAKxr71oqe+0+MYCc7WafWEcpQHFUwvYLcdBoOnmJPxDwDRpvU5LhqSPvk/yJdh9k 4xUDQu3rm1qIW2I9Puk5n/Jz/lZsqGw8T13DKyu8eMcvaA/irm9lX9El27DPHy/0qsxmxVmU pu9y9S+BmaMb2CM9IuyxMWEl9ruWFS2jAWh/R8CrdnL6+zLk60R7XGzmSJqF09vYNlJ6Bdbs MWDXkYWWP5Ub1ZJGNJQ4qT7g8IN0qXxzLQsmz6tbgLMEHYBGx80bBF8AkdThd6SLhreCN7Uh IR/5NXGqotAZao2xlDpJLuOMQtoH9WVNuuxQQZHVd8if+yp6yRJ5DAmIUt5CCPcAEQEAAcLB gQQYAQIBKwUCU8AbwgUbDAAAAMBdIAQZAQgABgUCU8AbwQAKCRCTYAaomC8PVQ0VCACWk3n+ obFABEp5Rg6Qvspi9kWXcwCcfZV41OIYWhXMoc57ssjCand5noZi8bKg0bxw4qsg+9cNgZ3P N/DFWcNKcAT3Z2/4fTnJqdJS//YcEhlr8uGs+ZWFcqAPbteFCM4dGDRruo69IrHfyyQGx16s CcFlrN8vD066RKevFepb/ml7eYEdN5SRALyEdQMKeCSf3mectdoECEqdF/MWpfWIYQ1hEfdm C2Kztm+h3Nkt9ZQLqc3wsPJZmbD9T0c9Rphfypgw/SfTf2/CHoYVkKqwUIzI59itl5Lze+R5 wDByhWHx2Ud2R7SudmT9XK1e0x7W7a5z11Q6vrzuED5nQvkhAAoJEIExtcQpvGagugcIAJd5 EYe6KM6Y6RvI6TvHp+QgbU5dxvjqSiSvam0Ms3QrLidCtantcGT2Wz/2PlbZqkoJxMQc40rb fXa4xQSvJYj0GWpadrDJUvUu3LEsunDCxdWrmbmwGRKqZraV2oG7YEddmDqOe0Xm/NxeSobc MIlnaE6V0U8f5zNHB7Y46yJjjYT/Ds1TJo3pvwevDWPvv6rdBeV07D9s43frUS6xYd1uFxHC 7dZYWJjZmyUf5evr1W1gCgwLXG0PEi9n3qmz1lelQ8lSocmvxBKtMbX/OKhAfuP/iIwnTsww 95A2SaPiQZA51NywV8OFgsN0ITl2PlZ4Tp9hHERDe6nQCsNI/Us= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e On 10/28/26 02:52, Jonas Gorski wrote: > On Tue, Oct 27, 2026 at 9:22 PM Florian Fainelli > wrote: >> >> When an ARL lookup does not find the requested MAC and VID, b53_arl_read() >> returns the first free bin index but leaves the entry populated with the >> last bin examined. The multicast add path then ORs the requested port into >> that unrelated entry's forwarding bitmap, potentially forwarding packets >> to ports which are not members of the multicast group. >> >> Clear the entry before creating a new one. Also return without writing >> anything when deleting an entry which is not present, instead of making >> a new entry from stale bin contents. >> >> Fixes: 5d65b64a3d97 ("net: dsa: b53: Add support for MDB") >> Signed-off-by: Florian Fainelli >> --- >> drivers/net/dsa/b53/b53_common.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/drivers/net/dsa/b53/b53_common.c b/drivers/net/dsa/b53/b53_common.c >> index 559d4b360c82..0871a10d8cbc 100644 >> --- a/drivers/net/dsa/b53/b53_common.c >> +++ b/drivers/net/dsa/b53/b53_common.c >> @@ -1992,6 +1992,10 @@ static int b53_arl_op(struct b53_device *dev, int op, int port, >> addr, vid); >> return is_valid ? ret : 0; >> case -ENOENT: >> + if (!is_valid) >> + return 0; > > Should we return 0, or should we pass on the -ENOENT? We failed to > remove the entry, so implies there was a desync between hardware state > and software state. > > If we don't, we should at least report the issue. If we do, we don't > need to, as dsa will do that. Though we then should also report > -ENOSPC && !is_valid as -ENOENT. > > Likewise when trying to add an entry that already exists. Agreed, returning -ENOENT seems preferable so the missing hardware entry is visible to the caller. I'll propagate it for the -ENOENT case and translate -ENOSPC to -ENOENT when deleting. For additions, finding an existing MAC/VID is not necessarily a desynchronization: an FDB add may move an entry or make a dynamically learned entry static, and an MDB add may extend the port bitmap. So I think we should retain the existing update behavior rather than return -EEXIST on a lookup match. > >> + >> + memset(&ent, 0, sizeof(ent)); > > Just bikeshedding, but semantically it feels the memset should be > below the comment/dev_dbg(). Yes, I took that change. Thanks! -- Florian