mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Yunfeng Ye <yeyunfeng@huawei.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	kernel-janitors@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Shiyuan Hu <hushiyuan@huawei.com>,
	Hewenliang <hewenliang4@huawei.com>,
	Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH v4] tools/bootconfig: Completion of error handling
Date: Fri, 8 May 2020 17:42:22 +0200	[thread overview]
Message-ID: <839d6c0f-4c77-d8f4-3aff-c5762190c57e@web.de> (raw)
In-Reply-To: <bdda096b-9f8a-dacb-9f89-9077d1288ad7@huawei.com>

…
> +++ b/tools/bootconfig/main.c
> @@ -314,31 +314,35 @@ int apply_xbc(const char *path, const char *xbc_path)
…
> +close_fd:
>  	close(fd);

Do analysis tools point any software development concerns out
at this source code place?
https://wiki.sei.cmu.edu/confluence/display/c/ERR33-C.+Detect+and+handle+standard+library+errors#ERR33-C.Detectandhandlestandardlibraryerrors-AutomatedDetection

Regards,
Markus

      parent reply	other threads:[~2020-05-08 15:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-08 12:09 [PATCH v4] tools/bootconfig: fix resource leak in apply_xbc() Yunfeng Ye
2020-05-08 13:42 ` Markus Elfring
2020-05-08 14:40 ` Dan Carpenter
2020-05-08 14:51   ` Dan Carpenter
2020-05-08 15:42 ` Markus Elfring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=839d6c0f-4c77-d8f4-3aff-c5762190c57e@web.de \
    --to=markus.elfring@web.de \
    --cc=dan.carpenter@oracle.com \
    --cc=hewenliang4@huawei.com \
    --cc=hushiyuan@huawei.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=yeyunfeng@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®