From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-186.mta0.migadu.com (out-186.mta0.migadu.com [91.218.175.186]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 016B82DECBA for ; Thu, 28 May 2026 14:43:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.186 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779979424; cv=none; b=N23tb3KigRiHwGy/Z+/QCgHGKTDdirxBmWRHHAwRriEsYjpTf62envMJdO4XWvARq6JZdFbWk5RC0b4zahZij0l/H9Bgu3MjxH8ecnMTuXmeTcWeDRcEHXztc81lOAnGcpFd1fHcRXWgJIgpVgXanPC0iL0tR0gjUn087zFDuIg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779979424; c=relaxed/simple; bh=Vs3UZhejCP7M3WNl07lNDZiA338tln6vrRwMvzU/AUU=; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc: Message-Id:References:To; b=a4ASj6N4me3nzGARZXXiYdNTou3qvB+qKM7fAc/CeByj9l85I64ND9BYDZgn3PAdIh3JukVLa9hkU0gRndbzobnjPB3ZmA0cZG0cUq8KakkmOLbHT7f1279htxOAKhQhNgEEOqzMfKHIPH/5iD9nsRCw78uzZXUHDeFdBXAxxvo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=UFA0TctB; arc=none smtp.client-ip=91.218.175.186 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="UFA0TctB" Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1779979421; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JaKylE9tmtxoDlvo1H6WypisSB7E9IbupaqeU2jxRQk=; b=UFA0TctBDoJctOHOsP80cIuOFeSA66cIPh1Azl9LETzBIkMwxe/ebMG53bjcMzoCC5tRVX uKP5vrf0O+p9HzNa1tStAw2NKP9KWd5O/MGfVsHSy/pa1ZWNeLUyMrQIU0HSHXygfLz9q3 +uH7ft1SDabLwk+BS+qTxDas3b5SyT0= Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.600.51.1.1\)) Subject: Re: [PATCH 0/9] Convert x86 pgd_lists to ptdescs X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: William Kucharski In-Reply-To: <20260527140316.294621-1-vishal.moola@gmail.com> Date: Thu, 28 May 2026 08:43:25 -0600 Cc: Dave Hansen , linux-mm@kvack.org, linux-kernel@vger.kernel.org, x86@kernel.org, Mike Rapoport , Lu Baolu , xen-devel@lists.xenproject.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Boris Ostrovsky Content-Transfer-Encoding: quoted-printable Message-Id: <83A6AC90-A51D-4E1E-9ADA-50195FA2485A@linux.dev> References: <20260527140316.294621-1-vishal.moola@gmail.com> To: Vishal Moola X-Migadu-Flow: FLOW_OUT Looks great! Reviewed-by: William Kucharski > On May 27, 2026, at 08:03, Vishal Moola = wrote: >=20 > This continues the ptdesc conversions for x86[1]. This is a necessary = step > in preparation for the separate allocation of ptdescs from struct = page. > Once ptdescs are not wrappers, the pgd_list should be used to find our > ptdesc, not page. >=20 > In fact, after patch 4 we can successfully boot a 32-bit x86 kernel > that separately allocates ptdescs. >=20 > All of the patches are rather straightforward, I just kept them split = up > for ease of review. There are no intended functional changes as = ptdescs > are currently still wrappers around struct page. >=20 > [1] = https://lore.kernel.org/linux-mm/20260211195233.368497-1-vishal.moola@gmai= l.com/ >=20 > ---------------- >=20 > I've compiled and booted both 64 and 32 bit on a kernel with = separately > allocated ptdescs. I ensured the codepaths were hit for all the = changes > except Xen. >=20 > This applies cleanly to the tip bot. I'm thinking this can go through > Dave's mm. >=20 > Vishal Moola (9): > x86/mm/pat: Use IS_ENABLED() instead of ifdef > x86/mm/pat: Convert __set_pmd_pte() to ptdescs > x86/mm/pat: Convert collapse_pmd_page() to ptdescs > x86/mm: Convert arch_sync_kernel_mappings() to ptdescs > x86/mm: Convert sync_global_pgds_l5() to ptdescs > x86/mm: Convert sync_global_pgds_l4() to ptdescs > x86/mm: Convert pgd_page_get_mm() to ptdescs > x86/xen: Convert xen_mm_pin_all() to ptdescs > x86/xen: Convert xen_mm_unpin_all() to ptdescs >=20 > arch/x86/include/asm/pgtable.h | 2 +- > arch/x86/include/asm/pgtable_types.h | 2 +- > arch/x86/mm/fault.c | 8 ++++---- > arch/x86/mm/init_64.c | 16 ++++++++-------- > arch/x86/mm/pat/set_memory.c | 17 ++++++++--------- > arch/x86/mm/pgtable.c | 4 ++-- > arch/x86/xen/mmu_pv.c | 22 +++++++++++----------- > 7 files changed, 35 insertions(+), 36 deletions(-) >=20 > --=20 > 2.54.0 >=20 >=20