From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752990AbdF0R2o convert rfc822-to-8bit (ORCPT <rfc822;w@1wt.eu>);
        Tue, 27 Jun 2017 13:28:44 -0400
Received: from coyote.holtmann.net ([212.227.132.17]:42734 "EHLO
        mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752059AbdF0R2n (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 27 Jun 2017 13:28:43 -0400
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Re: 4.12.0-rc6+: WQ_MEM_RECLAIM hci0:hci_power_off is flushing
 !WQ_MEM_RECLAIM events:btusb_work
From: Marcel Holtmann <marcel@holtmann.org>
In-Reply-To: <20170627152032.GA2289@htj.duckdns.org>
Date: Tue, 27 Jun 2017 19:28:40 +0200
Cc: Dominik Brodowski <linux@dominikbrodowski.net>,
        "Gustavo F. Padovan" <gustavo@padovan.org>,
        Johan Hedberg <johan.hedberg@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>, linux-bluetooth@vger.kernel.org
Content-Transfer-Encoding: 8BIT
Message-Id: <83EA7A09-DDFB-4CEB-8F45-52BFDCE3C6DF@holtmann.org>
References: <20170625182149.GA18000@light.dominikbrodowski.net>
 <20170627152032.GA2289@htj.duckdns.org>
To: Tejun Heo <tj@kernel.org>
X-Mailer: Apple Mail (2.3273)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Tejun,

>> On my Dell XPS 13 9343 (x86_64), the following warning was logged right
>> after a resume from suspend-to-mem (not on *every* resume, though, so it
>> might be hard to reproduce). The kernel is v4.12.0-rc6+ as of 94a6df251dd0,
>> and I don't really use bluetooth, though the drivers are loaded:
>> 
>> PM: Finishing wakeup.
>> OOM killer enabled.
>> Restarting tasks ... done.
>> Bluetooth: hci0: read Intel version: 370710018002030d00
>> Bluetooth: hci0: Intel Bluetooth firmware file: intel/ibt-hw-37.7.10-fw-1.80.2.3.d.bseq
>> Bluetooth: hci0: Intel Bluetooth firmware patch completed and activated
>> ... <more, unrelated messages>
>> workqueue: WQ_MEM_RECLAIM hci0:hci_power_off is flushing !WQ_MEM_RECLAIM events:btusb_work
> 
> So, WQ_MEM_RECLAIM has to be transitive; otherwise, it doesn't mean
> anything.  I have a hard time believing that bluetooth actually needs
> WQ_MEM_RECLAIM unless people mount nfs through a bluetooth tethered
> phone.  Would it be possible to remove WQ_MEM_RECLAIM from these
> workqueues?

frankly I do not remember. We used what was recommended to use. I know that the only requirement in one case is that it is a truly single workqueue.

Regards

Marcel