From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC4B134751D for ; Wed, 20 May 2026 11:40:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779277231; cv=none; b=VD6IzaWdJrn7Mj6O0HrCiULGimTSbpILz4XkU++2iqAwFSihX+iB1SWL/jUGIW1O46RFlz/DFiGe6wcV7+dlZXgnSWpB6zYTziK6SLsM7nhZugq7iGyCcg4MmX1q9O8tLsr3ljRan7QHoYaN+lO/CfQhZ/tC7rgEVeN9Uyc3Fj4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779277231; c=relaxed/simple; bh=5mweL13Xvi7aC3ka9r7V/CZE6DjWraUDvHAd/V7OHVU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KvMlgWJK8vngMaU7/rtRaBXUa6tvY+Hnz0MHYkgmXY16xX6n2atrSc89ereUvDK1G5xjDQDNXxo29wwqczIBhTkVdNVW/X4W6vN/WukMU1uAuZ0nv4AnYNpdFayKb18/DyS6sb/W9NtkaoqpPKrhfUhqMguT5GRgnJ8ArUUsVcI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bjaqrLMR; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=duOsTEg6; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bjaqrLMR"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="duOsTEg6" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64K7VsNd1636919 for ; Wed, 20 May 2026 11:40:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= NKD+goykCEWe7P3VDwM4HDQDAaDkCtngcJEhO1J07pU=; b=bjaqrLMRChx1UJAj B8kV6Gb1S5Me1buGmKtvQPqBHfGBXfSoV06zU6alnNvX0KF5+z23Eekr4Wrlq8iz Ah0vk5Uj4wsTc7cp6HxLGhQluy43lVbXKca6T7Im8cPk2avrvUuScNc5hlpzPI6q 50PaMy0x0MhPQzfiYA9YNyNHl9QkOmn61jC2Q3xjwqSJcSK7IFYLAPp2GzawaZ2Z EG94rlNTD4ILMYuK5els/mADZt9F6TMjJ8G+KNTsrWO/cKzyCIAs8xrPm/GLM0Wx dr7e6RQSg5BE9YwgmXV+EucH1wZOlzLk+GqNfGWz6O27c9KauOBhxkKDEQVyPg5p HBTk1A== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e8t3scdd2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 20 May 2026 11:40:27 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-50faf575af4so127134551cf.0 for ; Wed, 20 May 2026 04:40:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779277227; x=1779882027; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=NKD+goykCEWe7P3VDwM4HDQDAaDkCtngcJEhO1J07pU=; b=duOsTEg6yNaGqUhPdDr9Pur8kpqMOtxVz/a0Y3zMQrXTAXW4L6ovLt6BUMjVpuinIC wGxDP9rsqdsrV+VgYBJEB5/qjssG8MdkreW66dE71RgBLQI2QYQHyvNu4czx3/FutWpM 6rgm8g1X8dvOPeF6YwCU26PF3GhfE5KgkcGG3WL8/9b/kzy+7k96WN4BbvXZspY/nvoS eItg5WGQiMGVezlDYTXENzNT/IL5sXUGY9xfcQlAHDkhr5xmb/AXSgNihDrjfm2kTnby XidFaOzYodKO6c1lvcCsjeN0Bu098KdOb5euZmGKv/66h/KTqZI770GiyG/fq58yRvnq v1mQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779277227; x=1779882027; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NKD+goykCEWe7P3VDwM4HDQDAaDkCtngcJEhO1J07pU=; b=W0sSAEko0rAeZzy6We2OgIhhOG9pQ1EIeawACrltjBtDKNuFc8Xdxz+Ir6jgulsxB8 AXyRIxDfKGFP1CeojsWE761cQSLoEC7LNV7CQw6MQGP0+x/eJmypuwSZ0WGWtG18qulN LyBmzSFy4jDOxjLyNp4LH8a/NIyS+6vYc978Q37CdYPeOjMaGUOHWLwHEsh2CNiFYojD bUTAlfRrJzUzhrOwc1yGI28bZtjA2hZgkHatFofxTD50tb7PISe36QcTtSMMrU8FgpoO QLpQ8GGJGDEcJkCPjLY3DBpQ+wlD2KdeEP/KRu4LbFqq54ywKoJaB+T9BbPTBl4/6s8L hFWw== X-Forwarded-Encrypted: i=1; AFNElJ+65/ZS1o3KCClG8TsPFE9pCM3uwEJsfm7FJ0A3fCZZ39hbJovrwXGbvNblc0ouobWfaT8AO3vfJ1qhBMk=@vger.kernel.org X-Gm-Message-State: AOJu0YyjUbnf2WcQfxyvwF3nbTxthW2644c7DPqRlOX1fcOZD+TLKk8N FoQH+iG3bNgI4fHOMkOqdOi/aJDXNv3LE1nXYGwq3DD1mvRTT0oBF1uyLUu/HzVFP6D9n5HSNce 2boXSBniTA9b9RuUlH1wzLPOnFW2OiUWJUnjxtPGBkUrLyan2c+QEnAGLX0KnZAPS3No= X-Gm-Gg: Acq92OFS7PjcuL1uLrLEE9Oh1nDU92XKwcMOC/ODtZopr5e2Vh7p7T4i1cqYfyH9TQC VNl5fQNuFF2mCVEfxV9d4vkVu6dyQ8n+I310kFQTsuZYhEU9x+FOW8HWOaCDyZZvNPDdwbenpGP S76O9uzQmel/FKM+0r3f7yXppLM6YynGEVJUktfk/3ttFrGbzGaCY5+uSjiEt8vumRR52Xf5RQz Ub2Nni/E9FjLoWTZVtZcR29ZQsum2u67QlmdyPmvATVHmJRB86ULvypTh+a2rNNvHWJnmfvryv4 U57wCUxjTiJJRJQy2bWpJ7PkTlP7rMySxWxQsezq+CE6j1FQeUouK9Az4xaoECzD6y1YYrNZTua hjy4oI9B9+IueJgpIIz1IRAH7rcdZR65Dio3wFCAMTV5zeYuE X-Received: by 2002:a05:622a:5c9a:b0:50d:8056:da41 with SMTP id d75a77b69052e-5165a002bd4mr327620051cf.2.1779277227245; Wed, 20 May 2026 04:40:27 -0700 (PDT) X-Received: by 2002:a05:622a:5c9a:b0:50d:8056:da41 with SMTP id d75a77b69052e-5165a002bd4mr327619641cf.2.1779277226827; Wed, 20 May 2026 04:40:26 -0700 (PDT) Received: from [192.168.68.125] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-48fe537c788sm372948175e9.12.2026.05.20.04.40.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 May 2026 04:40:25 -0700 (PDT) Message-ID: <83a1cb82-add9-4896-8fa2-8550822b795a@oss.qualcomm.com> Date: Wed, 20 May 2026 12:40:24 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V6 5/5] arm64: dts: qcom: glymur-crd: add Audio sound card node To: Krzysztof Kozlowski , Sibi Sankar , robh@kernel.org, srini@kernel.org, amahesh@qti.qualcomm.com, krzk+dt@kernel.org, conor+dt@kernel.org, andersson@kernel.org, konradybcio@kernel.org Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Mohammad Rafi Shaik , Konrad Dybcio References: <20260325035338.1393287-1-sibi.sankar@oss.qualcomm.com> <20260325035338.1393287-6-sibi.sankar@oss.qualcomm.com> Content-Language: en-US From: Srinivas Kandagatla In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTIwMDExMiBTYWx0ZWRfX2RTDNbDqj0Ma MyHBLh+9l0EFMZ8+n0Zws2UYvGRDFexC00aG9ZVPtTyz0phzqLiuRvTR8QOAQyCDcGDPYIRe6eu bdwbKYLsEYy9bfuLOq8AtQKeCRy8SLiQFNojyTiWkjqJnEDYgpxB9Fd1K9q0YfPpS2vX2gpbk00 Cjg1ZGivIjWkibDsUurIZ9InuhG+z6jj1YRaJANU+5rgfwSi7Xt0Hs5YDPjdzA2ApV3mTIZWjH7 AqW9PNedAk8LC/FyDiBsZUPnzCv73rFJkqafylHRZ8c1xuetGhH7iPjGrzn/4w9oDtdo7VBYnng LhSuBYQbQerNMrbKq4iibI5Nq8+5OiIoAehFMo6Y82ZmhXK4AZvSFEVncDDtHoIFdekzplLiPs8 GbJKdIGgXsKR9FHx0g3TLPePGwkXfD27/8giiNDQqye00ZDoXg7XdIVRGQDFHpaApmQkzT8JY2L 5Kr3XujyS0TSLKYM5fA== X-Authority-Analysis: v=2.4 cv=Oc6oyBTY c=1 sm=1 tr=0 ts=6a0d9dab cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=7MBKnE05AAAA:20 a=EUspDBNiAAAA:8 a=Wz4qH61WVlOTaqajxdAA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 a=bA3UWDv6hWIuX7UZL3qL:22 X-Proofpoint-GUID: btYYOoN9zntkRkpKygdt3Q8KfjQb36HS X-Proofpoint-ORIG-GUID: btYYOoN9zntkRkpKygdt3Q8KfjQb36HS X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-20_02,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 clxscore=1015 bulkscore=0 malwarescore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 phishscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605200112 On 5/20/26 12:29 PM, Krzysztof Kozlowski wrote: > On 25/03/2026 04:53, Sibi Sankar wrote: >> From: Srinivas Kandagatla >> >> Add the sound card of Glymur-crd board with the routing for speakers. >> >> Add device nodes for the sound support with WSA884x smart speakers >> and playback via speakers and recording via DMIC microphones. >> >> Co-developed-by: Mohammad Rafi Shaik >> Signed-off-by: Mohammad Rafi Shaik >> Signed-off-by: Srinivas Kandagatla >> Reviewed-by: Konrad Dybcio >> --- >> arch/arm64/boot/dts/qcom/glymur-crd.dtsi | 110 +++++++++++++++++++++++ >> 1 file changed, 110 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/glymur-crd.dtsi b/arch/arm64/boot/dts/qcom/glymur-crd.dtsi >> index 690b90e3d6ce..88a5c63e8ac2 100644 >> --- a/arch/arm64/boot/dts/qcom/glymur-crd.dtsi >> +++ b/arch/arm64/boot/dts/qcom/glymur-crd.dtsi >> @@ -118,6 +118,54 @@ vreg_wwan: regulator-wwan { >> pinctrl-0 = <&wwan_reg_en>; >> pinctrl-names = "default"; >> }; >> + >> + sound { >> + compatible = "qcom,glymur-sndcard"; >> + model = "glymur-crd"; > > That's not the name which was already used in Audioreach topology and > maybe other places. I agree this should be GLYMUR-CRD as per https://github.com/linux-msm/audioreach-topology/blob/main/CMakeLists.txt#L24 --srini > > While it is fine to use whatever case you wish, please also fix that > users of this name. > > Best regards, > Krzysztof