From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mta1.migadu.com (out-166.mta1.migadu.com [95.215.58.166]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E345C303C8A for ; Mon, 24 Aug 2026 01:21:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.166 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787534473; cv=none; b=avB9OjByAaeTdnApJ/FLUyyAox3a6azKy5bXGJR52UQbS821Oqv4Pe4KKnI81wbQWX89m5nVYekd+Vl8mhqM4pzMWnMugYTYaB4ASgyuklzDi/8nikOkwbaX2T50BhsrnwZ2Bau573DiftKDQSicUGI19jPKwEhrn4rjo5JboR0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787534473; c=relaxed/simple; bh=tHKh+slTFpiPiOoeSf2ClsDax09mea19PvArh25qvpg=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=ORhnuo8w3mFG6d/PdaDjID5FxufueqmkLV/YvtOfbtdhZSBiQpoQo0j9ZcN4xav2ZuWxJ2OC/eiDCRnPB2IByK+QmlTfboOSVno7zOVlNE25CuRiioxNXjjGhcZGu6AieLt36CpbC8QEXkUS1KgwDvj7mVhUio/UjDIiXaSzXSA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=pvt/GwiD; arc=none smtp.client-ip=95.215.58.166 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="pvt/GwiD" X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=tHKh+slTFpiPiOoeSf2ClsDax09mea19PvArh25qvpg=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1787534466; v=1; x=1788139266; b=pvt/GwiDwjQIAl37VQnFXqgB6pOgfN0uLdnNkkNRyinTZ/AHQ8mzanaTQYhc5l+5kg/dd2qo urRE7IHmrpePIs8wZmy6kJyqRqfM1/oiGRmMne6j6uqRmGXWU4ifxU9hZy+/k9YNbjzObZJI+8x UvW1x1SodL6jdwQYtaJUvbwM= X-Envelope-To: linux-kernel@vger.kernel.org Received: from [192.168.109.123] (223.70.159.239) by smtp.migadu.com with ESMTPS id 545dad8447bb8b3c; Mon, 24 Aug 2026 01:20:56 +0000 X-Mizu-Trace-ID: 545dad8447bb8b3c X-Migadu-Flow: FLOW_OUT Message-ID: <83a8c88a-54a6-4ebf-a5b4-a44e1d06a7d9@linux.dev> Date: Mon, 24 Aug 2026 09:20:49 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: hongfu.li@linux.dev, Andrew Morton , Alexander Graf , Pasha Tatashin , Hongfu Li , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/memblock: simplify reserve_mem_init error handling To: Mike Rapoport , Sang-Heon Jeon References: <20260821033230.55210-1-hongfu.li@linux.dev> <20260822032327.3548986-1-ekffu200098@gmail.com> From: Hongfu Li In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 8/23/26 10:30 PM, Mike Rapoport wrote: > On Sat, Aug 22, 2026 at 12:23:23PM +0900, Sang-Heon Jeon wrote: >> On Fri, Aug 21, 2026 at 11:32:30AM +0800, Hongfu Li wrote: >>> Return prepare_kho_fdt() directly instead of assigning to a local and >>> returning it on both success and failure paths. >> Thanks for the patch, but the same change was already posted [1]. >> As mentioned in the cover letter, I can send it as a separate patch >> if needed. > Please send it as as separate patch, as Mark requested. > > Hongfu, I'm planning take that one because he was the first. OK, understood. I withdraw this patch. Thanks. >> [1] https://lore.kernel.org/all/20260723184538.3888637-37-ekffu200098@gmail.com/ >> >> Best Regards, >> Sang-Heon Jeon -- Best regards, Hongfu