From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752207AbeFEPeF (ORCPT ); Tue, 5 Jun 2018 11:34:05 -0400 Received: from foss.arm.com ([217.140.101.70]:57562 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751886AbeFEPeD (ORCPT ); Tue, 5 Jun 2018 11:34:03 -0400 Cc: Sudeep Holla , ACPI Devel Maling List , "Rafael J . Wysocki" , Catalin Marinas , Jeremy Linton , Morten Rasmussen , Linux ARM , Linux Kernel Mailing List , Hanjun Guo , Geert Uytterhoeven Subject: Re: [PATCH v2 2/3] ACPI / PPTT: fix build when CONFIG_ACPI_PPTT is not enabled To: "Rafael J. Wysocki" References: <1528209304-3280-1-git-send-email-sudeep.holla@arm.com> <1528209304-3280-2-git-send-email-sudeep.holla@arm.com> From: Sudeep Holla Organization: ARM Message-ID: <83b1b038-c4c1-0199-2cb0-fb5343f0e3f5@arm.com> Date: Tue, 5 Jun 2018 16:33:59 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/06/18 16:00, Rafael J. Wysocki wrote: > On Tue, Jun 5, 2018 at 4:35 PM, Sudeep Holla wrote: >> Though CONFIG_ACPI_PPTT is selected by platforms and nor user visible, >> it may be useful to support the build with CONFIG_ACPI_PPTT disabled. >> >> This patch adds the missing dummy/boiler plate implementation to fix >> the build. >> >> Cc: "Rafael J. Wysocki" >> Signed-off-by: Sudeep Holla >> --- >> include/linux/acpi.h | 15 +++++++++++++++ >> include/linux/cacheinfo.h | 2 +- >> 2 files changed, 16 insertions(+), 1 deletion(-) >> >> Hi Rafael, >> >> If you are fine with this, can you provide Ack, so that we route this >> through ARM64 tree where most of the ACPI PPTT support is present. >> >> Regards, >> Sudeep >> >> v1->v2: >> - removed duplicate definition for acpi_find_last_cache_level >> >> diff --git a/include/linux/acpi.h b/include/linux/acpi.h >> index 8f2cdb0eca71..4b35a66383f9 100644 >> --- a/include/linux/acpi.h >> +++ b/include/linux/acpi.h >> @@ -1299,8 +1299,23 @@ static inline int lpit_read_residency_count_address(u64 *address) >> } >> #endif >> >> +#ifdef CONFIG_ACPI_PPTT >> int find_acpi_cpu_topology(unsigned int cpu, int level); >> int find_acpi_cpu_topology_package(unsigned int cpu); >> int find_acpi_cpu_cache_topology(unsigned int cpu, int level); >> +#else >> +static inline int find_acpi_cpu_topology(unsigned int cpu, int level) >> +{ >> + return -EINVAL; > > Why -EINVAL? > I am not sure either. I used to return -ENOTSUPP, but IIRC someone suggested to use it only for syscalls. Also I just based it on other existing functions in acpi.h I am open for any alternatives if you think that is better here. -- Regards, Sudeep