From: John Johansen <john.johansen@canonical.com>
To: Yang Li <yang.lee@linux.alibaba.com>,
paul@paul-moore.com, jmorris@namei.org, serge@hallyn.com
Cc: apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next 1/2] apparmor: Fix one kernel-doc comment
Date: Sun, 19 Nov 2023 01:09:07 -0800 [thread overview]
Message-ID: <83b3c0ea-6e17-4fec-8887-0691e7d84185@canonical.com> (raw)
In-Reply-To: <20231023011124.19034-1-yang.lee@linux.alibaba.com>
On 10/22/23 18:11, Yang Li wrote:
> Fix one kernel-doc comment to silence the warnings:
> security/apparmor/domain.c:46: warning: Function parameter or member 'to_cred' not described in 'may_change_ptraced_domain'
> security/apparmor/domain.c:46: warning: Excess function parameter 'cred' description in 'may_change_ptraced_domain'
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7036
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
sorry I missed replying to this. It was pulled into apparmor-next and merged upstream during the 6.7 merge window
> ---
> security/apparmor/domain.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/apparmor/domain.c b/security/apparmor/domain.c
> index ed4a13d44894..89fbeab4b33b 100644
> --- a/security/apparmor/domain.c
> +++ b/security/apparmor/domain.c
> @@ -31,7 +31,7 @@
>
> /**
> * may_change_ptraced_domain - check if can change profile on ptraced task
> - * @cred: cred of task changing domain
> + * @to_cred: cred of task changing domain
> * @to_label: profile to change to (NOT NULL)
> * @info: message if there is an error
> *
prev parent reply other threads:[~2023-11-19 9:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-23 1:11 Yang Li
2023-10-23 1:11 ` [PATCH -next 2/2] apparmor: Fix some kernel-doc comments Yang Li
2023-11-19 9:09 ` John Johansen
2023-11-19 9:09 ` John Johansen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83b3c0ea-6e17-4fec-8887-0691e7d84185@canonical.com \
--to=john.johansen@canonical.com \
--cc=abaci@linux.alibaba.com \
--cc=apparmor@lists.ubuntu.com \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=serge@hallyn.com \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®