From: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
To: Loic Poulain <loic.poulain@oss.qualcomm.com>,
Jeff Johnson <jjohnson@kernel.org>
Cc: wcn36xx@lists.infradead.org, linux-kernel@vger.kernel.org,
"Dr. David Alan Gilbert" <linux@treblig.org>
Subject: Re: [PATCH] wifi: wcn36xx: Remove unused wcn36xx_smd_update_scan_params
Date: Thu, 9 Oct 2025 17:08:49 -0700 [thread overview]
Message-ID: <83b4ff7d-2443-4ba9-8103-77c8dde518f2@oss.qualcomm.com> (raw)
In-Reply-To: <CAFEp6-3tq4FkiBLO20mk2HU1QkbyVMbyutu11v7b8PSyps2Qjw@mail.gmail.com>
On 10/9/2025 3:15 PM, Loic Poulain wrote:
> Hi Jeff,
>
> On Thu, Oct 9, 2025 at 5:25 PM Dr. David Alan Gilbert <linux@treblig.org> wrote:
>>
>> * Loic Poulain (loic.poulain@oss.qualcomm.com) wrote:
>>> On Thu, Jun 19, 2025 at 3:05 AM <linux@treblig.org> wrote:
>>>>
>>>> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>>>>
>>>> wcn36xx_smd_update_scan_params() last use was removed in 2020 by
>>>> commit 5973a2947430 ("wcn36xx: Fix software-driven scan")
>>>>
>>>> Remove it.
>>>>
>>>> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
>>>
>>> Reviewed-by: Loic Poulain <loic.poulain@oss.qualcomm.com>
>>
>> Hi Loic,
>> Is this getting into a pull somewhere?
>
> Can it be picked for ath10-next?
This was not on my radar since it wasn't sent to linux-wireless and hence
isn't tracked in patchwork. I just looked at it and it seems the following are
now also unused and could be removed:
struct wcn36xx_hal_update_scan_params_resp
struct wcn36xx_hal_update_scan_params_req_ex
Let me know if you want me to take this as-is or wait for a v2. If you send a
v2 please also include linux-wireless so that it is tracked by patchwork.
/jeff
next prev parent reply other threads:[~2025-10-10 0:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-19 1:05 linux
2025-06-22 9:10 ` Loic Poulain
2025-10-09 15:25 ` Dr. David Alan Gilbert
2025-10-09 22:15 ` Loic Poulain
2025-10-10 0:08 ` Jeff Johnson [this message]
2025-10-10 0:46 ` Dr. David Alan Gilbert
2025-10-10 19:13 ` Loic Poulain
2025-10-10 20:07 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83b4ff7d-2443-4ba9-8103-77c8dde518f2@oss.qualcomm.com \
--to=jeff.johnson@oss.qualcomm.com \
--cc=jjohnson@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@treblig.org \
--cc=loic.poulain@oss.qualcomm.com \
--cc=wcn36xx@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®