mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@debian.org>
To: Shih-Yuan Lee <fourdollars@debian.org>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v14 1/3] spi: pxa2xx: disable DMA for Apple MacBook8,1
Date: Sat, 18 Jul 2026 21:01:24 +0100	[thread overview]
Message-ID: <83b8893f-5e9d-42e7-aa01-6e2b825f42e5@sirena.org.uk> (raw)
In-Reply-To: <20260718160702.7861-2-fourdollars@debian.org>

[-- Attachment #1: Type: text/plain, Size: 525 bytes --]

On Sun, Jul 19, 2026 at 12:07:00AM +0800, Shih-Yuan Lee wrote:

> Move the forced PIO mode DMI quirk to spi-pxa2xx-pci.c (the LPSS host
> controller PCI glue driver) to avoid layering violations in client
> drivers (such as applespi).

> Add an explicit DMI match table for MacBook8,1 and a module parameter
> spi_pxa2xx_force_pio to allow forcing PIO mode on demand.

Note that this will mean that the runtime PM bugs fixed in patch 2 are
exposed, breaking bisection on the affected platform.  The actual change
looks fine.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2026-07-18 20:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-18 16:06 [PATCH v14 0/3] spi: pxa2xx: MacBook8,1 quirk, runtime PM, and LPSS S3 resume state fixes Shih-Yuan Lee
2026-07-18 16:07 ` [PATCH v14 1/3] spi: pxa2xx: disable DMA for Apple MacBook8,1 Shih-Yuan Lee
2026-07-18 20:01   ` Mark Brown [this message]
2026-07-18 16:07 ` [PATCH v14 2/3] spi: pxa2xx: fix runtime PM and interrupt handling in PIO mode Shih-Yuan Lee
2026-07-18 20:14   ` Mark Brown
2026-07-18 16:07 ` [PATCH v14 3/3] spi: pxa2xx: restore LPSS private register state on S3 resume Shih-Yuan Lee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83b8893f-5e9d-42e7-aa01-6e2b825f42e5@sirena.org.uk \
    --to=broonie@debian.org \
    --cc=fourdollars@debian.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®