From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Tomer Maimon <tmaimon77@gmail.com>
Cc: Avi Fishman <avifishman70@gmail.com>,
Tali Perry <tali.perry1@gmail.com>, Joel Stanley <joel@jms.id.au>,
Patrick Venture <venture@google.com>,
Nancy Yuen <yuenn@google.com>,
Benjamin Fair <benjaminfair@google.com>,
Jonathan Cameron <jic23@kernel.org>,
minyard@acm.org, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
OpenBMC Maillist <openbmc@lists.ozlabs.org>,
openipmi-developer@lists.sourceforge.net,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>
Subject: Re: [PATCH v2] dt-binding: ipmi: add fallback to npcm845 compatible
Date: Mon, 8 Aug 2022 09:26:57 +0300 [thread overview]
Message-ID: <83bbcb33-1f6e-47cc-54bc-e0a5444c3609@linaro.org> (raw)
In-Reply-To: <CAP6Zq1ju4=PSiCuDaCi2NQTniaXBwmv5Qn6LoLayGmiayDCvYg@mail.gmail.com>
On 07/08/2022 09:51, Tomer Maimon wrote:
> Hi Krzysztof,
>
> Thanks for your review.
>
> On Fri, 5 Aug 2022 at 09:36, Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> On 04/08/2022 20:18, Tomer Maimon wrote:
>>> Add to npcm845 KCS compatible string a fallback to npcm750 KCS compatible
>>> string becuase NPCM845 and NPCM750 BMCs are using identical KCS modules.
>>>
>>> Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
>>
>> Your previous commit adding that compatible was simply wrong and not
>> matching the driver and it is not the first time. I think all Nuvoton
>> patches need much more careful review :(
> Will do and sorry about all the mess...
>>
>> You forgot the fixes tag:
>>
>> Fixes: 84261749e58a ("dt-bindings: ipmi: Add npcm845 compatible")
> Will add the tag next version.
You received a bit different review from Corey, so to be clear:
1. Your approach is correct, assuming the devices are really compatible.
2. Add a fixes tag and send a v3, to get my ack.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-08-08 6:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-04 18:18 Tomer Maimon
2022-08-05 6:36 ` Krzysztof Kozlowski
2022-08-07 7:51 ` Tomer Maimon
2022-08-08 6:26 ` Krzysztof Kozlowski [this message]
2022-08-08 7:40 ` Tomer Maimon
2022-08-05 11:58 ` Corey Minyard
2022-08-07 8:03 ` Tomer Maimon
2022-08-07 12:11 ` Corey Minyard
2022-08-07 14:54 ` Tomer Maimon
2022-08-07 16:05 ` Corey Minyard
2022-08-08 6:25 ` Krzysztof Kozlowski
2022-08-08 6:24 ` Krzysztof Kozlowski
2022-08-08 6:23 ` Krzysztof Kozlowski
2022-08-08 6:20 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83bbcb33-1f6e-47cc-54bc-e0a5444c3609@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=avifishman70@gmail.com \
--cc=benjaminfair@google.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@acm.org \
--cc=openbmc@lists.ozlabs.org \
--cc=openipmi-developer@lists.sourceforge.net \
--cc=robh+dt@kernel.org \
--cc=tali.perry1@gmail.com \
--cc=tmaimon77@gmail.com \
--cc=venture@google.com \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®