From: Quentin Monnet <quentin.monnet@netronome.com>
To: Jiri Olsa <jolsa@redhat.com>, Daniel Borkmann <daniel@iogearbox.net>
Cc: Jiri Olsa <jolsa@kernel.org>, Alexei Starovoitov <ast@kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
netdev@vger.kernel.org
Subject: Re: [PATCHv2 2/2] bpftool: Adjust to new print_bpf_insn interface
Date: Wed, 21 Mar 2018 17:30:30 +0000 [thread overview]
Message-ID: <83bca487-ade9-7b8e-c303-11256ce50d77@netronome.com> (raw)
In-Reply-To: <20180321170019.GE2707@krava>
2018-03-21 18:00 UTC+0100 ~ Jiri Olsa <jolsa@redhat.com>
> On Wed, Mar 21, 2018 at 05:44:52PM +0100, Daniel Borkmann wrote:
>
> SNIP
>
>>>> Hi Jiri, this code has changed in the tree. It was moved to
>>>> tools/bpf/bpftool/xlated_dumper.c, and there is now a third function to
>>>> update: print_insn_for_graph(). Could you please rebase the patch?
>>>
>>> sure.. I was over perf tree, I'll check on bpf tree
>>
>> Just to be sure, it should be bpf-next. bpf is for fixes only.
>
> v2 attached
>
> thanks,
> jirka
>
>
> ---
> Change bpftool to skip the removed struct bpf_verifier_env
> argument in print_bpf_insn. It was passed as NULL anyway.
>
> No functional change intended.
>
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> ---
> tools/bpf/bpftool/xlated_dumper.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
Thank you!
Reviewed-by: Quentin Monnet <quentin.monnet@netronome.com>
next prev parent reply other threads:[~2018-03-21 17:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-21 15:02 [PATCH 1/2] bpf: Remove struct bpf_verifier_env argument from print_bpf_insn Jiri Olsa
2018-03-21 15:02 ` [PATCH 2/2] bpftool: Adjust to new print_bpf_insn interface Jiri Olsa
2018-03-21 16:39 ` Quentin Monnet
2018-03-21 16:43 ` Jiri Olsa
2018-03-21 16:44 ` Daniel Borkmann
2018-03-21 17:00 ` [PATCHv2 " Jiri Olsa
2018-03-21 17:30 ` Quentin Monnet [this message]
2018-03-21 17:25 ` [PATCH 1/2] bpf: Remove struct bpf_verifier_env argument from print_bpf_insn Quentin Monnet
2018-03-21 18:37 ` Jiri Olsa
2018-03-22 9:34 ` Daniel Borkmann
2018-03-22 13:32 ` Jiri Olsa
2018-03-22 15:35 ` Quentin Monnet
2018-03-22 15:57 ` Jiri Olsa
2018-03-22 16:07 ` Daniel Borkmann
2018-03-23 9:09 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83bca487-ade9-7b8e-c303-11256ce50d77@netronome.com \
--to=quentin.monnet@netronome.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®